-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Polkadot & Kusama native runtime #1304
Conversation
c8d6efe
to
d13958e
Compare
This pull request removes the Polkadot and Kusama native runtime from the polkadot node. This brings some implications with it: 1. There are no more `kusama/polkadot-dev` chain specs available. We will need to write some tooling in the fellowship repo to provide them easily. 2. The `try-runtime` job for polkadot & kusama is not available anymore as we don't have the dev chain specs anymore. 3. Certain benchmarking commands will also not work until we migrate them to use a runtime api. Some crates in `utils` are still depending on the polkadot/kusama native runtime that will also need to be fixed.
…ot-kusama-native-runtime
d13958e
to
e7775c4
Compare
Why not remove westend and rococo as well? |
This is mainly a step for preparing the removal of the runtimes from this repo. If we have the new chain spec stuff ready, we can remove the rest as well. |
Will be removed in #1304 anyway. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Fix deterministic WASM check Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Fix build-staking-miner Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Remove Kusama and Polkadot runtime-migration checks Will be removed in #1304 anyway. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
…ot-kusama-native-runtime
* Fix deterministic WASM check Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Fix build-staking-miner Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Remove Kusama and Polkadot runtime-migration checks Will be removed in #1304 anyway. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Is there a task tracking also removing SP runtimes from here? |
|
Closes #1372 This fixes the target directories in the polkadot readme. I verified manually the Ubuntu based install works on a fresh cloud machine. Build from source also worked as described. Since #1304 landed `--dev` also works again (not on v1.1.0 though), so I would consider the install instructions fixed.
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/polkadot-release-analysis-v1-2-0/4451/1 |
Closes paritytech#1372 This fixes the target directories in the polkadot readme. I verified manually the Ubuntu based install works on a fresh cloud machine. Build from source also worked as described. Since paritytech#1304 landed `--dev` also works again (not on v1.1.0 though), so I would consider the install instructions fixed.
This pull request removes the Polkadot and Kusama native runtime from the polkadot node. This brings some implications with it:
Some crates in utils are still depending on the polkadot/kusama native runtime that will also need to be fixed.
Port of: paritytech/polkadot#7467