Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Polkadot & Kusama native runtime #1304

Merged
merged 23 commits into from
Sep 19, 2023

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Aug 30, 2023

This pull request removes the Polkadot and Kusama native runtime from the polkadot node. This brings some implications with it:

There are no more kusama/polkadot-dev chain specs available. We will need to write some tooling in the fellowship repo to provide them easily.

The try-runtime job for polkadot & kusama is not available anymore as we don't have the dev chain specs anymore.

Certain benchmarking commands will also not work until we migrate them to use a runtime api.

Some crates in utils are still depending on the polkadot/kusama native runtime that will also need to be fixed.

Port of: paritytech/polkadot#7467

@bkchr bkchr added the T8-polkadot This PR/Issue is related to/affects the Polkadot network. label Aug 30, 2023
@bkchr bkchr force-pushed the bkchr-remove-polkadot-kusama-native-runtime branch from c8d6efe to d13958e Compare August 30, 2023 10:55
This pull request removes the Polkadot and Kusama native runtime from
the polkadot node. This brings some implications with it:

1. There are no more `kusama/polkadot-dev` chain specs available. We
will need to write some tooling in the fellowship repo to provide them
easily.

2. The `try-runtime` job for polkadot & kusama is not available anymore
as we don't have the dev chain specs anymore.

3. Certain benchmarking commands will also not work until we migrate
them to use a runtime api.

Some crates in `utils` are still depending on the polkadot/kusama native
runtime that will also need to be fixed.
@bkchr bkchr force-pushed the bkchr-remove-polkadot-kusama-native-runtime branch from d13958e to e7775c4 Compare August 30, 2023 11:00
@paritytech-ci paritytech-ci requested review from a team August 30, 2023 11:09
@arkpar
Copy link
Member

arkpar commented Aug 30, 2023

Why not remove westend and rococo as well?

@bkchr
Copy link
Member Author

bkchr commented Aug 30, 2023

Why not remove westend and rococo as well?

This is mainly a step for preparing the removal of the runtimes from this repo. If we have the new chain spec stuff ready, we can remove the rest as well.

ggwpez added a commit that referenced this pull request Aug 30, 2023
Will be removed in #1304 anyway.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez added a commit that referenced this pull request Aug 30, 2023
* Fix deterministic WASM check

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix build-staking-miner

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Remove Kusama and Polkadot runtime-migration checks

Will be removed in #1304 anyway.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Daanvdplas pushed a commit that referenced this pull request Sep 11, 2023
* Fix deterministic WASM check

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix build-staking-miner

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Remove Kusama and Polkadot runtime-migration checks

Will be removed in #1304 anyway.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@liamaharon
Copy link
Contributor

Is there a task tracking also removing SP runtimes from here?

@bkchr
Copy link
Member Author

bkchr commented Sep 19, 2023

Is there a task tracking also removing SP runtimes from here?

#603

@bkchr bkchr merged commit 6079b6d into master Sep 19, 2023
7 checks passed
@bkchr bkchr deleted the bkchr-remove-polkadot-kusama-native-runtime branch September 19, 2023 11:07
skunert added a commit that referenced this pull request Sep 22, 2023
Closes #1372 

This fixes the target directories in the polkadot readme. I verified
manually the Ubuntu based install works on a fresh cloud machine. Build
from source also worked as described.

Since #1304 landed `--dev` also works again (not on v1.1.0 though), so I
would consider the install instructions fixed.
@joepetrowski joepetrowski mentioned this pull request Sep 27, 2023
3 tasks
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v1-2-0/4451/1

bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
Closes paritytech#1372 

This fixes the target directories in the polkadot readme. I verified
manually the Ubuntu based install works on a fresh cloud machine. Build
from source also worked as described.

Since paritytech#1304 landed `--dev` also works again (not on v1.1.0 though), so I
would consider the install instructions fixed.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
bkchr pushed a commit that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants