pallet vesting / update to use fungible #1760
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianenigma
reviewed
Oct 2, 2023
kianenigma
reviewed
Oct 2, 2023
| Moment = BlockNumberFor<Self>, | ||
| Fungible = Self::Fungible, | ||
| >; | ||
| type Fungible: fungible::Inspect<Self::AccountId, Balance = Self::Balance> |
There was a problem hiding this comment.
Suggested change
| type Fungible: fungible::Inspect<Self::AccountId, Balance = Self::Balance> | |
| type Currency: fungible::Inspect<Self::AccountId, Balance = Self::Balance> |
There was a problem hiding this comment.
Or type NativeToken, as suggested in #226 (comment)
kianenigma
reviewed
Oct 2, 2023
|
|
||
| /// A vesting schedule over a fungible. This allows a particular fungible to have vesting limits | ||
| /// applied to it. | ||
| pub trait VestingSchedule<AccountId>: Sized { |
There was a problem hiding this comment.
At a later date Currency is likely to be removed. At that point it's going to be all alone in the traits::tokens::currency namespace. Is there a better namespace for it to migrate to or should we leave it where it is for now even though it now takes a Fungible?
33 tasks
1 task
|
Any update on this? #3951 is almost merged, and if we merge this I think we can finally have vesting of pallet-assets tokens on AssetHub, which would bring a lot of added value to AssetHub |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the vesting pallet to use the new fungible traits rather than the now deprecated
CurrencyandReserveCurrencytraits ( paritytech/substrate#12951 ). Partial fix of #226.TODO:
add_locksin benchmark needs a rethink because RuntimeFreezeReasons isn't a[u8;8]