Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement pallet-assets-freezer #3951

Merged
merged 35 commits into from
Jun 21, 2024
Merged

Implement pallet-assets-freezer #3951

merged 35 commits into from
Jun 21, 2024

Conversation

pandres95
Copy link
Contributor

@pandres95 pandres95 commented Apr 2, 2024 •
edited
Loading

Closes #3342

cc/ @liamaharon

TODO:

polkadot address: 12gMhxHw8QjEwLQvnqsmMVY1z5gFa54vND74aMUbhhwN6mJR

@pandres95 pandres95 force-pushed the pandres95--pallet-assets-freezer branch 9 times, most recently from f2c9643 to 5fae57f Compare April 3, 2024 02:01
@liamaharon liamaharon added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Apr 3, 2024
liamaharon
liamaharon reviewed Apr 3, 2024
View reviewed changes
substrate/frame/assets-freezer/README.md Outdated Show resolved Hide resolved
substrate/frame/assets-freezer/src/impls.rs Outdated Show resolved Hide resolved
substrate/frame/assets-freezer/src/impls.rs Outdated Show resolved Hide resolved
substrate/frame/assets-freezer/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/assets-freezer/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/assets-freezer/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/assets-freezer/src/mock.rs Outdated Show resolved Hide resolved
@pandres95 pandres95 requested a review from liamaharon April 3, 2024 15:49
@pandres95 pandres95 force-pushed the pandres95--pallet-assets-freezer branch 2 times, most recently from f59c9ea to 29c0925 Compare April 3, 2024 16:32
@pandres95 pandres95 changed the title FRAME: Pallet Assets Freezer Implemen pallet-assets-freezer Apr 3, 2024
@pandres95 pandres95 changed the title Implemen pallet-assets-freezer Implement pallet-assets-freezer Apr 3, 2024
@pandres95 pandres95 force-pushed the pandres95--pallet-assets-freezer branch 4 times, most recently from b0b6f59 to c4681b6 Compare April 4, 2024 00:49
liamaharon
liamaharon reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor

@liamaharon liamaharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pallet extension generally looking really good!

pallet-assets also needs to be modified to allow attaching it, let me know if it's clear enough from Gav's PR how to could do that or if you need some pointers.

substrate/frame/assets-freezer/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/assets-freezer/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/assets-freezer/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/assets-freezer/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/assets-freezer/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/assets-freezer/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/assets-freezer/src/impls.rs Outdated Show resolved Hide resolved
substrate/frame/assets-freezer/src/tests.rs Show resolved Hide resolved
substrate/frame/assets-freezer/src/types.rs Outdated Show resolved Hide resolved
substrate/frame/assets-freezer/src/types.rs Outdated Show resolved Hide resolved
@pandres95 pandres95 requested a review from liamaharon April 4, 2024 17:07
@pandres95 pandres95 force-pushed the pandres95--pallet-assets-freezer branch 2 times, most recently from bdff229 to 56ac28b Compare April 4, 2024 20:34
@pandres95 pandres95 force-pushed the pandres95--pallet-assets-freezer branch from 0e5e4c6 to 0f76c41 Compare April 11, 2024 15:49
muharem
muharem approved these changes Apr 12, 2024
View reviewed changes
substrate/frame/assets-freezer/src/lib.rs Outdated Show resolved Hide resolved
@joepetrowski joepetrowski mentioned this pull request Apr 12, 2024
Merged
@liamaharon
Copy link
Contributor

/tip medium

@substrate-tip-bot substrate-tip-bot
Copy link

@liamaharon A referendum for a medium (80 DOT) tip was successfully submitted for @pandres95 (12gMhxHw8QjEwLQvnqsmMVY1z5gFa54vND74aMUbhhwN6mJR on polkadot).

Referendum number: 670.
tip

@substrate-tip-bot substrate-tip-bot
Copy link

The referendum has appeared on Polkassembly.

@joepetrowski joepetrowski mentioned this pull request May 19, 2024
Open
2 tasks
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/decoded-2024-sponsorship-for-active-community-members/7654/71

@muharem
Copy link
Contributor

muharem commented Jun 17, 2024

@pandres95 can you please resolve the conflicts and merge the master. we merge this after

@pandres95
Copy link
Contributor Author

Done @muharem

@muharem
Copy link
Contributor

muharem commented Jun 18, 2024

@pandres95 can you check failing check-umbrella CI, it's marked as required

@pandres95
Copy link
Contributor Author

@muharem fixed

@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-kusama-bridge/2971/56

@JuaniRios JuaniRios mentioned this pull request Jun 20, 2024
Closed
@bkontur bkontur mentioned this pull request Jun 20, 2024
Open
@muharem muharem added this pull request to the merge queue Jun 21, 2024
Merged via the queue into paritytech:master with commit a477bd0 Jun 21, 2024
155 of 157 checks passed
@pandres95 pandres95 deleted the pandres95--pallet-assets-freezer branch June 21, 2024 19:54
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@pandres95 @liamaharon @TarekkMA
Implement pallet-assets-freezer (paritytech#3951)
b0967d0 
Closes paritytech#3342

cc/ @liamaharon

TODO:

- [x] Improve docs.
- [x] Define public interface (See paritytech#3342).
  In case we define public calls to the pallet implementation:
  - Implement public calls.
  - Benchmarks.
  
polkadot address: 12gMhxHw8QjEwLQvnqsmMVY1z5gFa54vND74aMUbhhwN6mJR

---------

Co-authored-by: command-bot <>
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
This was referenced Aug 21, 2024
Closed
Closed
@TDemeco TDemeco mentioned this pull request Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamaharon liamaharon liamaharon approved these changes

@muharem muharem muharem approved these changes

Assignees
No one assigned
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
Security Audit (PRs) - SRLabs
Status: Audited
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Assets] Implement fungibles::freeze::Mutate
4 participants
@pandres95 @liamaharon @Polkadot-Forum @muharem