Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vesting to Asset Hubs #269

Conversation

joepetrowski
Copy link
Contributor

Adds the Vesting pallet to the Asset Hub runtimes, as a few people have requested this feature, and in general the Asset Hubs should provide more balances/asset-related features than the Relay Chain.

@joepetrowski joepetrowski mentioned this pull request Apr 10, 2024
9 tasks
Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@xlc
Copy link
Contributor

xlc commented Apr 12, 2024

Why will anyone else other than W3F want to perform vested transfer of DOT? When people requesting vesting, presumably they want to vest transfer assets in pallet-assets, not the relaychain token.

@joepetrowski
Copy link
Contributor Author

Why will anyone else other than W3F want to perform vested transfer of DOT? When people requesting vesting, presumably they want to vest transfer assets in pallet-assets, not the relaychain token.

For one, the person who requested this was from Talisman, not W3F, for DOT.

Two, it would be great if Parity and W3F used Asset Hub instead of the Relay Chain for vested DOT transfers.

Three, yes I understand the demand for vested transfers of assets. This PR does not prevent that.

@acatangiu
Copy link
Contributor

Why will anyone else other than W3F want to perform vested transfer of DOT? When people requesting vesting, presumably they want to vest transfer assets in pallet-assets, not the relaychain token.

I agree we also need vesting for pallet-assets instances too, not just pallet-balances.

example community request: paritytech/polkadot-sdk#4090

Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add vesting to pallet-assets instances too

@joepetrowski
Copy link
Contributor Author

add vesting to pallet-assets instances too

That is the plan, but the Vesting pallet requires something with LockableCurrency, which pallet-assets does not implement. In order to have vesting for assets, we need:

  1. Migration of Vesting pallet from Currency to Fungible;
  2. An implementation of fungible::freeze for pallet-assets (Implement pallet-assets-freezer paritytech/polkadot-sdk#3951)

I don't think we should block the feature of vesting DOT on waiting for these. Asset vesting will probably be another instance of the Vesting pallet anyway, so they have no overlap.

Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding vesting in two steps: this PR pallet-balances, future PR pallet-assets is fine

@joepetrowski
Copy link
Contributor Author

/merge

@fellowship-merge-bot fellowship-merge-bot bot merged commit 31ba262 into polkadot-fellows:main Apr 15, 2024
37 of 38 checks passed
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@joepetrowski joepetrowski deleted the add-vesting-to-asset-hubs branch April 15, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants