Implements maximum validator payout per era #1859
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpestana
added
the
T1-FRAME
|
The CI pipeline was cancelled due to failure one of the required jobs. |
6 tasks
1 task
kianenigma
reviewed
Nov 6, 2023
| @@ -352,7 +353,8 @@ impl pallet_staking::Config for Runtime { | |||
| type SlashDeferDuration = SlashDeferDuration; | |||
| type AdminOrigin = frame_system::EnsureNever<()>; | |||
| type SessionInterface = Self; | |||
| type EraPayout = pallet_staking::ConvertCurve<RewardCurve>; | |||
| type MaxValidatorsPayout = MaxValidatorsPayout; | |||
There was a problem hiding this comment.
Suggested change
| type MaxValidatorsPayout = MaxValidatorsPayout; |
If you were to do this approach, I don't think there is any need to pass MaxValidatorsPayout to the staking pallet. Whatever cap is needed, should already be applied to RewardCurve or whatever type is implementing type EraPayout.
kianenigma
requested changes
Nov 6, 2023
There was a problem hiding this comment.
A bit wrong because of https://github.com/paritytech/polkadot-sdk/pull/1859/files#r1382983349, but in any case we probably won't need it.
|
Closing due to #403 (comment) |
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
* message delivery transaction is not free!!! * test pays_fee
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an (optional) cap of the era inflation that is allocated to staking rewards. This mechanism can be used to guarantee a minimum treasury inflow as per this discussion.
The (percent) maximum validators payout can be set through
SystemCall::set_storage.Note: The
storageparameter type in the runtime configs only sets the pre-set_storagedefault value. Once the value is set on-chain, the default will be a noop and not anymore a source of truth.Todo (once merged)
era_payoutimpl included)Related to and possibly replacing #1660
Closes #403