Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Collator Selection] Fix weight refund for set_candidacy_bond #3643

Merged

Conversation

georgepisaltu
Copy link
Contributor

Fixes #3642

This PR implements the weight refund of pallet_collator_selection::set_candidacy_bond to account for no iterations when the bond is decreased.

Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
@georgepisaltu georgepisaltu added I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. T2-pallets This PR/Issue is related to a particular pallet. labels Mar 11, 2024
@georgepisaltu georgepisaltu self-assigned this Mar 11, 2024
@bkchr bkchr removed the I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. label Mar 11, 2024
@bkchr
Copy link
Member

bkchr commented Mar 11, 2024

@georgepisaltu please add a prdoc.

Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
@georgepisaltu georgepisaltu added this pull request to the merge queue Mar 11, 2024
Merged via the queue into paritytech:master with commit 7839400 Mar 11, 2024
129 of 130 checks passed
@georgepisaltu georgepisaltu deleted the fix-set-candidacy-bond-weight branch March 11, 2024 22:45
ordian added a commit that referenced this pull request Mar 16, 2024
* master: (65 commits)
  collator protocol changes for elastic scaling (validator side) (#3302)
  Contracts use polkavm workspace deps (#3715)
  Add elastic scaling support in ParaInherent BenchBuilder  (#3690)
  Removes `as [disambiguation_path]` from `derive_impl` usage (#3652)
  fix(paseo-spec): New Paseo Bootnodes (#3674)
  Improve Penpal runtime + emulated tests (#3543)
  Staking ledger bonding fixes (#3639)
  DescribeAllTerminal for HashedDescription (#3349)
  Increase timeout for assertions (#3680)
  Add subsystems regression tests to CI (#3527)
  Always print connectivity report (#3677)
  Revert "FRAME: Create `TransactionExtension` as a replacement for `SignedExtension` (#2280)" (#3665)
  authority-discovery: Add log for debugging DHT authority records (#3668)
  Construct Runtime v2  (#1378)
  Support for `keyring` in runtimes (#2044)
  Add api-name in `cannot query the runtime API version` warning (#3653)
  Add a PolkaVM-based executor (#3458)
  Adds default config for assets pallet (#3637)
  Bump handlebars from 4.3.7 to 5.1.0 (#3248)
  [Collator Selection] Fix weight refund for `set_candidacy_bond` (#3643)
  ...
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Mar 24, 2024
…tytech#3643)

Fixes paritytech#3642 

This PR implements the weight refund of
`pallet_collator_selection::set_candidacy_bond` to account for no
iterations when the bond is decreased.

---------

Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete weight refund for set_candidacy_bond in pallet_collator_selection
3 participants