Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elastic scaling support in ParaInherent BenchBuilder #3690

Merged
merged 5 commits into from
Mar 15, 2024

Conversation

sandreim
Copy link
Contributor

@sandreim sandreim commented Mar 14, 2024

Extracted Benchbuilder enhancements used in #3644 . Might still require some work to fully support all scenarios when disputing elastic scaling parachains, but it should be useful in writing elastic scaling runtime tests.

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim sandreim added R0-silent Changes should not be mentioned in any release notes T10-tests This PR/Issue is related to tests. T12-benchmarks This PR/Issue is related to benchmarking and weights. labels Mar 14, 2024
Copy link
Contributor

@alindima alindima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we also add the benchmark from #3644. The current code on master should already allow supplying multiple candidates if elastic scaling mvp feature is enabled (but only one will be backed). We have a test that does that:

fn backing_works_with_elastic_scaling_mvp() {

polkadot/runtime/parachains/src/builder.rs Outdated Show resolved Hide resolved
polkadot/runtime/parachains/src/builder.rs Outdated Show resolved Hide resolved
polkadot/runtime/parachains/src/builder.rs Outdated Show resolved Hide resolved
polkadot/runtime/parachains/src/builder.rs Show resolved Hide resolved
@sandreim
Copy link
Contributor Author

I suggest we also add the benchmark from #3644. The current code on master should already allow supplying multiple candidates if elastic scaling mvp feature is enabled (but only one will be backed). We have a test that does that:

fn backing_works_with_elastic_scaling_mvp() {

Not sure which benchmark you are refering to. If you re talking about the big inherent, it just doesn't make sense, that is for testing purposes, we don't need that weight.

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@alindima
Copy link
Contributor

Not sure which benchmark you are refering to. If you re talking about the big inherent, it just doesn't make sense, that is for testing purposes, we don't need that weight.

A variation of the big inherent thingy. With realistic values, which exercises multiple candidates for a para (this is already allowed by the runtime). Otherwise, I'll add it in #3479 (but that PR is getting quite big and I could use the help :D )

@alindima alindima added this pull request to the merge queue Mar 15, 2024
Merged via the queue into master with commit 4987d79 Mar 15, 2024
135 of 136 checks passed
@alindima alindima deleted the sandreim/bench_builder_elastic_scaling branch March 15, 2024 12:06
ordian added a commit that referenced this pull request Mar 16, 2024
* master: (65 commits)
  collator protocol changes for elastic scaling (validator side) (#3302)
  Contracts use polkavm workspace deps (#3715)
  Add elastic scaling support in ParaInherent BenchBuilder  (#3690)
  Removes `as [disambiguation_path]` from `derive_impl` usage (#3652)
  fix(paseo-spec): New Paseo Bootnodes (#3674)
  Improve Penpal runtime + emulated tests (#3543)
  Staking ledger bonding fixes (#3639)
  DescribeAllTerminal for HashedDescription (#3349)
  Increase timeout for assertions (#3680)
  Add subsystems regression tests to CI (#3527)
  Always print connectivity report (#3677)
  Revert "FRAME: Create `TransactionExtension` as a replacement for `SignedExtension` (#2280)" (#3665)
  authority-discovery: Add log for debugging DHT authority records (#3668)
  Construct Runtime v2  (#1378)
  Support for `keyring` in runtimes (#2044)
  Add api-name in `cannot query the runtime API version` warning (#3653)
  Add a PolkaVM-based executor (#3458)
  Adds default config for assets pallet (#3637)
  Bump handlebars from 4.3.7 to 5.1.0 (#3248)
  [Collator Selection] Fix weight refund for `set_candidacy_bond` (#3643)
  ...
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Mar 24, 2024
…3690)

Extracted Benchbuilder enhancements used in
paritytech#3644 . Might still
require some work to fully support all scenarios when disputing elastic
scaling parachains, but it should be useful in writing elastic scaling
runtime tests.

---------

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T10-tests This PR/Issue is related to tests. T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants