Bridge: make some headers submissions free #4102

svyatonik · 2024-04-12T12:55:38Z

supersedes paritytech/parity-bridges-common#2873

Draft because of couple of TODOs:

fix remaining TODOs;
double check that all changes from Make some headers submissions free parity-bridges-common#2873 are correctly ported;
create a separate PR (on top of that one or a follow up?) for https://github.com/paritytech/polkadot-sdk/tree/sv-try-new-bridge-fees;
fix compilation issues (haven't checked, but there should be many).

…of_ex + check it from the transaction extension

… to RefundBridgedGrandpaMessages

… messages transactions

…ty (this is not used yet - see next commit)

…ge GRANDPA transactions are obsolete and, if not, it may apply priority boost to

…coming from CheckAndBoostBridgeGrandpaTransactions

…de of tx body, it is `None` and otherwise it is `Some`

…xtension

…`improved_by` from extension code

acatangiu

really good test coverage too! 💪

acatangiu · 2024-04-23T11:59:47Z

bridges/chains/chain-bridge-hub-rococo/src/lib.rs

-	pub const BridgeHubRococoBaseDeliveryFeeInRocs: u128 = 5_651_581_649;
+	pub const BridgeHubRococoBaseDeliveryFeeInRocs: u128 = 314_037_860;

 	/// Transaction fee that is paid at the Rococo BridgeHub for delivering single outbound message confirmation.
 	/// (initially was calculated by test `BridgeHubRococo::can_calculate_fee_for_complex_message_confirmation_transaction` + `33%`)
-	pub const BridgeHubRococoBaseConfirmationFeeInRocs: u128 = 5_380_901_781;
+	pub const BridgeHubRococoBaseConfirmationFeeInRocs: u128 = 57_414_813;


10x-15x reduction ❤️

prdoc/pr_4102.prdoc

serban300

Looks good !

bridges/primitives/runtime/src/chain.rs

.gitlab/pipeline/zombienet.yml

bridges/bin/runtime-common/src/extensions/check_obsolete_extension.rs

bkontur · 2024-04-23T13:00:33Z

cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/Cargo.toml

@@ -22,6 +22,7 @@ scale-info = { version = "2.11.1", default-features = false, features = [
 	"derive",
 ] }
 serde = { optional = true, features = ["derive"], workspace = true, default-features = true }
+tuplex = { version = "0.1", default-features = false }


where do we use tuplex here in BHR or BHW? Or is it because of some macro expansion?

Yes, that is used by generate_bridge_reject_obsolete_headers_and_messages

aha, ok, I am not sure if it is possible to hide/re-export tuplex inside that macro, I think we did something similar for other macros for paste?

// Re-export macro to avoid include paste dependency everywhere pub use sp_runtime::paste;

but also ok to leave it as it is

cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/tests/tests.rs

paritytech-cicd-pr · 2024-04-23T13:06:21Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6026453

…ot-sdk

…ity for free

supersedes paritytech/parity-bridges-common#2873 Draft because of couple of TODOs: - [x] fix remaining TODOs; - [x] double check that all changes from paritytech/parity-bridges-common#2873 are correctly ported; - [x] create a separate PR (on top of that one or a follow up?) for https://github.com/paritytech/polkadot-sdk/tree/sv-try-new-bridge-fees; - [x] fix compilation issues (haven't checked, but there should be many). --------- Co-authored-by: Adrian Catangiu <adrian@parity.io>

svyatonik · 2024-05-08T08:31:33Z

The plan is to deploy it on Rococo <> Westend before the next release. So I've prepared a branch: https://github.com/paritytech/polkadot-sdk/tree/sv-new-bridges-burning. It is forked from last release and all required commits are cherry-picked:

    git checkout polkadot-v1.11.0
    git checkout -b sv-new-bridges-burning
    git cherry-pick a633e954f3b88697aa797d9792e8a5b5cf310b7e
    git cherry-pick 7e68b2b8da9caf634ff4f6c6d96d2d7914c44fb7
    git cherry-pick a99948939785eb62377a235b448a7f4ae65c01b1
    git cherry-pick 871281783c1be03157319d5143096fd3dd860d0a
    + bump Rococo and Westend BH versions to 1_011_001

I'll build Rococo and Westend BH runtimes on monday and we'll do a upgrade. Then we need to migrate all our relayers to our new scheme - guess it can take a couple of days. After that, we need to update our dashboards and alerts (it should be easy).

…#4385) silent, because it'll be deployed with the #4102, where this code has been introduced I've planned originally to avoid doing that check in the runtime code, because it **may be** checked offchain. But actually, the check is quite cheap and we could do that onchain too.

…paritytech#4385) silent, because it'll be deployed with the paritytech#4102, where this code has been introduced I've planned originally to avoid doing that check in the runtime code, because it **may be** checked offchain. But actually, the check is quite cheap and we could do that onchain too.

bridges/bin/runtime-common/src/extensions/check_obsolete_extension.rs

supersedes paritytech/parity-bridges-common#2873 Draft because of couple of TODOs: - [x] fix remaining TODOs; - [x] double check that all changes from paritytech/parity-bridges-common#2873 are correctly ported; - [x] create a separate PR (on top of that one or a follow up?) for https://github.com/paritytech/polkadot-sdk/tree/sv-try-new-bridge-fees; - [x] fix compilation issues (haven't checked, but there should be many). --------- Co-authored-by: Adrian Catangiu <adrian@parity.io>

…paritytech#4385) silent, because it'll be deployed with the paritytech#4102, where this code has been introduced I've planned originally to avoid doing that check in the runtime code, because it **may be** checked offchain. But actually, the check is quite cheap and we could do that onchain too.

Relates to: paritytech/parity-bridges-common#2451 Closes: paritytech/parity-bridges-common#2500 ## Summary Now, the bridging pallet supports only static lanes, which means lanes that are hard-coded in the runtime files. This PR fixes that and adds support for dynamic, also known as permissionless, lanes. This means that allowed origins (relay chain, sibling parachains) can open and close bridges (through BridgeHubs) with another bridged (substrate-like) consensus using just `xcm::Transact` and `OriginKind::Xcm`. _This PR is based on the migrated code from the Bridges V2 [branch](#4427) from the old `parity-bridges-common` [repo](https://github.com/paritytech/parity-bridges-common/tree/bridges-v2)._ ## Explanation Please read [bridges/modules/xcm-bridge-hub/src/lib.rs](https://github.com/paritytech/polkadot-sdk/blob/149b0ac2ce43fba197988f2642032fa24dd8289a/bridges/modules/xcm-bridge-hub/src/lib.rs#L17-L136) to understand how managing bridges works. The basic concepts around `BridgeId` and `LaneId` are also explained there. ## TODO - [x] search and fix for comment: `// TODO:(bridges-v2) - most of that stuff was introduced with free header execution: https://github.com/paritytech/polkadot-sdk/pull/4102` - more info in the comment [bellow](#4427 (comment)) - [x] TODO: there's only one impl of `EnsureOrigin<Success = Location>` ## TODO - not blocking review **benchmarking:** - [x] regenerate all relevant weights for BH/AH runtimes - [ ] regenerate default weights for bridging pallets e.g. `modules/messages/src/weights.rs` - [ ] add benchmarks for `xcm-bridge-hub` pallet #5550 **testing:** - [ ] add xcm-emulator tests for Rococo/Penpal to Westend/Penpal with full opening channel and sending/receiving `xcm::Transact` **migrations:** - [x] add migrations for BridgeHubRococo/Westend paritytech/parity-bridges-common#2794 (to be reusable for P/K bridge) - [x] check also storage migration, if needed for pallets - [ ] migration for XCM type (optional) - [x] migration for static lanes to the dynamic (reuse for fellows) **investigation:** - [ ] revisit paritytech/parity-bridges-common#2380 - [ ] check congestion around `LocalXcmChannelManager` and `OutboundLanesCongestedSignals` impls - #5551 - to be reusable for polkadot-fellows - return `report_bridge_status` was remove, so we need to `XcmpQueue` alternative? --------- Signed-off-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com> Co-authored-by: command-bot <> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>

svyatonik added 30 commits April 12, 2024 13:18

move bridge extensions to a separate folder

bc26ff5

added FreeHeadersInterval to pallet-bridge-grandpa configuration

812d474

added is_free_execution_expected parameter to the submit_finality_pro…

b45fde5

…of_ex + check it from the transaction extension

move grandpa call result check from RefundTransactionExtensionAdapter…

1161805

… to RefundBridgedGrandpaMessages

added RefundBridgedMessages to refund and bump priority of standalone…

148d9b3

… messages transactions

check_obsolete_submit_finality_proof may now boost transaction priori…

3cfd666

…ty (this is not used yet - see next commit)

added CheckAndBoostBridgeGrandpaTransactions that checks whether brid…

38c558b

…ge GRANDPA transactions are obsolete and, if not, it may apply priority boost to

relayer may be slashed to explicit account

ad8edb5

slash registered relayer if it has submitted failed GRANDPA transaction

791ea6a

allow accepting some parachain headers for free

b90615a

added FreeParachainUpdateForFreeRelayHeader

df1928f

fix benchmarks compilation

6d852d4

added WeightInfoExt for pallet-bridge-grandpa to include extra wight …

3209053

…coming from CheckAndBoostBridgeGrandpaTransactions

also refund for submitting initial parachain head

3f95fb0

make FreeHeadersRemaining an Option => we know that when we are outsi…

84c9757

…de of tx body, it is `None` and otherwise it is `Some`

add more traces to pallets

a3831e2

check for reorgs in signed ext for parachains module

1a6baf9

fix benchmarks compilation

3922d6a

free interval instead of fixed free headers

666aad2

fixed trace

efeba93

CannotAcceptMoreFreeHeaders -> FreeHeadersLimitExceded

85a5a40

additional_call_result_check -> check_call_result_ex

0c87d48

is_granda_call_succeeded -> is_grandpa_call_successful

c3f0bc5

move tx priority boost from check_obsolete_submit_finality_proof to e…

8e710d2

…xtension

lost changes

3ca9d7e

dec counter when importing new para header

7f1375b

cherry pick paritytech/parity-bridges-common@bb4ad4b

5772858

added grandpa_and_parachain_pallets_share_free_headers_counter test

61c7ff5

with free intervals (instead of fixed free headers) we need to check …

e0817e9

…`improved_by` from extension code

fix test name

380fe97

acatangiu approved these changes Apr 23, 2024

View reviewed changes

serban300 approved these changes Apr 23, 2024

View reviewed changes

bridges/primitives/runtime/src/chain.rs Show resolved Hide resolved

bkontur reviewed Apr 23, 2024

View reviewed changes

.gitlab/pipeline/zombienet.yml Show resolved Hide resolved

bkontur reviewed Apr 23, 2024

View reviewed changes

bridges/bin/runtime-common/src/extensions/check_obsolete_extension.rs Show resolved Hide resolved

bkontur reviewed Apr 23, 2024

View reviewed changes

added comment

18e15fb

bkontur reviewed Apr 23, 2024

View reviewed changes

cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/tests/tests.rs Show resolved Hide resolved

bkontur approved these changes Apr 23, 2024

View reviewed changes

svyatonik added 2 commits April 23, 2024 16:23

Merge branch 'master' into sv-refund-non-mandatory-headers-fee-polkad…

cad5d31

…ot-sdk

added free_relay_extrinsic_works tests to ensure that we submit final…

cde347f

…ity for free

svyatonik mentioned this pull request Apr 24, 2024

Rename our 'obsolete' extensions to something that actually reflects what they are doing paritytech/parity-bridges-common#2971

Open

svyatonik added this pull request to the merge queue Apr 25, 2024

Merged via the queue into master with commit a633e95 Apr 25, 2024
138 of 140 checks passed

svyatonik deleted the sv-refund-non-mandatory-headers-fee-polkadot-sdk branch April 25, 2024 05:54

svyatonik mentioned this pull request May 6, 2024

Bridge: check bridge GRANDPA pallet call limits from signed extension #4385

Merged

ggwpez reviewed Jun 11, 2024

View reviewed changes

bridges/bin/runtime-common/src/extensions/check_obsolete_extension.rs Show resolved Hide resolved

peterwht mentioned this pull request Aug 15, 2024

chore: upgrade to 1.12.0 r0gue-io/pop-node#193

Merged

This was referenced Aug 21, 2024

Update polkadot-sdk from v1.11.0 to stable2407 moondance-labs/tanssi#659

Open

Update polkadot-sdk from v1.11.0 to stable2407 moonbeam-foundation/moonbeam#2912

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bridge: make some headers submissions free #4102

Bridge: make some headers submissions free #4102

svyatonik commented Apr 12, 2024 •

edited

Loading

acatangiu left a comment

acatangiu Apr 23, 2024

serban300 left a comment

bkontur Apr 23, 2024

svyatonik Apr 23, 2024

bkontur Apr 23, 2024

paritytech-cicd-pr commented Apr 23, 2024

svyatonik commented May 8, 2024

Bridge: make some headers submissions free #4102

Bridge: make some headers submissions free #4102

Conversation

svyatonik commented Apr 12, 2024 • edited Loading

acatangiu left a comment

Choose a reason for hiding this comment

acatangiu Apr 23, 2024

Choose a reason for hiding this comment

serban300 left a comment

Choose a reason for hiding this comment

bkontur Apr 23, 2024

Choose a reason for hiding this comment

svyatonik Apr 23, 2024

Choose a reason for hiding this comment

bkontur Apr 23, 2024

Choose a reason for hiding this comment

paritytech-cicd-pr commented Apr 23, 2024

svyatonik commented May 8, 2024

svyatonik commented Apr 12, 2024 •

edited

Loading