[bridges-v2] Permissionless lanes #4949

bkontur · 2024-07-04T22:34:48Z

Relates to: paritytech/parity-bridges-common#2451
Closes: paritytech/parity-bridges-common#2500

Summary

Now, the bridging pallet supports only static lanes, which means lanes that are hard-coded in the runtime files. This PR fixes that and adds support for dynamic, also known as permissionless, lanes. This means that allowed origins (relay chain, sibling parachains) can open and close bridges (through BridgeHubs) with another bridged (substrate-like) consensus using just xcm::Transact and OriginKind::Xcm.

This PR is based on the migrated code from the Bridges V2 branch from the old parity-bridges-common repo.

Explanation

Please read bridges/modules/xcm-bridge-hub/src/lib.rs to understand how managing bridges works. The basic concepts around BridgeId and LaneId are also explained there.

TODO

search and fix for comment: // TODO:(bridges-v2) - most of that stuff was introduced with free header execution: https://github.com/paritytech/polkadot-sdk/pull/4102 - more info in the comment bellow
TODO: there's only one impl of EnsureOrigin<Success = Location>

TODO - not blocking review

benchmarking:

regenerate all relevant weights for BH/AH runtimes
regenerate default weights for bridging pallets e.g. modules/messages/src/weights.rs
add benchmarks for xcm-bridge-hub pallet Add benchmarks for pallet-xcm-bridge-hub #5550

testing:

add xcm-emulator tests for Rococo/Penpal to Westend/Penpal with full opening channel and sending/receiving xcm::Transact

migrations:

add migrations for BridgeHubRococo/Westend [migrations] Migration from static Lanes to dynamic lanes (master) parity-bridges-common#2794 (to be reusable for P/K bridge)
- check also storage migration, if needed for pallets
- migration for XCM type (optional)
- migration for static lanes to the dynamic (reuse for fellows)

investigation:

revisit Revisit usage of BridgeTable, NetworkExportTable in the xcm-bridge-router configuration parity-bridges-common#2380
check congestion around LocalXcmChannelManager and OutboundLanesCongestedSignals impls - Add LocalXcmChannelManager impls for XcmpQueue and BridgeHubs #5551
- to be reusable for polkadot-fellows
- return report_bridge_status was remove, so we need to XcmpQueue alternative?

bkontur · 2024-07-30T12:50:11Z

bot help

Original PR with more context: paritytech/parity-bridges-common#2211 Signed-off-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>

…=bridge-hub-westend --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_messages

…=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_messages

* add LaneState enum and a field to lanes data * use OptionQuery in InboundLanes and OutboundLanes * ensure that lanes are opened when accessing them * an option to specify opened lanes in genesis config + fixed tests * added PR reference to TODO * fix failing benchmarks * spelling * get_or_init_data -> data bump Substrate, Polkadot and Cumulus (#2223)

* change LaneId underlying type from [u8; 4] to H256 * fixed typo * added some tests * spelling * started fixing testnets * uncommented call size test * changed RewardsAccountParams encoding + added values separator when computing LaneId * review suggestions

* some useful stuff like LanesManager * clippy * more clippy * Error::LanesManager * {in, out}bound_lane -> active_{in, out}bound_lane * merge two impl blocks in one * fmt

* Updated version according to Cumulus * Updated docs

* allow delivery confirmations on closed outbound lanes * fix benchmarks compilation

…nsactions (#2259)

)

* XCM over bridge pallet (won't ever be merged to this repo): initial commit * try both bridge-id and lane-id * flush * flush * flush * flush * first prototype * started working on xcm-over-bridge tests * proper open_bridge_works test * more open_bridge tests * request_bridge_closure tests * tests for close_bridge * report_misbehavior tests * renaming xcm-over-bridge ad xcm-bridge-hub: we'll have two similar pallets for dynamic lanes/fees support. One will be deployed at the bridge hub (xcm-bridge-hub) and another one (xcm-bridge-hub-router) at sibling/parent chains to send messages to remote network over the bridge hub * added couple of TODOs * moved BridgeQueuesState here + TODO for implementing report_bridge_queues_state + fmt * fixing TODOs * fixing TODOs * moved bridge locations to primitives * added a couple of TODOs * ref issue from TODO * clippy and spelling * fix tests * another TODOs * typo * LaneState -> force_close_bridge * start_closing_the_bridge -> start_closing_bridge * removed Closing bridge state, so now we only have the Opened -> optional temporary Closed state -> None * spelling * started prototyping suspend+resume on misbehavior * continue prototyping * more tests for open_bridge * more tests for close_bridge * more tests for report_misbehavior * started tests for resume_misbehaving_bridges * implemented tests for resume_misbehaving_bridges * remove UnsuspendedChannelWithMisbehavingOwner because now, when all bridges are resumed at once + we assume that the inbound XCM channel is suspended immediately it is no longer actual * added TODO * add comment re misbehavior reporter if he's associated with the bridge owner * ignored clippy * fmt * use versioned XCM structs in public interfaces and storage + Box XCM locations where possible * spelling * removed TODO in favor of paritytech/parity-bridges-common#2257 * LocalChannelManager -> LocalXcmChannelManager * removed code specific to #2233, because it isn't the only option now * removemisbehavior mentions * also temporary (?) remove BridgesByLocalOrigin because the storage format will likely change to be able to resume bridges from the on_iniitalize/on_idle * AllowedOpenBridgeOrigin -> OpenBridgeOrigin * - TooManyBridgesForLocalOrigin * use bridge_destination_relative_location in args * better impl of strip_low_level_junctions * get rid of xcm_into_latest * clippy * added #![warn(missing_docs)] to new crates

) * implement ExportXcm and MessageDispatch for pallet-xcm-bridge-hub * spelling

… pallet-xcm-bridge-hub (#2261) Xcm bridge hub router v2 (backport to master branch) (#2312) * copy new pallet (palle-xcm-bridge-hub-router) from dynamic-fees-v1 branch * added remaining traces of pallet-xcm-bridge-hub-router * added comment about sharing delivery fee factor between all bridges, opened by this chain * spelling * clippy Implement additional require primitives for dynamic fees directly for pallet-xcm-bridge-hub (#2261) * added backoff mechanism to inbound bridge queue * impl backpressure in the XcmBlobHaulerAdapter * leave TODOs * BridgeMessageProcessor prototype * another TODO * Revert "also temporary (?) remove BridgesByLocalOrigin because the storage format will likely change to be able to resume bridges from the on_iniitalize/on_idle" This reverts commit bdd7ae11a8942b58c5db6ac6d4e7922aa28cece4. * prototype for QueuePausedQuery * implement ExportXcm and MessageDispatch for pallet-xcm-bridge-hub * spelling * flush * small comments to myself * more backports from dynamic-fees-v1 * use new pallet as exporter and dispatcher in Millau * use new pallet as exporter and dispatcher in Rialto * use new pallet as exporter and dispatcher in RialtoParachain * flush * fix remaining compilation issues * warnings + fmt * fix tests * LocalXcmChannelManager * change lane ids * it works! * remove bp-xcm-bridge-hub-router and use LocalXcmChannelManager everywhere * removed commented code * cleaning up * cleaning up * cleaning up * - separated BridgeId and LaneId - BridgeId now uses versioned universal locations - added missing stuff to exporter.rs * OnMessagesDelivered is back * start using bp-xcm-bridge-hub as OnMessagesDelivered * cleaning up * spelling * fix stupid issues * Backport latest relevant dynamic fees changes from v1 to v2 (#2372) * backport latest relevant dynamic fees changes from v1 to v2 * fix comment Added remaining unit tests for pallet-xcm-bridge-hub (#2499) * added backoff mechanism to inbound bridge queue * impl backpressure in the XcmBlobHaulerAdapter * leave TODOs * BridgeMessageProcessor prototype * another TODO * Revert "also temporary (?) remove BridgesByLocalOrigin because the storage format will likely change to be able to resume bridges from the on_iniitalize/on_idle" This reverts commit bdd7ae11a8942b58c5db6ac6d4e7922aa28cece4. * prototype for QueuePausedQuery * implement ExportXcm and MessageDispatch for pallet-xcm-bridge-hub * spelling * flush * small comments to myself * more backports from dynamic-fees-v1 * use new pallet as exporter and dispatcher in Millau * use new pallet as exporter and dispatcher in Rialto * use new pallet as exporter and dispatcher in RialtoParachain * flush * fix remaining compilation issues * warnings + fmt * fix tests * LocalXcmChannelManager * change lane ids * it works! * remove bp-xcm-bridge-hub-router and use LocalXcmChannelManager everywhere * removed commented code * cleaning up * cleaning up * cleaning up * - separated BridgeId and LaneId - BridgeId now uses versioned universal locations - added missing stuff to exporter.rs * OnMessagesDelivered is back * start using bp-xcm-bridge-hub as OnMessagesDelivered * cleaning up * spelling * fix stupid issues * added remaining unit tests for pallet-xcm-bridge-hub fixed benchmarks (#2504) Remove pallet_xcm_bridge_hub::SuspendedBridges (#2505) * remove pallet_xcm_bridge_hub::SuspendedBridges * apply review suggestions

cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/bridge_to_bulletin_config.rs

…://github.com/paritytech/parity-bridges-common/issues/3047

…issionless-lanes

acatangiu · 2024-09-02T15:28:27Z

bridges/modules/messages/README.md

+In our [Kusama<>Polkadot bridge](../../docs/polkadot-kusama-bridge-overview.md) we are using lane
+as a channel of communication between two parachains of different relay chains. For example, lane
+`[0, 0, 0, 0]` is used for Polkadot <> Kusama Asset Hub communications. Other lanes may be used to
+bridge other parachains.


You should add updated documentation here - how are lanes opened and used.

Relates to: paritytech/parity-bridges-common#2451 Closes: paritytech/parity-bridges-common#2500 ## Summary Now, the bridging pallet supports only static lanes, which means lanes that are hard-coded in the runtime files. This PR fixes that and adds support for dynamic, also known as permissionless, lanes. This means that allowed origins (relay chain, sibling parachains) can open and close bridges (through BridgeHubs) with another bridged (substrate-like) consensus using just `xcm::Transact` and `OriginKind::Xcm`. _This PR is based on the migrated code from the Bridges V2 [branch](#4427) from the old `parity-bridges-common` [repo](https://github.com/paritytech/parity-bridges-common/tree/bridges-v2)._ ## Explanation Please read [bridges/modules/xcm-bridge-hub/src/lib.rs](https://github.com/paritytech/polkadot-sdk/blob/149b0ac2ce43fba197988f2642032fa24dd8289a/bridges/modules/xcm-bridge-hub/src/lib.rs#L17-L136) to understand how managing bridges works. The basic concepts around `BridgeId` and `LaneId` are also explained there. ## TODO - [x] search and fix for comment: `// TODO:(bridges-v2) - most of that stuff was introduced with free header execution: https://github.com/paritytech/polkadot-sdk/pull/4102` - more info in the comment [bellow](#4427 (comment)) - [x] TODO: there's only one impl of `EnsureOrigin<Success = Location>` ## TODO - not blocking review **benchmarking:** - [x] regenerate all relevant weights for BH/AH runtimes - [ ] regenerate default weights for bridging pallets e.g. `modules/messages/src/weights.rs` - [ ] add benchmarks for `xcm-bridge-hub` pallet #5550 **testing:** - [ ] add xcm-emulator tests for Rococo/Penpal to Westend/Penpal with full opening channel and sending/receiving `xcm::Transact` **migrations:** - [x] add migrations for BridgeHubRococo/Westend paritytech/parity-bridges-common#2794 (to be reusable for P/K bridge) - [x] check also storage migration, if needed for pallets - [ ] migration for XCM type (optional) - [x] migration for static lanes to the dynamic (reuse for fellows) **investigation:** - [ ] revisit paritytech/parity-bridges-common#2380 - [ ] check congestion around `LocalXcmChannelManager` and `OutboundLanesCongestedSignals` impls - #5551 - to be reusable for polkadot-fellows - return `report_bridge_status` was remove, so we need to `XcmpQueue` alternative? --------- Signed-off-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com> Co-authored-by: command-bot <> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>

acatangiu · 2024-09-05T15:20:35Z

FYI: @lurpis @hqwangningbo there's a public Polkadot-SDK Release Calendar you can now use. The individual releases boards (e.g. Stable2409 LTS Release) will also be populated with the PRs part of said releases.

lurpis · 2024-09-06T06:28:05Z

@acatangiu

IIUC correctly, what you want is custom bridged token handling: have dedicated bridge lane between Bifrost-Kusama and Bifrost-Polkadot so you can directly transfer PolkadotBNC and KusamaBNC between the two (without going through Asset Hubs), and have custom logic on your parachains to treat the two assets as one single/global BNC asset.

Yes, we completed the logic here in August and passed on the testnet. What we are waiting for now is the restriction to be lifted.

acatangiu · 2024-09-25T15:08:48Z

Yes, we completed the logic here in August and passed on the testnet. What we are waiting for now is the restriction to be lifted.

@lurpis @hqwangningbo can you set up a Telegram group chat or Matrix group chat to discuss your plan and needs in detail?

I want to make sure we're not missing anything and not delaying things more.

my Telegram: @adriankata
my Matrix: @adrian:parity.io

hqwangningbo · 2024-09-25T16:32:54Z

@acatangiu I have invited you to the Parity-Bifrost Telegram group and hope to have further communication.

…polkadot-sdk#4488] (SDK #4935)[paritytech/polkadot-sdk#4935] (SDK #4949)[paritytech/polkadot-sdk#4949] (SDK #5649)[paritytech/polkadot-sdk#5649] - Configure Polkadot Asset Hub - Configure Bridge Hubs

Closes: #5551 ## Description With [permissionless lanes PR#4949](#4949), the congestion mechanism based on sending `Transact(report_bridge_status(is_congested))` from `pallet-xcm-bridge-hub` to `pallet-xcm-bridge-hub-router` was replaced with a congestion mechanism that relied on monitoring XCMP queues. However, this approach could cause issues, such as suspending the entire XCMP queue instead of isolating the affected bridge. This PR reverts back to using `report_bridge_status` as before. ## TODO - [x] benchmarks - [x] prdoc ## Follow-up #6231 --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: command-bot <> Co-authored-by: Adrian Catangiu <adrian@parity.io>

Closes: #5551 ## Description With [permissionless lanes PR#4949](#4949), the congestion mechanism based on sending `Transact(report_bridge_status(is_congested))` from `pallet-xcm-bridge-hub` to `pallet-xcm-bridge-hub-router` was replaced with a congestion mechanism that relied on monitoring XCMP queues. However, this approach could cause issues, such as suspending the entire XCMP queue instead of isolating the affected bridge. This PR reverts back to using `report_bridge_status` as before. ## TODO - [x] benchmarks - [x] prdoc ## Follow-up #6231 --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: command-bot <> Co-authored-by: Adrian Catangiu <adrian@parity.io> (cherry picked from commit 8f4b99c) # Conflicts: # Cargo.lock # cumulus/parachains/runtimes/assets/asset-hub-rococo/tests/tests.rs # cumulus/parachains/runtimes/assets/asset-hub-westend/src/lib.rs

Closes: #5551 ## Description With [permissionless lanes PR#4949](#4949), the congestion mechanism based on sending `Transact(report_bridge_status(is_congested))` from `pallet-xcm-bridge-hub` to `pallet-xcm-bridge-hub-router` was replaced with a congestion mechanism that relied on monitoring XCMP queues. However, this approach could cause issues, such as suspending the entire XCMP queue instead of isolating the affected bridge. This PR reverts back to using `report_bridge_status` as before. ## TODO - [x] benchmarks - [x] prdoc ## Follow-up #6231 --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: command-bot <> Co-authored-by: Adrian Catangiu <adrian@parity.io>

bkontur added the T15-bridges This PR/Issue is related to bridges. label Jul 4, 2024

bkontur self-assigned this Jul 4, 2024

Base automatically changed from bko-bridges-v2-backport-pruning to bko-bridges-v2-backport-refactoring July 10, 2024 10:13

Base automatically changed from bko-bridges-v2-backport-refactoring to master July 12, 2024 08:48

bkontur force-pushed the bko-bridges-v2-permissionless-lanes branch from 2119b50 to c00298e Compare July 16, 2024 08:45

bkontur mentioned this pull request Jul 16, 2024

[V2 Bridges] Dynamic way of adding permissionless lanes (bridges between parachains) paritytech/parity-bridges-common#2451

Open

6 tasks

bkontur force-pushed the bko-bridges-v2-permissionless-lanes branch from cc9e609 to 2ddf5f2 Compare July 17, 2024 15:36

acatangiu mentioned this pull request Jul 18, 2024

Revisit usage of BridgeTable, NetworkExportTable in the xcm-bridge-router configuration paritytech/parity-bridges-common#2380

Closed

bkontur force-pushed the bko-bridges-v2-permissionless-lanes branch 4 times, most recently from c7a254f to 2431b1a Compare July 29, 2024 15:00

bkontur force-pushed the bko-bridges-v2-permissionless-lanes branch from 021ddda to 648498b Compare July 30, 2024 22:41

bkontur and others added 16 commits July 31, 2024 13:23

CI fixes

1a76f1c

prune messages from confirmation tx, not from the on_idle (#2211)

712a690

Original PR with more context: paritytech/parity-bridges-common#2211 Signed-off-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>

Added do_try_state_for_outbound_lanes which checks unpruned messages

1251505

".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

0feaa40

…=bridge-hub-westend --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_messages

".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

4cbe637

…=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_messages

Introduce MessagesLaneManager (#2227)

4f0dc6a

* some useful stuff like LanesManager * clippy * more clippy * Error::LanesManager * {in, out}bound_lane -> active_{in, out}bound_lane * merge two impl blocks in one * fmt

Backport from staging (#2243)

0ba297e

* Updated version according to Cumulus * Updated docs

Allow delivery confirmations on closed outbound lanes (#2257)

963382e

* allow delivery confirmations on closed outbound lanes * fix benchmarks compilation

remove internal code that pretends to support cross-lane delivery tra…

1b372c1

…nsactions (#2259)

introduce partial bp-xcm-bridge-hub - just LocalXcmChannelManager (#2265

71ee52b

)

Implement ExportXcm and MessageDispatch for pallet-xcm-bridge-hub (#2285

23c04f3

) * implement ExportXcm and MessageDispatch for pallet-xcm-bridge-hub * spelling

emit events from bridge hub router (#2760)

0b481d8

acatangiu reviewed Sep 2, 2024

View reviewed changes

cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/bridge_to_bulletin_config.rs Outdated Show resolved Hide resolved

Removed FAIL-CI for unused BridgeHubOrigin

01344b8

bkontur mentioned this pull request Sep 2, 2024

Add benchmarks for pallet-xcm-bridge-hub #5550

Open

bkontur added 5 commits September 2, 2024 16:31

Removed FAIL-CI for missing benchmarks and replaced with github issue

cf5bc06

Removed FAIL-CI for congestion and replaced with github issue https…

935e87a

…://github.com/paritytech/parity-bridges-common/issues/3047

Only PeopleRococo can manage channel to the bulletin

513aa6a

Merge remote-tracking branch 'origin/master' into bko-bridges-v2-perm…

4929d4e

…issionless-lanes

prdoc fixes

a0837d9

acatangiu mentioned this pull request Sep 2, 2024

Bridge Permissionless Lanes - more tests #5552

Open

4 tasks

acatangiu reviewed Sep 2, 2024

View reviewed changes

bkontur enabled auto-merge September 2, 2024 15:43

bkontur added this pull request to the merge queue Sep 2, 2024

Merged via the queue into master with commit 2210099 Sep 2, 2024
182 of 189 checks passed

bkontur deleted the bko-bridges-v2-permissionless-lanes branch September 2, 2024 16:27

ggwpez mentioned this pull request Sep 9, 2024

Parent issue for stable2409 LTS release #5583

Closed

github-actions bot mentioned this pull request Oct 8, 2024

Update polkadot-sdk from stable2407 to stable2409 moonbeam-foundation/moonbeam#2994

Closed

acatangiu mentioned this pull request Oct 14, 2024

[Bridges SDK] Permissionless dedicated bridge lanes #6044

Closed

7 tasks

bkontur mentioned this pull request Nov 11, 2024

Bridges - Add improved congestion control mechanism #6231

Open

github-actions bot mentioned this pull request Dec 5, 2024

Update polkadot-sdk from stable2407 to stable2409-2 moonbeam-foundation/moonbeam#3075

Open

bkontur mentioned this pull request Dec 7, 2024

Bridges - revert-back congestion mechanism #6781

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[bridges-v2] Permissionless lanes #4949

[bridges-v2] Permissionless lanes #4949

bkontur commented Jul 4, 2024 •

edited

Loading

bkontur commented Jul 30, 2024

acatangiu Sep 2, 2024

acatangiu commented Sep 5, 2024

lurpis commented Sep 6, 2024

acatangiu commented Sep 25, 2024

hqwangningbo commented Sep 25, 2024

[bridges-v2] Permissionless lanes #4949

[bridges-v2] Permissionless lanes #4949

Conversation

bkontur commented Jul 4, 2024 • edited Loading

Summary

Explanation

TODO

TODO - not blocking review

bkontur commented Jul 30, 2024

acatangiu Sep 2, 2024

Choose a reason for hiding this comment

acatangiu commented Sep 5, 2024

lurpis commented Sep 6, 2024

acatangiu commented Sep 25, 2024

hqwangningbo commented Sep 25, 2024

bkontur commented Jul 4, 2024 •

edited

Loading