-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bridges lane id agnostic for backwards compatibility #5649
Conversation
72db319
to
adf682e
Compare
9b9c36a
to
c0c2d54
Compare
c0c2d54
to
8f2ae83
Compare
fdd9948
to
d5dc6f4
Compare
Introduce LegacyLaneId
d5dc6f4
to
bebaba1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as far as I can understand. I just left a couple of comments, mostly very small.
I hope I didn't miss anything. But please, in the future let's avoid this kind of big PRs since they are very hard to review. Let's try to split them. For this one in particular I would have had at least 2-3 PRs:
- the LaneID changes
- instantiating the Relayer rewards pallet
- any other changes
And in each PR I would split the important changes from the non-important verbose ones (renamings, adding a generic parameter, etc)
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-5649-to-stable2407
git worktree add --checkout .worktree/backport-5649-to-stable2407 backport-5649-to-stable2407
cd .worktree/backport-5649-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 710e74ddefdff1e36b77ba65abe54feb0ac15040
git push --force-with-lease |
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-5649-to-stable2409
git worktree add --checkout .worktree/backport-5649-to-stable2409 backport-5649-to-stable2409
cd .worktree/backport-5649-to-stable2409
git reset --hard HEAD^
git cherry-pick -x 710e74ddefdff1e36b77ba65abe54feb0ac15040
git push --force-with-lease |
This PR primarily fixes the issue with `zombienet-bridges-0001-asset-transfer-works` (see: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7404903). The PR looks large, but most of the changes involve splitting `LaneId` into `LegacyLaneId` and `HashedLaneId`. All pallets now use `LaneId` as a generic parameter. The actual bridging pallets are now backward compatible and work with actual **substrate-relay v1.6.10**, which does not even known anything about permissionless lanes or the new pallet changes. - [x] added migration for `pallet_bridge_relayers` and `RewardsAccountParams` change order of params, which generates different accounts - [ ] fix monitoring for `at_{}_relay_{}_reward_for_msgs_from_{}_on_lane_{}` - [ ] check sovereign reward accounts - because of changed `RewardsAccountParams` - [ ] deploy another messages instances for permissionless lanes - on BHs or AHs? - [ ] return back `open_and_close_bridge_works` for another `pallet-bridge-messages` instance --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> (cherry picked from commit 710e74d)
Backport #5649 into `stable2409` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>
…polkadot-sdk#4488] (SDK #4935)[paritytech/polkadot-sdk#4935] (SDK #4949)[paritytech/polkadot-sdk#4949] (SDK #5649)[paritytech/polkadot-sdk#5649] - Configure Polkadot Asset Hub - Configure Bridge Hubs
This PR primarily fixes the issue with
zombienet-bridges-0001-asset-transfer-works
(see: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7404903).The PR looks large, but most of the changes involve splitting
LaneId
intoLegacyLaneId
andHashedLaneId
. All pallets now useLaneId
as a generic parameter.The actual bridging pallets are now backward compatible and work with actual substrate-relay v1.6.10, which does not even known anything about permissionless lanes or the new pallet changes.
Important
pallet_bridge_relayers
andRewardsAccountParams
change order of params, which generates different accountsDeployment follow ups
at_{}_relay_{}_reward_for_msgs_from_{}_on_lane_{}
RewardsAccountParams
open_and_close_bridge_works
for anotherpallet-bridge-messages
instance