deps: update jsonrpsee to v0.22.5 #4330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use `server-core` feature instead of `server` feature when defining the rpc api
jasl
reviewed
Apr 30, 2024
| @@ -16,7 +16,7 @@ workspace = true | |||
| targets = ["x86_64-unknown-linux-gnu"] | |||
|
|
|||
| [dependencies] | |||
| jsonrpsee = { version = "0.22", features = ["client-core", "macros", "server"] } | |||
| jsonrpsee = { version = "0.22", features = ["client-core", "server-core", "macros"] } | |||
There was a problem hiding this comment.
If the server-core feature fails to compile before 0.22.5, maybe you need to point the version to 0.22.5.
There was a problem hiding this comment.
Yeah, for downstream users, it's neceessary
|
Cool, it should be transparency for downstream but reduce several dependencies |
skunert
added
R0-silent
|
In general LGTM, just curious why this needs 22.5? Could not find anything in the jsonrpsee changelogs that seems relevant. |
relevant PRs: |
bkchr
approved these changes
May 2, 2024
skunert
approved these changes
May 2, 2024
Merged
via the queue into
paritytech:master
with commit May 2, 2024
4e0b3ab
144 of 147 checks passed
dcolley
added a commit
to metaspan/polkadot-sdk
that referenced
this pull request
May 6, 2024
* 'master' of https://github.com/metaspan/polkadot-sdk: (65 commits) Introduces `TypeWithDefault<T, D: Get<T>>` (paritytech#4034) Publish `polkadot-sdk-frame` crate (paritytech#4370) Add validate field to prdoc (paritytech#4368) State trie migration on asset-hub westend and collectives westend (paritytech#4185) Fix: dust unbonded for zero existential deposit (paritytech#4364) Bridge: added subcommand to relay single parachain header (paritytech#4365) Bridge: fix zombienet tests (paritytech#4367) [WIP][CI] Add more GHA jobs (paritytech#4270) Allow for 0 existential deposit in benchmarks for `pallet_staking`, `pallet_session`, and `pallet_balances` (paritytech#4346) Deprecate `NativeElseWasmExecutor` (paritytech#4329) More `xcm::v4` cleanup and `xcm_fee_payment_runtime_api::XcmPaymentApi` nits (paritytech#4355) sc-tracing: enable env-filter feature (paritytech#4357) deps: update jsonrpsee to v0.22.5 (paritytech#4330) Add PoV-reclaim enablement guide to polkadot-sdk-docs (paritytech#4244) cargo: Update experimental litep2p to latest version (paritytech#4344) Bridge: ignore client errors when calling recently added `*_free_headers_interval` methods (paritytech#4350) Make parachain template great again (and async backing ready) (paritytech#4295) [Backport] Version bumps and reorg prdocs from 1.11.0 (paritytech#4336) HRMP - set `DefaultChannelSizeAndCapacityWithSystem` with dynamic values according to the `ActiveConfig` (paritytech#4332) Statement Distribution Per Peer Rate Limit (paritytech#3444) ...
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
use `server-core` feature instead of `server` feature when defining the rpc api
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
server-corefeature instead ofserverfeature when defining the rpc api