Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo: Update experimental litep2p to latest version #4344

Merged
merged 4 commits into from
May 2, 2024
Merged

cargo: Update experimental litep2p to latest version #4344

merged 4 commits into from
May 2, 2024

Conversation

lexnv
Copy link
Contributor

@lexnv lexnv commented May 1, 2024

This PR updates the litep2p crate to the latest version.

This fixes the build for developers that want to perform cargo update on all their dependencies: #4343, by porting the latest changes.

The peer records were introduced to litep2p to be able to distinguish and update peers with outdated records.
It is going to be properly used in substrate via: #3786, however that is pending the commit to merge on litep2p master: paritytech/litep2p#96.

Closes: #4343

lexnv added 2 commits May 1, 2024 15:58
@lexnv
cargo: Update litep2p to origin/master
4305237 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
litep2p/discovery: Ignore the peer that provided the record
09694a4 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv added A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). R0-silent Changes should not be mentioned in any release notes I5-enhancement An additional feature request. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. labels May 1, 2024
@lexnv lexnv self-assigned this May 1, 2024
alexggh
alexggh reviewed May 1, 2024
View reviewed changes
Cargo.lock
@@ -1358,7 +1358,7 @@ dependencies = [
"rand_chacha 0.3.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably go with the approach from here: #4343 and pin the litep2p to a tag or sha, to avoid this type of breakage in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, forgot about it when I named the branch pin-litep2p-commit 🙈 Thanks!

@lexnv lexnv mentioned this pull request May 1, 2024
Closed
lexnv added 2 commits May 1, 2024 16:25
@lexnv
chore: Pin litep2p commit hash
211bf0d 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
cargo: Apply taplo format
95d33cb 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv added this pull request to the merge queue May 2, 2024
Merged via the queue into master with commit 877617c May 2, 2024
141 of 142 checks passed
@lexnv lexnv deleted the lexnv/pin-litep2p-commit branch May 2, 2024 11:23
dcolley added a commit to metaspan/polkadot-sdk that referenced this pull request May 6, 2024
@dcolley
Merge branch 'master' of https://github.com/metaspan/polkadot-sdk
5db2d43 
* 'master' of https://github.com/metaspan/polkadot-sdk: (65 commits)
  Introduces `TypeWithDefault<T, D: Get<T>>` (paritytech#4034)
  Publish `polkadot-sdk-frame`  crate (paritytech#4370)
  Add validate field to prdoc (paritytech#4368)
  State trie migration on asset-hub westend and collectives westend (paritytech#4185)
  Fix: dust unbonded for zero existential deposit (paritytech#4364)
  Bridge: added subcommand to relay single parachain header (paritytech#4365)
  Bridge: fix zombienet tests (paritytech#4367)
  [WIP][CI] Add more GHA jobs (paritytech#4270)
  Allow for 0 existential deposit in benchmarks for `pallet_staking`, `pallet_session`, and `pallet_balances` (paritytech#4346)
  Deprecate `NativeElseWasmExecutor` (paritytech#4329)
  More `xcm::v4` cleanup and `xcm_fee_payment_runtime_api::XcmPaymentApi` nits (paritytech#4355)
  sc-tracing: enable env-filter feature (paritytech#4357)
  deps: update jsonrpsee to v0.22.5 (paritytech#4330)
  Add PoV-reclaim enablement guide to polkadot-sdk-docs (paritytech#4244)
  cargo: Update experimental litep2p to latest version (paritytech#4344)
  Bridge: ignore client errors when calling recently added `*_free_headers_interval` methods (paritytech#4350)
  Make parachain template great again (and async backing ready) (paritytech#4295)
  [Backport] Version bumps and reorg prdocs from 1.11.0 (paritytech#4336)
  HRMP - set `DefaultChannelSizeAndCapacityWithSystem` with dynamic values according to the `ActiveConfig` (paritytech#4332)
  Statement Distribution Per Peer Rate Limit (paritytech#3444)
  ...
@koushiro
Copy link
Contributor

koushiro commented May 8, 2024

@lexnv could you cherry-pick this PR to release-polkadot-v1.11.0 branch

jmg-duarte pushed a commit to eigerco/polkadot-sdk that referenced this pull request May 8, 2024
@lexnv @jmg-duarte
cargo: Update experimental litep2p to latest version (paritytech#4344)
cb4554c 
This PR updates the litep2p crate to the latest version.

This fixes the build for developers that want to perform `cargo update`
on all their dependencies:
paritytech#4343, by porting the
latest changes.

The peer records were introduced to litep2p to be able to distinguish
and update peers with outdated records.
It is going to be properly used in substrate via:
paritytech#3786, however that is
pending the commit to merge on litep2p master:
paritytech/litep2p#96.

Closes: paritytech#4343

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request May 10, 2024
@lexnv @bgallois
cargo: Update experimental litep2p to latest version (paritytech#4344)
030a7b8 
This PR updates the litep2p crate to the latest version.

This fixes the build for developers that want to perform `cargo update`
on all their dependencies:
paritytech#4343, by porting the
latest changes.

The peer records were introduced to litep2p to be able to distinguish
and update peers with outdated records.
It is going to be properly used in substrate via:
paritytech#3786, however that is
pending the commit to merge on litep2p master:
paritytech/litep2p#96.

Closes: paritytech#4343

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
koushiro pushed a commit to koushiro-contrib/polkadot-sdk that referenced this pull request May 11, 2024
@lexnv @koushiro
cargo: Update experimental litep2p to latest version (paritytech#4344)
ef8c4b3 
This PR updates the litep2p crate to the latest version.

This fixes the build for developers that want to perform `cargo update`
on all their dependencies:
paritytech#4343, by porting the
latest changes.

The peer records were introduced to litep2p to be able to distinguish
and update peers with outdated records.
It is going to be properly used in substrate via:
paritytech#3786, however that is
pending the commit to merge on litep2p master:
paritytech/litep2p#96.

Closes: paritytech#4343

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@jmg-duarte
Copy link

@koushiro if you're depending on v0.11.0 you can patch litep2p to version 0.3.0, like so

[patch.'https://github.com/paritytech/litep2p']
litep2p = "0.3.0"

It was the one used to build the SDK's v0.11.0, as you can see in the corresponding Cargo.lock

polkadot-sdk/Cargo.lock

Lines 8187 to 8190 in 0bb6249

[[package]]
name = "litep2p"
version = "0.3.0"
source = "git+https://github.com/paritytech/litep2p?branch=master#b142c9eb611fb2fe78d2830266a3675b37299ceb"

TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@lexnv @TarekkMA
cargo: Update experimental litep2p to latest version (paritytech#4344)
3484749 
This PR updates the litep2p crate to the latest version.

This fixes the build for developers that want to perform `cargo update`
on all their dependencies:
paritytech#4343, by porting the
latest changes.

The peer records were introduced to litep2p to be able to distinguish
and update peers with outdated records.
It is going to be properly used in substrate via:
paritytech#3786, however that is
pending the commit to merge on litep2p master:
paritytech/litep2p#96.

Closes: paritytech#4343

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexggh alexggh alexggh approved these changes

@davxy davxy davxy approved these changes

@skunert skunert skunert approved these changes

@dmitry-markin dmitry-markin Awaiting requested review from dmitry-markin

Assignees

@lexnv lexnv

Labels
A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I5-enhancement An additional feature request. R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lexnv @koushiro @jmg-duarte @skunert @davxy @alexggh