Remove workspace lints from templates

.github/workflows/misc-sync-templates.yml

@@ -105,8 +105,6 @@ jobs:
  toml set templates/${{ matrix.template }}/Cargo.toml 'workspace.package.edition' "$(toml get --raw Cargo.toml 'workspace.package.edition')" > Cargo.temp
  mv Cargo.temp ./templates/${{ matrix.template }}/Cargo.toml
 
- toml get Cargo.toml 'workspace.lints' --output-toml >> ./templates/${{ matrix.template }}/Cargo.toml
-
  toml get Cargo.toml 'workspace.dependencies' --output-toml >> ./templates/${{ matrix.template }}/Cargo.toml
  working-directory: polkadot-sdk
  - name: Print the result Cargo.tomls for debugging

templates/minimal/Cargo.toml

@@ -9,9 +9,6 @@ repository.workspace = true
 edition.workspace = true
 publish = false
 
-[lints]
-workspace = true
-
 [dependencies]
 minimal-template-node = { path = "./node" }
 minimal-template-runtime = { path = "./runtime" }

templates/minimal/node/Cargo.toml

@@ -10,9 +10,6 @@ edition.workspace = true
 publish = false
 build = "build.rs"
 
-[lints]
-workspace = true
-
 [package.metadata.docs.rs]
 targets = ["x86_64-unknown-linux-gnu"]
 

templates/minimal/node/src/cli.rs

@@ -32,7 +32,7 @@ impl std::str::FromStr for Consensus {
  } else if let Some(block_time) = s.strip_prefix("manual-seal-") {
  Consensus::ManualSeal(block_time.parse().map_err(|_| "invalid block time")?)
  } else {
- return Err("incorrect consensus identifier".into())
+ return Err("incorrect consensus identifier".into());
  })
  }
 }

templates/minimal/node/src/service.rs

@@ -61,7 +61,7 @@ pub fn new_partial(config: &Configuration) -> Result<Service, ServiceError> {
  })
  .transpose()?;
 
- let executor = sc_service::new_wasm_executor(&config);
+ let executor = sc_service::new_wasm_executor(config);
 
  let (client, backend, keystore_container, task_manager) =
  sc_service::new_full_parts::<Block, RuntimeApi, _>(

templates/minimal/pallets/template/Cargo.toml

@@ -9,9 +9,6 @@ repository.workspace = true
 edition.workspace = true
 publish = false
 
-[lints]
-workspace = true
-
 [package.metadata.docs.rs]
 targets = ["x86_64-unknown-linux-gnu"]
 

templates/minimal/runtime/Cargo.toml

@@ -9,9 +9,6 @@ repository.workspace = true
 edition.workspace = true
 publish = false
 
-[lints]
-workspace = true
-
 [dependencies]
 parity-scale-codec = { version = "3.6.12", default-features = false }
 scale-info = { version = "2.6.0", default-features = false }

templates/parachain/node/Cargo.toml

@@ -10,9 +10,6 @@ edition.workspace = true
 publish = false
 build = "build.rs"
 
-[lints]
-workspace = true
-
 # [[bin]]
 # name = "parachain-template-node"
 

templates/parachain/node/src/cli.rs

@@ -1,6 +1,7 @@
 use std::path::PathBuf;
 
 /// Sub-commands supported by the collator.
+#[allow(clippy::large_enum_variant)]
 #[derive(Debug, clap::Subcommand)]
 pub enum Subcommand {
  /// Build a chain specification.

templates/parachain/node/src/command.rs

@@ -194,13 +194,11 @@ pub fn run() -> Result<()> {
  cmd.run(partials.client)
  }),
  #[cfg(not(feature = "runtime-benchmarks"))]
- BenchmarkCmd::Storage(_) =>
- return Err(sc_cli::Error::Input(
- "Compile with --features=runtime-benchmarks \
+ BenchmarkCmd::Storage(_) => Err(sc_cli::Error::Input(
+ "Compile with --features=runtime-benchmarks \
  to enable storage benchmarks."
- .into(),
- )
- .into()),
+ .into(),
+ )),
  #[cfg(feature = "runtime-benchmarks")]
  BenchmarkCmd::Storage(cmd) => runner.sync_run(|config| {
  let partials = new_partial(&config)?;

templates/parachain/node/src/service.rs

@@ -160,6 +160,7 @@ fn build_import_queue(
  )
 }
 
+#[allow(clippy::too_many_arguments)]
 fn start_consensus(
  client: Arc<ParachainClient>,
  backend: Arc<ParachainBackend>,

templates/parachain/pallets/template/Cargo.toml

@@ -9,9 +9,6 @@ repository.workspace = true
 edition.workspace = true
 publish = false
 
-[lints]
-workspace = true
-
 [package.metadata.docs.rs]
 targets = ["x86_64-unknown-linux-gnu"]
 

templates/parachain/pallets/template/src/benchmarking.rs

@@ -13,7 +13,7 @@ mod benchmarks {
 
  #[benchmark]
  fn do_something() {
- let value = 100u32.into();
+ let value = 100u32;
  let caller: T::AccountId = whitelisted_caller();
  #[extrinsic_call]
  do_something(RawOrigin::Signed(caller), value);

templates/parachain/runtime/Cargo.toml

@@ -9,9 +9,6 @@ repository.workspace = true
 edition.workspace = true
 publish = false
 
-[lints]
-workspace = true
-
 [package.metadata.docs.rs]
 targets = ["x86_64-unknown-linux-gnu"]
 

templates/solochain/node/Cargo.toml

@@ -11,9 +11,6 @@ publish = false
 
 build = "build.rs"
 
-[lints]
-workspace = true
-
 [package.metadata.docs.rs]
 targets = ["x86_64-unknown-linux-gnu"]
 

templates/solochain/node/src/command.rs

@@ -114,7 +114,7 @@ pub fn run() -> sc_cli::Result<()> {
  "Runtime benchmarking wasn't enabled when building the node. \
  You can enable it with `--features runtime-benchmarks`."
  .into(),
- )
+ );
  }
 
  cmd.run_with_spec::<sp_runtime::traits::HashingFor<Block>, ()>(Some(

templates/solochain/pallets/template/Cargo.toml

@@ -9,9 +9,6 @@ repository.workspace = true
 edition.workspace = true
 publish = false
 
-[lints]
-workspace = true
-
 [package.metadata.docs.rs]
 targets = ["x86_64-unknown-linux-gnu"]
 

templates/solochain/pallets/template/src/benchmarking.rs

@@ -13,7 +13,7 @@ mod benchmarks {
 
  #[benchmark]
  fn do_something() {
- let value = 100u32.into();
+ let value = 100u32;
  let caller: T::AccountId = whitelisted_caller();
  #[extrinsic_call]
  do_something(RawOrigin::Signed(caller), value);

templates/solochain/runtime/Cargo.toml

@@ -9,9 +9,6 @@ repository.workspace = true
 edition.workspace = true
 publish = false
 
-[lints]
-workspace = true
-
 [package.metadata.docs.rs]
 targets = ["x86_64-unknown-linux-gnu"]