Remove workspace lints from templates #4598
Conversation
Why does it looks weird? IMO the problem is that this then maybe breaks clippy for them because there is maybe code that we accept, but default clippy rejects. |
Actually it's the comments that look weird and out of place (to me). Perhaps we should keep the lints, but strip the comments?
That's not the case, because with this change, the templates are processed with default clippy inside the monorepo as well - as evidenced by this red check above. So if the clippy job is green in the monorepo, it will be green in individual repos as well - unless I'm missing something. |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Yeah good point, didn't thought about this. |
* master: (93 commits) Fix broken windows build (#4636) Beefy client generic on aduthority Id (#1816) pallet-staking: Put tests behind `cfg(debug_assertions)` (#4620) Broker new price adapter (#4521) Change `XcmDryRunApi::dry_run_extrinsic` to take a call instead (#4621) Update README.md (#4623) Publish `chain-spec-builder` (#4518) Add omni bencher & chain-spec-builder bins to release (#4557) Moves runtime macro out of experimental flag (#4249) Filter workspace dependencies in the templates (#4599) parachain-inherent: Make `para_id` more prominent (#4555) Add metric to measure the time it takes to gather enough assignments (#4587) Improve On_demand_assigner events (#4339) Conditional `required` checks (#4544) [CI] Deny adding git deps (#4572) [subsytem-bench] Remove redundant banchmark_name param (#4540) Add availability-recovery from systematic chunks (#1644) Remove workspace lints from templates (#4598) `sc-chain-spec`: deprecated code removed (#4410) [subsystem-benchmarks] Add statement-distribution benchmarks (#3863) ...
This detaches the templates from monorepo's workspace lints, so the lints for the templates can evolve separately as needed. Currently the templates [re-use the monorepo's lints](https://github.com/paritytech/polkadot-sdk-minimal-template/blob/bd8afe66ec566d61f36b0e3d731145741a9e9e19/Cargo.toml#L16-L43) which looks weird. cc @kianenigma @gupnik
This detaches the templates from monorepo's workspace lints, so the lints for the templates can evolve separately as needed. Currently the templates [re-use the monorepo's lints](https://github.com/paritytech/polkadot-sdk-minimal-template/blob/bd8afe66ec566d61f36b0e3d731145741a9e9e19/Cargo.toml#L16-L43) which looks weird. cc @kianenigma @gupnik
This detaches the templates from monorepo's workspace lints, so the lints for the templates can evolve separately as needed.
Currently the templates re-use the monorepo's lints which looks weird.
cc @kianenigma @gupnik