Broker new price adapter #4521

eskimor · 2024-05-20T12:15:32Z

Also rename: AllowedRenewals -> PotentialRenewals to avoid confusion of future readers. (An entry in AllowedRenewals is not enough to allow a renewal, the assignment also has to be complete, which is only checked afterwards.)

Does not work with renewals as is - fix.
More tests
PR docs

Edit 1:
(Relevant blog post: https://grillapp.net/12935/agile-coretime-pricing-explained-166522?ref=29715)

not on number of cores. I have to think a bit more about this, but I believe we will arrive have been sold at almost the base price

The old type was very misleading as an entry in `AllowedRenewals` does not mean that a renewal is actually allowed.

Overkillus

Left some questions and notes here and there but overall looking solid.

substrate/frame/broker/src/adapt_price.rs

substrate/frame/broker/src/types.rs

substrate/frame/broker/src/tick_impls.rs

seadanda

This PR includes three separate pallet-level changes as I see it:

Giving more scope to the PriceAdapter by removing restrictive logic from the pallet and allowing it to dictate the renewal price
Changing adapt_price to only consider price changes
Renaming AllowedRenewals to reflect its actual implementation

I am fully behind. Although I think that we should be adding more information to SalePerformance, rather than stripping it back to only the price. Including other metrics from the sale like cores offered and cores sold would achieve this without committing to 2.
I am not convinced by this approach, I think the new model that you're proposing here weakens the price finding mechanism in cases where we do not sell out, and would increase the time for the price to respond to market fluctuations -- both internal (demand for and perceived value of coretime) and external (DOT-FIAT volatility).
Even if I'm wrong, I think the work in 1 would allow more flexibility in the PriceAdapter would allow experimentation in the implementation without committing to it at the pallet level.
Good point, maybe we should reconsider where the completeness check happens. The check for a complete mask for a given workplan and full duration should probably happen before we put it in the AllowedRenewals at all, leaving it as a definitive list of cores that can be renewed. I think that's useful information to have in state.

substrate/frame/broker/src/types.rs

substrate/frame/broker/src/tick_impls.rs

substrate/frame/broker/src/utility_impls.rs

substrate/frame/broker/src/adapt_price.rs

h = 10 * o o = 10 * b

paritytech-cicd-pr · 2024-05-27T14:09:40Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6312420

eskimor · 2024-05-29T11:03:38Z

bot bench help

command-bot · 2024-05-29T11:03:41Z

@eskimor Unknown subcommand of "bench". Refer to help docs and/or source code.

eskimor · 2024-05-29T11:04:50Z

bot bench substrate-pallet --pallet=pallet_broker

command-bot · 2024-05-29T11:04:55Z

@eskimor https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6338420 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_broker. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-32355f27-7c3f-4ecb-81b8-18c5fd66045a to cancel this command or bot cancel to cancel all commands in this pull request.

…nto HEAD

…=dev --target_dir=substrate --pallet=pallet_broker

command-bot · 2024-05-29T11:54:13Z

@eskimor Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_broker has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6338420 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6338420/artifacts/download.

seadanda

Sweet, let's get it merged. Future models can add anything more general that is needed.

…o rk-broker-new-price-adapter

Fixes #4360 Also rename: AllowedRenewals -> PotentialRenewals to avoid confusion of future readers. (An entry in `AllowedRenewals` is not enough to allow a renewal, the assignment also has to be complete, which is only checked afterwards.) - [x] Does not work with renewals as is - fix. - [x] More tests - [x] PR docs Edit 1: (Relevant blog post: https://grillapp.net/12935/agile-coretime-pricing-explained-166522?ref=29715) --------- Co-authored-by: eskimor <eskimor@no-such-url.com> Co-authored-by: Dónal Murray <donal.murray@parity.io> Co-authored-by: command-bot <>

* master: (93 commits) Fix broken windows build (#4636) Beefy client generic on aduthority Id (#1816) pallet-staking: Put tests behind `cfg(debug_assertions)` (#4620) Broker new price adapter (#4521) Change `XcmDryRunApi::dry_run_extrinsic` to take a call instead (#4621) Update README.md (#4623) Publish `chain-spec-builder` (#4518) Add omni bencher & chain-spec-builder bins to release (#4557) Moves runtime macro out of experimental flag (#4249) Filter workspace dependencies in the templates (#4599) parachain-inherent: Make `para_id` more prominent (#4555) Add metric to measure the time it takes to gather enough assignments (#4587) Improve On_demand_assigner events (#4339) Conditional `required` checks (#4544) [CI] Deny adding git deps (#4572) [subsytem-bench] Remove redundant banchmark_name param (#4540) Add availability-recovery from systematic chunks (#1644) Remove workspace lints from templates (#4598) `sc-chain-spec`: deprecated code removed (#4410) [subsystem-benchmarks] Add statement-distribution benchmarks (#3863) ...

Only the price adapter changes are backported to avoid out-of-order migrations

…es (#4656)" This reverts commit 3bbbffa.

Only the price adapter changes are backported to avoid out-of-order migrations

* master: (106 commits) [ci] Delete unused flow (#4676) Fix umbrella CI check and fix the C&P message (#4670) Add Dockerfiles to the templates (#4637) Revamp the Readme of the minimal template (#4649) Add chain-spec-builder docker image (#4655) Update Amforc bootnodes for Kusama and Polkadot (#4668) make all storage items in parachain-system public (#4645) [Pools] Refactors and runtime apis for DelegateStake (#4537) update amforc westend and its parachain bootnodes (#4641) Better error for missing index in CRV2 (#4643) Implement `XcmPaymentApi` and `DryRunApi` on all system parachains (#4634) Use Unlicense for templates (#4628) collator-protocol: remove `elastic-scaling-experimental` feature (#4595) Update `runtime_type` ref doc with the new "Associated Type Bounds" (#4624) Adds ability to specify chain type in chain-spec-builder (#4542) Fix broken windows build (#4636) Beefy client generic on aduthority Id (#1816) pallet-staking: Put tests behind `cfg(debug_assertions)` (#4620) Broker new price adapter (#4521) Change `XcmDryRunApi::dry_run_extrinsic` to take a call instead (#4621) ...

Related to #4521 and #4656 This allows a release of the Broker pallet so the new price adapter can be tested on Kusama ASAP (polkadot-fellows/runtimes#334).

Fixes paritytech#4360 Also rename: AllowedRenewals -> PotentialRenewals to avoid confusion of future readers. (An entry in `AllowedRenewals` is not enough to allow a renewal, the assignment also has to be complete, which is only checked afterwards.) - [x] Does not work with renewals as is - fix. - [x] More tests - [x] PR docs Edit 1: (Relevant blog post: https://grillapp.net/12935/agile-coretime-pricing-explained-166522?ref=29715) --------- Co-authored-by: eskimor <eskimor@no-such-url.com> Co-authored-by: Dónal Murray <donal.murray@parity.io> Co-authored-by: command-bot <>

eskimor added 9 commits May 10, 2024 15:52

Price adjustements should be based on price

d598a1e

not on number of cores. I have to think a bit more about this, but I believe we will arrive have been sold at almost the base price

AllowedRenewal -> PotentialRenewal

ae90650

The old type was very misleading as an entry in `AllowedRenewals` does not mean that a renewal is actually allowed.

WIP: New price based AdaptPrice trait.

2855832

Pub

627acf7

Also adjust sellout_price on renew.

31ea3a9

Adapt price implementation.

63f5856

Some tests + handle going down to zero gracefully.

3630ccc

Fix tests.

b615fbe

More linear tests.

fd03dc1

eskimor marked this pull request as ready for review May 21, 2024 17:15

eskimor requested a review from a team as a code owner May 21, 2024 17:15

eskimor added T2-pallets This PR/Issue is related to a particular pallet. R1-breaking_change This PR introduces a breaking change and should be highlighted in the upcoming release. labels May 22, 2024

Add prdoc.

6fdc11b

eskimor changed the title ~~WIP: Broker new price adapter~~ Broker new price adapter May 22, 2024

Overkillus reviewed May 22, 2024

View reviewed changes

seadanda reviewed May 22, 2024

View reviewed changes

eskimor added 2 commits May 23, 2024 10:34

Put base price in the middle of the range.

cb5485d

h = 10 * o o = 10 * b

new leadin curve.

9299010

paritytech-review-bot bot requested a review from a team May 23, 2024 10:57

eskimor added 9 commits May 23, 2024 16:04

price -> base_price

28f13f4

Fmt

4b5a66d

base_price -> min_price

fad4aab

Merge branch 'master' into rk-broker-new-price-adapter

4979fbb

New example adapter name + more parameters (cores)

5869882

Fix kitchensink

baeab0e

Some logging + test.

aa4defc

Fix prdoc

d5992b4

regular_price -> end_price

03db451

eskimor force-pushed the rk-broker-new-price-adapter branch from 4882a2a to 7e2992c Compare May 29, 2024 10:42

command-bot added 2 commits May 29, 2024 11:07

Merge branch 'master' of https://github.com/paritytech/polkadot-sdk i…

654d1e4

…nto HEAD

".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

4cc238a

…=dev --target_dir=substrate --pallet=pallet_broker

seadanda approved these changes May 29, 2024

View reviewed changes

eskimor added 3 commits May 29, 2024 22:19

Change bump to minor again to make CI happy.

d6857aa

Merge remote-tracking branch 'origin/rk-broker-new-price-adapter' int…

c98a945

…o rk-broker-new-price-adapter

prdoc fix

d179b89

eskimor enabled auto-merge May 29, 2024 20:54

eskimor added this pull request to the merge queue May 29, 2024

Merged via the queue into master with commit f4dc8d2 May 29, 2024
156 of 157 checks passed

eskimor deleted the rk-broker-new-price-adapter branch May 29, 2024 21:50

seadanda added a commit that referenced this pull request May 31, 2024

Backport broker new price adapter (#4521) without extra changes

723d269

Only the price adapter changes are backported to avoid out-of-order migrations

seadanda added a commit that referenced this pull request Jun 3, 2024

Backport broker new price adapter (#4521) without extra changes (#4656)

3bbbffa

Only the price adapter changes are backported to avoid out-of-order migrations

seadanda added a commit that referenced this pull request Jun 3, 2024

Revert "Backport broker new price adapter (#4521) without extra chang…

40142d3

…es (#4656)" This reverts commit 3bbbffa.

seadanda added a commit that referenced this pull request Jun 3, 2024

Backport broker new price adapter (#4521) without extra changes (#4656)

b808b84

Only the price adapter changes are backported to avoid out-of-order migrations

seadanda mentioned this pull request Jun 4, 2024

Crates broker backport #4694

Merged

EgorPopelyaev pushed a commit that referenced this pull request Jun 4, 2024

Crates broker backport (#4694)

aed41ba

Related to #4521 and #4656 This allows a release of the Broker pallet so the new price adapter can be tested on Kusama ASAP (polkadot-fellows/runtimes#334).

This was referenced Aug 21, 2024

Update polkadot-sdk from v1.11.0 to stable2407 moondance-labs/tanssi#659

Open

Update polkadot-sdk from v1.11.0 to stable2407 moonbeam-foundation/moonbeam#2912

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Broker new price adapter #4521

Broker new price adapter #4521

eskimor commented May 20, 2024 •

edited by Overkillus

Loading

Overkillus left a comment

seadanda left a comment •

edited

Loading

paritytech-cicd-pr commented May 27, 2024

eskimor commented May 29, 2024

command-bot bot commented May 29, 2024

eskimor commented May 29, 2024

command-bot bot commented May 29, 2024 •

edited

Loading

command-bot bot commented May 29, 2024

seadanda left a comment

Broker new price adapter #4521

Broker new price adapter #4521

Conversation

eskimor commented May 20, 2024 • edited by Overkillus Loading

Overkillus left a comment

Choose a reason for hiding this comment

seadanda left a comment • edited Loading

Choose a reason for hiding this comment

paritytech-cicd-pr commented May 27, 2024

eskimor commented May 29, 2024

command-bot bot commented May 29, 2024

eskimor commented May 29, 2024

command-bot bot commented May 29, 2024 • edited Loading

command-bot bot commented May 29, 2024

seadanda left a comment

Choose a reason for hiding this comment

eskimor commented May 20, 2024 •

edited by Overkillus

Loading

seadanda left a comment •

edited

Loading

command-bot bot commented May 29, 2024 •

edited

Loading