Implement XcmPaymentApi and DryRunApi on all system parachains
#4634
Conversation
There was a problem hiding this comment.
One nit: query_acceptable_payment_assets and query_weight_to_asset_fee have some logic (converting, matching and logging) and since it'll propagate to another 8+ chains in the future (meaning DotSama), maybe it worth to add that implementation to some crate instead of copying the same code over and over. Ideally it should be just one liner :)
Good point, if we had a good config item on pallet-xcm that gave us what we need I could de-duplicate very easily. However, that's not the case. I can make one in the future. For now, I managed to get |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
* master: (106 commits) [ci] Delete unused flow (#4676) Fix umbrella CI check and fix the C&P message (#4670) Add Dockerfiles to the templates (#4637) Revamp the Readme of the minimal template (#4649) Add chain-spec-builder docker image (#4655) Update Amforc bootnodes for Kusama and Polkadot (#4668) make all storage items in parachain-system public (#4645) [Pools] Refactors and runtime apis for DelegateStake (#4537) update amforc westend and its parachain bootnodes (#4641) Better error for missing index in CRV2 (#4643) Implement `XcmPaymentApi` and `DryRunApi` on all system parachains (#4634) Use Unlicense for templates (#4628) collator-protocol: remove `elastic-scaling-experimental` feature (#4595) Update `runtime_type` ref doc with the new "Associated Type Bounds" (#4624) Adds ability to specify chain type in chain-spec-builder (#4542) Fix broken windows build (#4636) Beefy client generic on aduthority Id (#1816) pallet-staking: Put tests behind `cfg(debug_assertions)` (#4620) Broker new price adapter (#4521) Change `XcmDryRunApi::dry_run_extrinsic` to take a call instead (#4621) ...
…aritytech#4634) Depends on paritytech#4621. Implemented the [`XcmPaymentApi`](paritytech#3607) and [`DryRunApi`](paritytech#3872) on all system parachains. More scenarios can be tested on both rococo and westend if all system parachains implement this APIs. The objective is for all XCM-enabled runtimes to implement them. After demonstrating fee estimation in a UI on the testnets, come the fellowship runtimes. Step towards paritytech#690.
…aritytech#4634) Depends on paritytech#4621. Implemented the [`XcmPaymentApi`](paritytech#3607) and [`DryRunApi`](paritytech#3872) on all system parachains. More scenarios can be tested on both rococo and westend if all system parachains implement this APIs. The objective is for all XCM-enabled runtimes to implement them. After demonstrating fee estimation in a UI on the testnets, come the fellowship runtimes. Step towards paritytech#690.
Depends on #4621.
Implemented the
XcmPaymentApiandDryRunApion all system parachains.More scenarios can be tested on both rococo and westend if all system parachains implement this APIs.
The objective is for all XCM-enabled runtimes to implement them.
After demonstrating fee estimation in a UI on the testnets, come the fellowship runtimes.
Step towards #690.