Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metric to measure the time it takes to gather enough assignments #4587

Merged
merged 9 commits into from
May 28, 2024
Merged

Add metric to measure the time it takes to gather enough assignments #4587

merged 9 commits into from
May 28, 2024

Conversation

alexggh
Copy link
Contributor

@alexggh alexggh commented May 26, 2024

To understand with high granularity how many assignment tranches are triggered before we concur that we have enough assignments.

This metric is important because the triggering of an assignment creates a lot of work in the system for approving the candidate and gossiping the necessary messages.

@alexggh
Add metric to measure the time it takes to gather enough assignments
da1e2e0 
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh
Add log message
8ccd444 
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6299985

ordian
ordian reviewed May 26, 2024
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but left a few nits and questions.

polkadot/node/core/approval-voting/src/lib.rs Outdated Show resolved Hide resolved
polkadot/node/core/approval-voting/src/lib.rs Outdated Show resolved Hide resolved
polkadot/node/core/approval-voting/src/lib.rs Show resolved Hide resolved
polkadot/node/core/approval-voting/src/lib.rs Outdated Show resolved Hide resolved
@alexggh
Fix clippy
ea004da 
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh
Address review feedback
6458aac 
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@ordian ordian added T0-node This PR/Issue is related to the topic “node”. T8-polkadot This PR/Issue is related to/affects the Polkadot network. and removed T0-node This PR/Issue is related to the topic “node”. T8-polkadot This PR/Issue is related to/affects the Polkadot network. labels May 27, 2024
sandreim
sandreim reviewed May 27, 2024
View reviewed changes
Copy link
Contributor

@sandreim sandreim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the equivalent of polkadot_parachain_assignments_produced_bucket but for other validator assignments we import.

polkadot/node/core/approval-voting/src/lib.rs Show resolved Hide resolved
polkadot/node/core/approval-voting/src/lib.rs Outdated Show resolved Hide resolved
polkadot/node/core/approval-voting/src/lib.rs Show resolved Hide resolved
ordian
ordian approved these changes May 27, 2024
View reviewed changes
polkadot/node/core/approval-voting/src/lib.rs Outdated Show resolved Hide resolved
@alexggh
Use LRU for keeping track of blocks
c001112 
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh
Review feedback
3bcce00 
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
ordian
ordian approved these changes May 27, 2024
View reviewed changes
polkadot/node/core/approval-voting/src/lib.rs Outdated Show resolved Hide resolved
polkadot/node/core/approval-voting/src/lib.rs Outdated Show resolved Hide resolved
alexggh and others added 2 commits May 27, 2024 17:01
@alexggh @ordian
Update polkadot/node/core/approval-voting/src/lib.rs
23d6169 
Co-authored-by: ordian <write@reusable.software>
@alexggh
Remove lower than
495939f 
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh
Add trace log
33115d5 
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh alexggh enabled auto-merge May 28, 2024 05:12
@alexggh alexggh added the R0-silent Changes should not be mentioned in any release notes label May 28, 2024
@alexggh alexggh added this pull request to the merge queue May 28, 2024
Merged via the queue into master with commit ad22fa6 May 28, 2024
153 of 155 checks passed
@alexggh alexggh deleted the alexggh/assignment_gathering_time branch May 28, 2024 16:26
ordian added a commit that referenced this pull request May 30, 2024
@ordian
Merge branch 'master' into ao-statement-distribution-reenabling-prep
9684df4 
* master: (93 commits)
  Fix broken windows build (#4636)
  Beefy client generic on aduthority Id (#1816)
  pallet-staking: Put tests behind `cfg(debug_assertions)` (#4620)
  Broker new price adapter (#4521)
  Change `XcmDryRunApi::dry_run_extrinsic` to take a call instead (#4621)
  Update README.md (#4623)
  Publish `chain-spec-builder` (#4518)
  Add omni bencher & chain-spec-builder bins to release (#4557)
  Moves runtime macro out of experimental flag (#4249)
  Filter workspace dependencies in the templates (#4599)
  parachain-inherent: Make `para_id` more prominent (#4555)
  Add metric to measure the time it takes to gather enough assignments (#4587)
  Improve On_demand_assigner events (#4339)
  Conditional `required` checks (#4544)
  [CI] Deny adding git deps (#4572)
  [subsytem-bench] Remove redundant banchmark_name param (#4540)
  Add availability-recovery from systematic chunks (#1644)
  Remove workspace lints from templates (#4598)
  `sc-chain-spec`: deprecated code removed (#4410)
  [subsystem-benchmarks] Add statement-distribution benchmarks (#3863)
  ...
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
@alexggh @ordian @hitchhooker
Add metric to measure the time it takes to gather enough assignments (p…
3a420fb 
…aritytech#4587)

To understand with high granularity how many assignment tranches are
triggered before we concur that we have enough assignments.

This metric is important because the triggering of an assignment creates
a lot of work in the system for approving the candidate and gossiping
the necessary messages.

---------

Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Co-authored-by: ordian <write@reusable.software>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@alexggh @ordian @TarekkMA
Add metric to measure the time it takes to gather enough assignments (p…
df1a8ae 
…aritytech#4587)

To understand with high granularity how many assignment tranches are
triggered before we concur that we have enough assignments.

This metric is important because the triggering of an assignment creates
a lot of work in the system for approving the candidate and gossiping
the necessary messages.

---------

Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Co-authored-by: ordian <write@reusable.software>
This was referenced Aug 21, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexnv lexnv lexnv approved these changes

@sandreim sandreim sandreim approved these changes

@AndreiEres AndreiEres AndreiEres approved these changes

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexggh @paritytech-cicd-pr @ordian @AndreiEres @sandreim @lexnv