pallet-timestamp: UnixTime::now implementation logs error only if called at genesis
#5055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpestana
added
the
R0-silent
About which environments are you talking here about? |
The error is polluting a bunch of test cases. |
Where is this run? In CI? |
Yep, and locally too. For example, if you run the test of the pallet-staking in master locally, you'll see the error message logged from the timestamp pallet due to removing the |
bkchr
reviewed
Jul 19, 2024
…error only when called at genesis
gpestana
changed the title
UnixTime::now logs error only if called at genesis
gpestana
changed the title
UnixTime::now logs error only if called at genesisUnixTime::now implementation logs error only if called at genesis
ggwpez
approved these changes
Jul 30, 2024
bkchr
approved these changes
Jul 30, 2024
|
FYI |
bkchr
added
T2-pallets
|
Then @gpestana please add some |
acatangiu
approved these changes
Jul 30, 2024
seadanda
approved these changes
Jul 30, 2024
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
…alled at genesis (paritytech#5055) This PR reverts the removal of an [`if` statement](paritytech@7ecf3f7#diff-8bf31ba8d9ebd6377983fd7ecc7f4e41cb1478a600db1a15a578d1ae0e8ed435L370) merged recently, which affected test output verbosity of several pallets (e.g. staking, EPM, and potentially others). More generally, the `UnixTime::now` implementation of the timestamp pallet should log an error *only* when called at the genesis block.
ordian
added a commit
that referenced
this pull request
Aug 6, 2024
* master: (51 commits) Remove unused feature gated code from the minimal template (#5237) make polkadot-parachain startup errors pretty (#5214) Coretime auto-renew (#4424) network/strategy: Backoff and ban overloaded peers to avoid submitting the same request multiple times (#5029) Fix frame crate usage doc (#5222) beefy: Tolerate pruned state on runtime API call (#5197) rpc: Enable ChainSpec for polkadot-parachain (#5205) Add an adapter for configuring AssetExchanger (#5130) Replace env_logger with sp_tracing (#5065) Adjust sync templates flow to use new release branch (#5182) litep2p/discovery: Publish authority records with external addresses only (#5176) Run UI tests in CI for some other crates (#5167) Remove `pallet::getter` usage from the pallet-balances (#4967) pallet-timestamp: `UnixTime::now` implementation logs error only if called at genesis (#5055) [CI] Cache try-runtime check (#5179) [Backport] version bumps and the prdocs reordering from stable2407 (#5178) [subsystem-benchmark] Update availability-distribution-regression-bench baseline after recent subsystem changes (#5180) Remove pallet::getter usage from proxy (#4963) Remove pallet::getter macro usage from pallet-election-provider-multi-phase (#4487) Review-bot@2.6.0 (#5177) ...
bkchr
pushed a commit
that referenced
this pull request
Aug 25, 2024
…alled at genesis (#5055) This PR reverts the removal of an [`if` statement](7ecf3f7#diff-8bf31ba8d9ebd6377983fd7ecc7f4e41cb1478a600db1a15a578d1ae0e8ed435L370) merged recently, which affected test output verbosity of several pallets (e.g. staking, EPM, and potentially others). More generally, the `UnixTime::now` implementation of the timestamp pallet should log an error *only* when called at the genesis block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the removal of an
ifstatement merged recently, which affected test output verbosity of several pallets (e.g. staking, EPM, and potentially others).More generally, the
UnixTime::nowimplementation of the timestamp pallet should log an error only when called at the genesis block.