Replace env_logger with sp_tracing #5065

Safrout1 · 2024-07-18T13:04:10Z

This PR replaces env_logger with sp_tracing because of an issue with env_logger and gum #4660

polkadot address: 1upUS3E5th6CphPJg2kjKHY2gDXex6iB6J6V64qmCV7Jw7s

cla-bot-2021 · 2024-07-18T13:04:17Z

User @Safrout1, please sign the CLA here.

AndreiEres

That's ok

bridges/snowbridge/pallets/outbound-queue/merkle-tree/Cargo.toml

bkchr

If env_logger is not used anymore anywhere, you should also remove it from the workspace Cargo.toml file.

Safrout1 · 2024-07-22T10:29:50Z

@bkchr No, it is used in 4 non-test files:
1 | bridges/relays/utils/src/initialize.rs
2 | polkadot/node/subsystem-bench/src/cli/subsystem-bench.rs
3 | substrate/client/executor/benches/bench.rs
4 | substrate/utils/frame/omni-bencher/src/main.rs

acatangiu

Can you extend this outside of testing too? Replace env_logger completely?

substrate/frame/sassafras/src/tests.rs

AndreiEres

A few comments

polkadot/node/network/bitfield-distribution/Cargo.toml

polkadot/node/network/collator-protocol/Cargo.toml

polkadot/xcm/xcm-runtime-apis/tests/fee_estimation.rs

AndreiEres · 2024-07-23T10:40:36Z

1 | bridges/relays/utils/src/initialize.rs

It's inside initialize_logger which used only in initialize_relay. I don't see any usages of initialize_relay in the code base. @acatangiu wdyt is it ok to replace it with try_init_simple?

2 | polkadot/node/subsystem-bench/src/cli/subsystem-bench.rs

Here is ok to replace with try_init_simple

3 | substrate/client/executor/benches/bench.rs
4 | substrate/utils/frame/omni-bencher/src/main.rs

We can try to use try_init_simple here as well. Let's change and ask guys that put it there if it's ok.

acatangiu · 2024-07-23T10:44:06Z

cc @serban300 ^

AndreiEres · 2024-07-23T10:54:15Z

I have updated the PR with all test files except for one: substrate/frame/contracts/src/tests.rs
This one's tests fail when using sp-tracing, I think it has to do with setting the right env, I am still figuring it out. Let me know if the test is the wrong one in that case.

Try try_init_simple.

serban300 · 2024-07-23T11:11:44Z

1 | bridges/relays/utils/src/initialize.rs

It's inside initialize_logger which used only in initialize_relay. I don't see any usages of initialize_relay in the code base. @acatangiu wdyt is it ok to replace it with try_init_simple?

It is used in parity-bridges-common: https://github.com/paritytech/parity-bridges-common/blob/63ac22d90462d14a1f1e9c36427473fa2fa57cb1/substrate-relay/src/cli/mod.rs#L93

I'm not sure what try_init_simple() does, but I think it would be good to keep the current characteristics, for example:

	builder.filter_level(log::LevelFilter::Warn);
	builder.filter_module("bridge", log::LevelFilter::Info);

The time format is probably not super important.

Co-authored-by: Adrian Catangiu <adrian@parity.io>

acatangiu · 2024-07-25T16:07:05Z

The CI pipeline was cancelled due to failure one of the required jobs. Job name: cargo-clippy Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6817241

@Safrout1 please fix these remaining issues

…/tests.rs

…ch.rs

…trate/utils/frame/omni-bencher/src/main.rs

Safrout1 · 2024-07-31T11:19:29Z

Hello,

I think the only required check that fails is continuous-integration/gitlab-check-toml-format

but whenever I run taplo format substrate/primitives/tracing/Cargo.toml on my machine, nothing new happens to the file.

Should I run a different command, the log in the job is also not helpful, WDYT?

@acatangiu @AndreiEres

serban300 · 2024-07-31T12:44:42Z

Hello,

I think the only required check that fails is continuous-integration/gitlab-check-toml-format

but whenever I run taplo format substrate/primitives/tracing/Cargo.toml on my machine, nothing new happens to the file.

Should I run a different command, the log in the job is also not helpful, WDYT?

@acatangiu @AndreiEres

Can you also try taplo format --config .config/taplo.toml ?

AndreiEres · 2024-07-31T12:58:13Z

Look at that please as well https://github.com/paritytech/polkadot-sdk/actions/runs/10166554064/job/28141652578?pr=5065
There are suggestions for the pr_doc

AndreiEres

Good job @Safrout1, thank you

AndreiEres · 2024-08-06T13:22:22Z

@Safrout1 could you provide your DOT address in the PR description?

* master: (51 commits) Remove unused feature gated code from the minimal template (#5237) make polkadot-parachain startup errors pretty (#5214) Coretime auto-renew (#4424) network/strategy: Backoff and ban overloaded peers to avoid submitting the same request multiple times (#5029) Fix frame crate usage doc (#5222) beefy: Tolerate pruned state on runtime API call (#5197) rpc: Enable ChainSpec for polkadot-parachain (#5205) Add an adapter for configuring AssetExchanger (#5130) Replace env_logger with sp_tracing (#5065) Adjust sync templates flow to use new release branch (#5182) litep2p/discovery: Publish authority records with external addresses only (#5176) Run UI tests in CI for some other crates (#5167) Remove `pallet::getter` usage from the pallet-balances (#4967) pallet-timestamp: `UnixTime::now` implementation logs error only if called at genesis (#5055) [CI] Cache try-runtime check (#5179) [Backport] version bumps and the prdocs reordering from stable2407 (#5178) [subsystem-benchmark] Update availability-distribution-regression-bench baseline after recent subsystem changes (#5180) Remove pallet::getter usage from proxy (#4963) Remove pallet::getter macro usage from pallet-election-provider-multi-phase (#4487) Review-bot@2.6.0 (#5177) ...

Safrout1 · 2024-08-06T13:41:59Z

@Safrout1 could you provide your DOT address in the PR description?

@AndreiEres done, but would you like to explain why?

AndreiEres · 2024-08-06T15:07:00Z

@AndreiEres done, but would you like to explain why?

I'll try to tip you for your job

sandreim · 2024-08-06T15:16:02Z

/tip small

substrate-tip-bot · 2024-08-06T15:16:40Z

@sandreim A referendum for a small (20 DOT) tip was successfully submitted for @Safrout1 (1upUS3E5th6CphPJg2kjKHY2gDXex6iB6J6V64qmCV7Jw7s on polkadot).

Referendum number: 1055.

substrate-tip-bot · 2024-08-06T15:17:15Z

The referendum has appeared on Polkassembly.

Use sp_tracing for tests logging

81309ff

Safrout1 mentioned this pull request Jul 18, 2024

Replace env_logger with sp_tracing #4660

Closed

AndreiEres reviewed Jul 18, 2024

View reviewed changes

bridges/snowbridge/pallets/outbound-queue/merkle-tree/Cargo.toml Outdated Show resolved Hide resolved

replace env_logger with sp_tracing in test files

0efe06b

Safrout1 marked this pull request as ready for review July 18, 2024 20:06

Safrout1 requested review from acatangiu and a team as code owners July 18, 2024 20:06

Safrout1 requested a review from AndreiEres July 18, 2024 20:07

paritytech-review-bot bot requested a review from a team July 18, 2024 20:07

bkchr reviewed Jul 18, 2024

View reviewed changes

Safrout1 requested a review from bkchr July 22, 2024 10:29

paritytech-review-bot bot requested a review from a team July 22, 2024 10:30

acatangiu reviewed Jul 23, 2024

View reviewed changes

substrate/frame/sassafras/src/tests.rs Outdated Show resolved Hide resolved

AndreiEres reviewed Jul 23, 2024

View reviewed changes

polkadot/node/network/bitfield-distribution/Cargo.toml Show resolved Hide resolved

polkadot/node/network/collator-protocol/Cargo.toml Show resolved Hide resolved

polkadot/xcm/xcm-runtime-apis/tests/fee_estimation.rs Outdated Show resolved Hide resolved

Update substrate/frame/sassafras/src/tests.rs

30daacc

Co-authored-by: Adrian Catangiu <adrian@parity.io>

paritytech-review-bot bot requested a review from a team July 25, 2024 14:15

Merge branch 'master' into use-sp-tracing

7e329e5

Safrout1 added 2 commits July 28, 2024 12:27

omit the let _ for sp-tracing

467d69c

Use sp_tracing with try_init_simple for substrate/frame/contracts/src…

60611fb

…/tests.rs

Safrout1 requested a review from athei as a code owner July 28, 2024 11:42

Safrout1 added 2 commits July 28, 2024 13:52

use sp-tracing in polkadot/node/subsystem-bench/src/cli/subsystem-ben…

8b59993

…ch.rs

Use sp-tracing in substrate/client/executor/benches/bench.rs and subs…

50a54d1

…trate/utils/frame/omni-bencher/src/main.rs

Safrout1 added 2 commits July 30, 2024 14:48

Format the initializers.rs file

a1ca808

Add a .prdoc file

0a405f6

Safrout1 requested a review from serban300 July 30, 2024 13:11

Safrout1 added 2 commits July 30, 2024 15:36

use default features of sp-tracing always

d794d1d

format the tracing cargo.toml

e7ed418

Safrout1 added 4 commits July 31, 2024 16:14

formatting cargo.toml files with taplo

ebc4ef9

add the suggestions for the prdoc

7b4f321

Merge branch 'master' into use-sp-tracing

928f882

format the prdoc file

0e4bdf3

acatangiu approved these changes Aug 1, 2024

View reviewed changes

AndreiEres approved these changes Aug 1, 2024

View reviewed changes

acatangiu added this pull request to the merge queue Aug 1, 2024

sandreim approved these changes Aug 1, 2024

View reviewed changes

AndreiEres linked an issue Aug 1, 2024 that may be closed by this pull request

Replace env_logger with sp_tracing #4660

Closed

Merged via the queue into paritytech:master with commit 776e957 Aug 1, 2024
161 of 164 checks passed

AndreiEres mentioned this pull request Sep 3, 2024

[5 / 5] Introduce approval-voting-parallel #4849

Merged

6 tasks

ggwpez mentioned this pull request Sep 9, 2024

Parent issue for stable2409 LTS release #5583

Closed

github-actions bot mentioned this pull request Oct 8, 2024

Update polkadot-sdk from stable2407 to stable2409 moonbeam-foundation/moonbeam#2994

Open

TDemeco mentioned this pull request Oct 14, 2024

feat: ⏫ upgrade to Polkadot SDK stable2409 Moonsong-Labs/storage-hub#228

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace env_logger with sp_tracing #5065

Replace env_logger with sp_tracing #5065

Safrout1 commented Jul 18, 2024 •

edited by sandreim

Loading

cla-bot-2021 bot commented Jul 18, 2024

AndreiEres left a comment

bkchr left a comment

Safrout1 commented Jul 22, 2024

acatangiu left a comment

AndreiEres left a comment

AndreiEres commented Jul 23, 2024

acatangiu commented Jul 23, 2024

AndreiEres commented Jul 23, 2024

serban300 commented Jul 23, 2024

acatangiu commented Jul 25, 2024

Safrout1 commented Jul 31, 2024

serban300 commented Jul 31, 2024

AndreiEres commented Jul 31, 2024

AndreiEres left a comment

AndreiEres commented Aug 6, 2024

Safrout1 commented Aug 6, 2024

AndreiEres commented Aug 6, 2024 •

edited

Loading

sandreim commented Aug 6, 2024

substrate-tip-bot bot commented Aug 6, 2024

substrate-tip-bot bot commented Aug 6, 2024

Replace env_logger with sp_tracing #5065

Replace env_logger with sp_tracing #5065

Conversation

Safrout1 commented Jul 18, 2024 • edited by sandreim Loading

cla-bot-2021 bot commented Jul 18, 2024

AndreiEres left a comment

Choose a reason for hiding this comment

bkchr left a comment

Choose a reason for hiding this comment

Safrout1 commented Jul 22, 2024

acatangiu left a comment

Choose a reason for hiding this comment

AndreiEres left a comment

Choose a reason for hiding this comment

AndreiEres commented Jul 23, 2024

acatangiu commented Jul 23, 2024

AndreiEres commented Jul 23, 2024

serban300 commented Jul 23, 2024

acatangiu commented Jul 25, 2024

Safrout1 commented Jul 31, 2024

serban300 commented Jul 31, 2024

AndreiEres commented Jul 31, 2024

AndreiEres left a comment

Choose a reason for hiding this comment

AndreiEres commented Aug 6, 2024

Safrout1 commented Aug 6, 2024

AndreiEres commented Aug 6, 2024 • edited Loading

sandreim commented Aug 6, 2024

substrate-tip-bot bot commented Aug 6, 2024

substrate-tip-bot bot commented Aug 6, 2024

Safrout1 commented Jul 18, 2024 •

edited by sandreim

Loading

AndreiEres commented Aug 6, 2024 •

edited

Loading