Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run semver check even when no prdoc #5189

Merged
merged 5 commits into from
Aug 7, 2024
Merged

Run semver check even when no prdoc #5189

merged 5 commits into from
Aug 7, 2024

Conversation

Morganamilo
Copy link
Contributor

No description provided.

@Morganamilo Morganamilo requested review from a team as code owners July 30, 2024 13:35
@Morganamilo Morganamilo added R0-silent Changes should not be mentioned in any release notes A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). labels Jul 30, 2024
ggwpez
ggwpez reviewed Jul 30, 2024
View reviewed changes
substrate/frame/src/lib.rs Outdated Show resolved Hide resolved
@paritytech-review-bot paritytech-review-bot bot requested a review from a team July 30, 2024 14:29
@ggwpez ggwpez mentioned this pull request Aug 5, 2024
Merged
@Morganamilo Morganamilo added this pull request to the merge queue Aug 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 5, 2024
@ggwpez ggwpez added this pull request to the merge queue Aug 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 5, 2024
@ggwpez ggwpez added this pull request to the merge queue Aug 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 6, 2024
@ggwpez ggwpez enabled auto-merge August 6, 2024 09:51
ggwpez added a commit that referenced this pull request Aug 6, 2024
@ggwpez @Morganamilo
Backport #4812 and #5189 into stable (#5248)
846c6ea 
Backport #4812 and #5189 to fix the CI.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Morgan Adamiec <morgan@parity.io>
@ggwpez ggwpez added this pull request to the merge queue Aug 7, 2024
Merged via the queue into master with commit a986da2 Aug 7, 2024
157 of 160 checks passed
@ggwpez ggwpez deleted the semverci branch August 7, 2024 10:19
ordian added a commit that referenced this pull request Aug 7, 2024
@ordian
Merge branch 'master' into ao-fix-parainclusion-weight-overestimation
ca5ee10 
* master:
  Umbrella crate: exclude chain-specific crates (#5173)
  Bring reference_hardware.json inline with machine used for weights (#5196)
  Snowbridge on Westend (#5074)
  Run semver check even when no prdoc (#5189)
  Export more from sc-service (#5250)
  Update the wishlist leaderboard script to handle PRs (#5256)
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Aug 28, 2024
@Morganamilo @ggwpez @dharjeezy
Run semver check even when no prdoc (paritytech#5189)
d319c4d 
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EgorPopelyaev EgorPopelyaev EgorPopelyaev approved these changes

@ggwpez ggwpez ggwpez approved these changes

Assignees
No one assigned
Labels
A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Morganamilo @EgorPopelyaev @ggwpez