Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #4812 and #5189 into stable #5248

Merged
merged 6 commits into from
Aug 6, 2024
Merged

Backport #4812 and #5189 into stable #5248

merged 6 commits into from
Aug 6, 2024

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Aug 5, 2024

Backport #4812 and #5189 to fix the CI.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez requested review from a team as code owners August 5, 2024 16:15
@ggwpez ggwpez added the R0-silent Changes should not be mentioned in any release notes label Aug 5, 2024
@ggwpez ggwpez changed the title Backport #4812 into stable Backport #4812 and #5189 into stable Aug 5, 2024
Copy link

github-actions bot commented Aug 5, 2024

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or trivial (not sure audit).
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez merged commit 846c6ea into stable2407 Aug 6, 2024
148 of 159 checks passed
@ggwpez ggwpez deleted the oty-backport branch August 6, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants