Don't disconnect on invalid imports. #5392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are numerous reasons for invalid imports, most of them are likely caused by bugs. On the other side dispute distribution handles all connections fairly, thus there is little harm in keeping a problematic connection open.
sandreim
approved these changes
Aug 17, 2024
alexggh
approved these changes
Aug 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ordian
approved these changes
Aug 20, 2024
|
The CI pipeline was cancelled due to failure one of the required jobs. |
lexnv
approved these changes
Aug 21, 2024
eskimor
added a commit
that referenced
this pull request
Aug 24, 2024
There are numerous reasons for invalid imports, most of them would likely be caused by bugs. On the other side, dispute distribution handles all connections fairly, thus there is little harm in keeping a problematic connection open. --------- Co-authored-by: eskimor <eskimor@no-such-url.com> Co-authored-by: ordian <write@reusable.software>
ggwpez
pushed a commit
that referenced
this pull request
Aug 27, 2024
There are numerous reasons for invalid imports, most of them would likely be caused by bugs. On the other side, dispute distribution handles all connections fairly, thus there is little harm in keeping a problematic connection open. --------- Co-authored-by: eskimor <eskimor@no-such-url.com> Co-authored-by: ordian <write@reusable.software>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are numerous reasons for invalid imports, most of them would likely be caused by bugs. On the other side, dispute distribution handles all connections fairly, thus there is little harm in keeping a problematic connection open.