Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't disconnect on invalid imports. #5392

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Don't disconnect on invalid imports. #5392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c6d4f1
Don't disconnect on invalid imports.
Aug 17, 2024
6f215a7
Add prdoc
Aug 19, 2024
4d6fb52
Merge branch 'master' into rk-dont-punish-spam
ordian Aug 20, 2024
3167341
Merge branch 'master' into rk-dont-punish-spam
eskimor Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions polkadot/node/network/dispute-distribution/src/receiver/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,12 @@ use self::{

const COST_INVALID_REQUEST: Rep = Rep::CostMajor("Received message could not be decoded.");
const COST_INVALID_SIGNATURE: Rep = Rep::Malicious("Signatures were invalid.");
const COST_INVALID_IMPORT: Rep =
Rep::Malicious("Import was deemed invalid by dispute-coordinator.");
const COST_NOT_A_VALIDATOR: Rep = Rep::CostMajor("Reporting peer was not a validator.");

/// Invalid imports can be caused by flooding, e.g. by a disabled validator.
const COST_INVALID_IMPORT: Rep =
Rep::CostMinor("Import was deemed invalid by dispute-coordinator.");

/// Mildly punish peers exceeding their rate limit.
///
/// For honest peers this should rarely happen, but if it happens we would not want to disconnect
Expand Down
11 changes: 11 additions & 0 deletions prdoc/pr_5392.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
title: "Don't disconnect disabled nodes sending us dispute messages"

doc:
- audience: Node Operator
description: |
No longer disconnect peers which we consider disabled when raising
disputes as this will affect the approval process and thus finality.

crates:
- name: polkadot-dispute-distribution
bump: patch
Loading