-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Deprecation] deprecate treasury spend_local
call and related items
#6169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidk-pt
added
the
T1-FRAME
This PR/Issue is related to core FRAME, the framework.
label
Oct 22, 2024
davidk-pt
force-pushed
the
davidk/treasury-deprecate-proposals
branch
from
October 23, 2024 11:16
7d84424
to
061d27f
Compare
davidk-pt
changed the title
WIP: Initial attempt at implementing Pay trait for treasury
Deprecate Gov_v1 spend flow from treasury pallet
Oct 23, 2024
muharem
changed the title
Deprecate Gov_v1 spend flow from treasury pallet
[Deprecation] deprecate treasury Oct 24, 2024
spend_local
call and related items
muharem
reviewed
Oct 24, 2024
Co-authored-by: Muharem <ismailov.m.h@gmail.com>
Co-authored-by: Muharem <ismailov.m.h@gmail.com>
Co-authored-by: Muharem <ismailov.m.h@gmail.com>
Co-authored-by: Muharem <ismailov.m.h@gmail.com>
Co-authored-by: Muharem <ismailov.m.h@gmail.com>
muharem
approved these changes
Oct 28, 2024
kianenigma
reviewed
Oct 29, 2024
kianenigma
reviewed
Oct 29, 2024
kianenigma
reviewed
Oct 29, 2024
kianenigma
approved these changes
Oct 29, 2024
Ank4n
approved these changes
Oct 29, 2024
ordian
added a commit
that referenced
this pull request
Nov 5, 2024
* master: (129 commits) pallet-revive: Use `RUSTUP_TOOLCHAIN` if set (#6365) [eth-rpc] proxy /health (#6360) [Release|CI/CD] adjust release pipelines (#6366) Bump the known_good_semver group across 1 directory with 3 updates (#6339) Run check semver in MQ (#6287) [Deprecation] deprecate treasury `spend_local` call and related items (#6169) refactor and harden check_core_index (#6217) litep2p: Update litep2p to v0.8.0 (#6353) [pallet-staking] Additional check for virtual stakers (#5985) migrate pallet-remarks to v2 bench syntax (#6291) Remove leftover references of Wococo (#6361) snowbridge: allow account conversion for Ethereum accounts (#6221) authority-discovery: Populate DHT records with public listen addresses (#6298) Bounty Pallet: add `approve_bounty_with_curator` call to `bounties` pallet (#5961) Silent annoying log (#6351) [pallet-revive] rework balance transfers (#6187) `statement-distribution`: RFC103 implementation (#5883) Disable flaky tests reported in #6343 / #6345 (#6346) migrate pallet-recovery to benchmark V2 syntax (#6299) inclusion emulator: correctly handle UMP signals (#6178) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5930
spend_local
fromtreasury
pallet and associated types are deprecated.spend_local
was being used before with native currency in the treasury.This PR provides a documentation on how to migrate to the
spend
call instead.Migration
For users who were using only
spend_local
beforeTo replace
spend_local
functionality configurePaymaster
pallet configuration to bePayFromAccount
and configureAssetKind
to be()
and usespend
call instead.This way
spend
call will function as deprecatedspend_local
.Example:
For users who were already using
spend
with all other assets, except the native assetUse
NativeOrWithId
type forAssetKind
and have aUnionOf
for native and non-native assets, then use that withPayAssetFromAccount
.Example from
kitchensink-runtime
: