Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate pallet-remarks to v2 bench syntax #6291

Merged
merged 9 commits into from
Nov 5, 2024
Merged

migrate pallet-remarks to v2 bench syntax #6291

merged 9 commits into from
Nov 5, 2024

Conversation

clangenb
Copy link
Contributor

@clangenb clangenb commented Oct 30, 2024 •
edited
Loading

@clangenb clangenb requested a review from a team as a code owner October 30, 2024 14:16
@clangenb clangenb changed the title migrate pallet-remarks benchmarks to v2 migrate pallet-remarks to v2 bench syntax Oct 30, 2024
@AurevoirXavier AurevoirXavier mentioned this pull request Oct 30, 2024
Open
44 tasks
@ggwpez
Copy link
Member

ggwpez commented Oct 30, 2024

/cmd prdoc --bump patch --audience runtime_dev

@ggwpez ggwpez added T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights. labels Oct 30, 2024
@ggwpez ggwpez requested a review from re-gius November 1, 2024 15:49
re-gius
re-gius approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@re-gius re-gius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

substrate/frame/remark/src/benchmarking.rs Outdated Show resolved Hide resolved
@re-gius re-gius disabled auto-merge November 4, 2024 18:18
@re-gius re-gius added this pull request to the merge queue Nov 5, 2024
Merged via the queue into paritytech:master with commit 3c6ea86 Nov 5, 2024
192 of 196 checks passed
ordian added a commit that referenced this pull request Nov 5, 2024
@ordian
Merge branch 'master' into ao-fix-issue-64
9ea2099 
* master: (129 commits)
  pallet-revive: Use `RUSTUP_TOOLCHAIN` if set (#6365)
  [eth-rpc] proxy /health (#6360)
  [Release|CI/CD] adjust release pipelines (#6366)
  Bump the known_good_semver group across 1 directory with 3 updates (#6339)
  Run check semver in MQ (#6287)
  [Deprecation] deprecate treasury `spend_local` call and related items (#6169)
  refactor and harden check_core_index (#6217)
  litep2p: Update litep2p to v0.8.0 (#6353)
  [pallet-staking] Additional check for virtual stakers (#5985)
  migrate pallet-remarks to v2 bench syntax (#6291)
  Remove leftover references of Wococo (#6361)
  snowbridge: allow account conversion for Ethereum accounts (#6221)
  authority-discovery: Populate DHT records with public listen addresses (#6298)
  Bounty Pallet: add `approve_bounty_with_curator` call to `bounties` pallet (#5961)
  Silent annoying log (#6351)
  [pallet-revive] rework balance transfers (#6187)
  `statement-distribution`: RFC103 implementation (#5883)
  Disable flaky tests reported in #6343 / #6345 (#6346)
  migrate pallet-recovery to benchmark V2 syntax (#6299)
  inclusion emulator: correctly handle UMP signals (#6178)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@re-gius re-gius re-gius approved these changes

Assignees
No one assigned
Labels
T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clangenb @ggwpez @re-gius @actions-user