Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate pallet-remarks to v2 bench syntax #6291

Merged
merged 9 commits into from
Nov 5, 2024
Merged

migrate pallet-remarks to v2 bench syntax #6291

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
72c07df
migrate pallet-remarks benchmarks to v2
clangenb Oct 30, 2024
0e11e03
Merge branch 'master' into cl/pallet-remark-bench-v2
clangenb Oct 30, 2024
66f42ad
Merge branch 'master' into cl/pallet-remark-bench-v2
ggwpez Oct 30, 2024
921336f
Update from ggwpez running command 'prdoc --bump patch --audience run…
actions-user Oct 30, 2024
be00a0b
Merge branch 'master' into cl/pallet-remark-bench-v2
re-gius Nov 4, 2024
b3a598f
Update substrate/frame/remark/src/benchmarking.rs
re-gius Nov 4, 2024
5ecbc01
fmt
re-gius Nov 4, 2024
ff467e1
Merge branch 'master' into cl/pallet-remark-bench-v2
re-gius Nov 5, 2024
8119e87
Merge branch 'master' into cl/pallet-remark-bench-v2
re-gius Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions substrate/frame/remark/src/benchmarking.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

use super::*;
use alloc::vec;
use frame_benchmarking::v1::{benchmarks, whitelisted_caller};
use frame_benchmarking::v2::{*};
re-gius marked this conversation as resolved.
Show resolved Hide resolved
use frame_system::{EventRecord, Pallet as System, RawOrigin};

#[cfg(test)]
Expand All @@ -34,12 +34,17 @@ fn assert_last_event<T: Config>(generic_event: <T as Config>::RuntimeEvent) {
assert_eq!(event, &system_event);
}

benchmarks! {
store {
let l in 1 .. 1024*1024;
#[benchmarks]
mod benchmarks {
use super::*;

#[benchmark]
fn store(l: Linear<1, { 1024*1024 }>) {
let caller: T::AccountId = whitelisted_caller();
}: _(RawOrigin::Signed(caller.clone()), vec![0u8; l as usize])
verify {

#[extrinsic_call]
_(RawOrigin::Signed(caller.clone()), vec![0u8; l as usize]);

assert_last_event::<T>(Event::Stored { sender: caller, content_hash: sp_io::hashing::blake2_256(&vec![0u8; l as usize]).into() }.into());
}

Expand Down
Loading