Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor pallets to V2 bench syntax #6202

Closed
43 tasks done
ggwpez opened this issue Oct 23, 2024 · 32 comments
Closed
43 tasks done

Refactor pallets to V2 bench syntax #6202

ggwpez opened this issue Oct 23, 2024 · 32 comments
Labels
C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I4-refactor Code needs refactoring. T12-benchmarks This PR/Issue is related to benchmarking and weights.

Comments

@ggwpez
Copy link
Member

ggwpez commented Oct 23, 2024 •
edited by re-gius
Loading

We should move all remaining pallets to the V2 benchmarking syntax. It seems to be stable and feature complete.

👉 If you want to work on this: Please check that there is not already a merge request for the pallet that you want to work on. Please pick only one or a small set of pallets - not all at once. This keeps review times low.

Full pallet list:

Then the Polkadot and Cumulus pallets:
@ggwpez ggwpez added I4-refactor Code needs refactoring. T12-benchmarks This PR/Issue is related to benchmarking and weights. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. labels Oct 23, 2024
@ggwpez ggwpez changed the title Migrate all pallets to benchmarking V2 syntax Refactor pallets to V2 bench syntax Oct 23, 2024
@ggwpez ggwpez mentioned this issue Oct 23, 2024
Open
@aurexav

This comment has been minimized.

Sign in to view
This was referenced Oct 28, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 29, 2024
@aurexav
Migrate pallet-vesting benchmark to v2 (#6254)
1497635 
Part of:

- #6202.
github-merge-queue bot pushed a commit that referenced this issue Oct 29, 2024
@aurexav @seadanda
Migrate pallet-timestamp benchmark to v2 (#6258)
80cd5fd 
Part of:

- #6202

---------

Co-authored-by: Dónal Murray <donalm@seadanda.dev>
This was referenced Oct 29, 2024
Merged
Merged
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 29, 2024
@aurexav @mordamax
Migrate pallet-vesting benchmark to v2 (paritytech#6254)
1819d89 
Part of:

- paritytech#6202.
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 29, 2024
@aurexav @seadanda @mordamax
Migrate pallet-timestamp benchmark to v2 (paritytech#6258)
dee9777 
Part of:

- paritytech#6202

---------

Co-authored-by: Dónal Murray <donalm@seadanda.dev>
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 29, 2024
@aurexav @mordamax
Migrate pallet-vesting benchmark to v2 (paritytech#6254)
65ee481 
Part of:

- paritytech#6202.
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 29, 2024
@aurexav @seadanda @mordamax
Migrate pallet-timestamp benchmark to v2 (paritytech#6258)
b41419a 
Part of:

- paritytech#6202

---------

Co-authored-by: Dónal Murray <donalm@seadanda.dev>
@programskillforverification
Copy link
Contributor

programskillforverification commented Oct 30, 2024 •
edited
Loading

Pick up:

github-merge-queue bot pushed a commit that referenced this issue Oct 30, 2024
@aurexav @seadanda
Migrate pallet-utility to benchmark v2 (#6276)
06debd0 
Part of:

- #6202.

---------

Co-authored-by: Dónal Murray <donalm@seadanda.dev>
@clangenb
Copy link
Contributor

clangenb commented Oct 30, 2024 •
edited
Loading

Pickup:

@aurexav
Copy link
Contributor

aurexav commented Oct 30, 2024

Pickup:

  • pallet-remark, pallet-scheduler

Hi, I'm working scheduler currently. :)

@clangenb
Copy link
Contributor

Thanks for the quick response 🚀

Merged
@clangenb clangenb mentioned this issue Oct 30, 2024
Merged
@clangenb
Copy link
Contributor

clangenb commented Oct 30, 2024 •
edited
Loading

Pickup:

@aurexav
Copy link
Contributor

aurexav commented Oct 30, 2024

Pick up:

  • transaction-storage, indices
  • babe, child-bounties, democracy
  • fast-unstake, glutton

Well... I recommend handling them individually and providing updates here, rather than claiming them all at once.

This was referenced Oct 30, 2024
Merged
Merged
dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this issue Jan 4, 2025
@programskillforverification @re-gius
@actions-user @dudo50
Migrate pallet-transaction-storage and pallet-indices to benchmark v2 (…
8942ee1 
…paritytech#6290)

Part of:
paritytech#6202

---------

Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>
Co-authored-by: GitHub Action <action@github.com>
dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this issue Jan 4, 2025
@clangenb @re-gius
@actions-user @bkchr @dudo50
migrate pallet-nft-fractionalization to benchmarking v2 syntax (parit…
ca51c29 
…ytech#6301)

Migrates pallet-nft-fractionalization to benchmarking v2 syntax.

Part of:
* paritytech#6202

---------

Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>
Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Bastian Köcher <git@kchr.de>
dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this issue Jan 4, 2025
@aurexav @actions-user
@re-gius @dudo50
Migrate pallet-child-bounties benchmark to v2 (paritytech#6310)
1bee0cc 
Part of:

- paritytech#6202.

---------

Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>
dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this issue Jan 4, 2025
@re-gius @gui1117
@muharem @dudo50
Refactor pallet society (paritytech#6367)
f81f932 
- [x] Removing `without_storage_info` and adding bounds on the stored
types for pallet `society` - issue
paritytech#6289
- [x] Migrating to benchmarking V2 -
paritytech#6202

---------

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
Co-authored-by: Muharem <ismailov.m.h@gmail.com>
dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this issue Jan 4, 2025
@clangenb @actions-user
@gui1117 @re-gius @dudo50
migrate pallet-nomination-pool-benchmarking to benchmarking syntax v2 (…
0fd194d 
…paritytech#6302)

Migrates pallet-nomination-pool-benchmarking to benchmarking syntax v2.

Part of:
* paritytech#6202

---------

Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Guillaume Thiolliere <guillaume.thiolliere@parity.io>
Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>
dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this issue Jan 4, 2025
@programskillforverification @gui1117
@re-gius @dudo50
Migrate some pallets to benchmark v2 (paritytech#6311)
e4b458a 
Part of paritytech#6202

---------

Co-authored-by: Guillaume Thiolliere <guillaume.thiolliere@parity.io>
Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>
dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this issue Jan 4, 2025
@ndkazu @bkchr
@dmitry-markin @lexnv @dudo50
Migrate pallet-democracy benchmarks to benchmark v2 syntax (parityte…
aa4ebb8 
…ch#6509)

# Description

Migrates pallet-democracy benchmarks to benchmark v2 syntax
This is Part of paritytech#6202

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: command-bot <>
Co-authored-by: Dmitry Markin <dmitry@markin.tech>
Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this issue Jan 4, 2025
@aurexav @re-gius
@gui1117 @dudo50
Migrate pallet-scheduler benchmark to v2 (paritytech#6292)
c3654cc 
Part of:

- paritytech#6202.

---------

Signed-off-by: Xavier Lau <x@acg.box>
Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>
Co-authored-by: Guillaume Thiolliere <guillaume.thiolliere@parity.io>
dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this issue Jan 4, 2025
@Krayt78 @re-gius @dudo50
Migrating pallet-xcm-benchmarks to V2 (paritytech#6618)
7498aa3 
# Description
Migrated pallet-xcm-benchmarks to benchmaking syntax V2
This is part of paritytech#6202

---------

Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>
dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this issue Jan 4, 2025
@Krayt78 @shawntabrizi
@re-gius @dudo50
Migrating pallet-state-trie-migration to benchmarking V2 (paritytech#…
acd5c2a 
…6617)

# Description
Migrated pallet-state-trie-migration benchmarking to the new
benchmarking syntax v2.
This is part of paritytech#6202

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>
dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this issue Jan 4, 2025
@aurexav @re-gius @dudo50
Migrate pallet-preimage to benchmark v2 (paritytech#6277)
c7ecc8d 
Part of:

- paritytech#6202.

---------

Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>
Co-authored-by: command-bot <>
dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this issue Jan 4, 2025
@clangenb @shawntabrizi
@re-gius @dudo50
migrate pallet-session-benchmarking to bench V2 syntax (paritytech#6294)
87c34bd 
Migrates pallet-session-benchmarking to bench V2 syntax.

Part of:
* paritytech#6202

---------

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>
dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this issue Jan 4, 2025
@clangenb @re-gius @dudo50
migrate pallet-offences-benchmarking to benchmark v2 syntax (parityte…
26ecbdd 
…ch#6300)

Migrates pallet-offences-benchmarking to benchmark v2 syntax.

Part of:
* paritytech#6202

---------

Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>
dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this issue Jan 4, 2025
@Krayt78 @re-gius
@bkchr @dudo50
Migration of polkadot-runtime-common auctions benchmarking to v2 (par…
8c0441e 
…itytech#6613)

# Description
Migrated polkadot-runtime-common auctions benchmarking to the new
benchmarking syntax v2.
This is part of paritytech#6202

---------

Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this issue Jan 4, 2025
@clangenb @bkchr @dudo50
[polkadot-runtime-parachains] migrate paras module to benchmarking v2…
079495a 
… syntax (paritytech#6576)

[polkadot-runtime-parachains] migrate paras module to benchmarking v2
syntax

Part of:
* paritytech#6202

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this issue Jan 4, 2025
@clangenb @dudo50
Migrate pallet-xcm benchmarks to benchmark v2 syntax (paritytech#6501)
fbc9b04 
Migrates pallet-xcm benchmarks to benchmark v2 syntax

* Part of paritytech#6202
dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this issue Jan 4, 2025
@clangenb @re-gius
@bkchr @dudo50
[polkadot-runtime-parachains] migrate disputes and disputes/slashing …
1c11dae 
…to benchmarking to bench v2 syntax (paritytech#6577)

[polkadot-runtime-parachains] migrate disputes and disputes/slashing to
benchmarking to bench v2 syntax

Part of:
* paritytech#6202

---------

Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
github-merge-queue bot pushed a commit that referenced this issue Jan 27, 2025
@Krayt78 @re-gius
@seemantaggarwal @bkchr
Migrating polkadot-runtime-common slots benchmarking to v2 (#6614)
db3ff60 
#Description
Migrated polkadot-runtime-parachains slots benchmarking to the new
benchmarking syntax v2.
This is part of #6202

---------

Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>
Co-authored-by: seemantaggarwal <32275622+seemantaggarwal@users.noreply.github.com>
Co-authored-by: Bastian Köcher <git@kchr.de>
github-merge-queue bot pushed a commit that referenced this issue Jan 29, 2025
@Krayt78 @seemantaggarwal @bkchr
Migrating cumulus-pallet-session-benchmarking to Benchmarking V2 (#6564)
57f0b95 
# Description

Migrating cumulus-pallet-session-benchmarking to the new benchmarking
syntax v2.
This is a part of #6202

---------

Co-authored-by: seemantaggarwal <32275622+seemantaggarwal@users.noreply.github.com>
Co-authored-by: Bastian Köcher <git@kchr.de>
Ank4n pushed a commit that referenced this issue Feb 6, 2025
@Krayt78 @seemantaggarwal
@bkchr @Ank4n
Migrating cumulus-pallet-session-benchmarking to Benchmarking V2 (#6564)
b8aa80a 
# Description

Migrating cumulus-pallet-session-benchmarking to the new benchmarking
syntax v2.
This is a part of #6202

---------

Co-authored-by: seemantaggarwal <32275622+seemantaggarwal@users.noreply.github.com>
Co-authored-by: Bastian Köcher <git@kchr.de>
github-merge-queue bot pushed a commit that referenced this issue Feb 26, 2025
@Krayt78 @re-gius @seemantaggarwal
Migration of polkadot-runtime-common crowdloan benchmarking to v2 (#6615
2b9f83b 
)

# Description
Migrated polkadot-runtime-common crowdloan benchmarking to the new
benchmarking syntax v2.
this is part of #6202

Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>
Co-authored-by: seemantaggarwal <32275622+seemantaggarwal@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this issue Feb 26, 2025
@Krayt78 @re-gius
Migrating polkadot-runtime-parachains initializer benchmarking to v2 (#…
959f104 
…6612)

# Description
Migrated polkadot-runtime-parachains initializer benchmarking to the new
benchmarking syntax v2.
This is part of #6202

Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>
github-merge-queue bot pushed a commit that referenced this issue Feb 26, 2025
@Krayt78 @re-gius
Migrating polkadot-runtime-parachains paras_inherent benchmarking to …
0c0d892 
…V2 (#6606)

# Description

Migrating polkadot-runtime-parachains paras_inherent benchmarking to the
new benchmarking syntax v2.
This is part of #6202

---------

Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>
github-merge-queue bot pushed a commit that referenced this issue Feb 26, 2025
@Krayt78 @re-gius
Migration of polkadot-runtime-common paras_registrar benchmarking to …
10f7f41 
…v2. (#6616)

# Description
Migrated polkadot-runtime-common paras_registrar benchmarking to the new
benchmarking syntax v2.
This is part of #6202

---------

Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>
@re-gius re-gius moved this from Backlog to In Progress in Runtime / FRAME Feb 26, 2025
github-merge-queue bot pushed a commit that referenced this issue Mar 4, 2025
@Krayt78 @re-gius
@github-actions @seemantaggarwal
Migrating polkadot-runtime-parachains configuration benchmarking to V2 (
ac7037e 
#6607)

# Description
Migrating polkadot-runtime-parachains configuration benchmarking to the
new benchmarking syntax v2.
This is a part of #6202

---------

Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: seemantaggarwal <32275622+seemantaggarwal@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this issue Mar 4, 2025
@aurexav @actions-user
@re-gius @github-actions
Migrate pallet-nis benchmark to v2 (#6293)
c8d3339 
- Refactor to use the `frame` crate.
- Use procedural macro version `construct_runtime` in mock.
- Expose `PalletId` to `frame::pallet_prelude`.
- Part of #6202.

---

Polkadot address: 156HGo9setPcU2qhFMVWLkcmtCEGySLwNqa3DaEiYSWtte4Y

---------

Signed-off-by: Xavier Lau <x@acg.box>
Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@re-gius
Copy link
Contributor

re-gius commented Mar 4, 2025

Thanks to everyone who helped with the issue. Every pallet has been now migrated to v2 benchmarking.

@re-gius re-gius closed this as completed Mar 4, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Runtime / FRAME Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I4-refactor Code needs refactoring. T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

No branches or pull requests
8 participants
@kianenigma @ggwpez @aurexav @Krayt78 @ndkazu @clangenb @programskillforverification @re-gius