-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate pallet-election-provider-multi-phase benchmark to v2 and improve doc #6316
Merged
ggwpez
merged 5 commits into
paritytech:master
from
AurevoirXavier:benchmarkv2-election-provider-multi-phase
Nov 4, 2024
Merged
Migrate pallet-election-provider-multi-phase benchmark to v2 and improve doc #6316
ggwpez
merged 5 commits into
paritytech:master
from
AurevoirXavier:benchmarkv2-election-provider-multi-phase
Nov 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AurevoirXavier
changed the title
Migrate pallet-election-provider-multi-phase benchmark to v2 and impr…
Migrate pallet-election-provider-multi-phase benchmark to v2 and improve doc
Oct 31, 2024
43 tasks
gui1117
approved these changes
Nov 4, 2024
gui1117
added
T12-benchmarks
This PR/Issue is related to benchmarking and weights.
T2-pallets
This PR/Issue is related to a particular pallet.
labels
Nov 4, 2024
/cmd prdoc --bump patch --audience runtime_dev |
gui1117
reviewed
Nov 4, 2024
ggwpez
approved these changes
Nov 4, 2024
re-gius
approved these changes
Nov 4, 2024
use frame_benchmarking::account; | ||
use frame_election_provider_support::bounds::DataProviderBounds; | ||
use core::cmp::Reverse; | ||
use frame_benchmarking::{v2::*, BenchmarkError}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
use frame_benchmarking::{v2::*, BenchmarkError}; | |
use frame_benchmarking::v2::*; |
BenchmarkError
is already in v2
Merged
via the queue into
paritytech:master
with commit Nov 4, 2024
9353a28
194 of 199 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
T2-pallets
This PR/Issue is related to a particular pallet.
T12-benchmarks
This PR/Issue is related to benchmarking and weights.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: