Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pallet-election-provider-multi-phase benchmark to v2 and improve doc #6316

Conversation

AurevoirXavier
Copy link
Contributor

@AurevoirXavier AurevoirXavier changed the title Migrate pallet-election-provider-multi-phase benchmark to v2 and impr… Migrate pallet-election-provider-multi-phase benchmark to v2 and improve doc Oct 31, 2024
@gui1117 gui1117 added T12-benchmarks This PR/Issue is related to benchmarking and weights. T2-pallets This PR/Issue is related to a particular pallet. labels Nov 4, 2024
@gui1117
Copy link
Contributor

gui1117 commented Nov 4, 2024

/cmd prdoc --bump patch --audience runtime_dev

prdoc/pr_6316.prdoc Outdated Show resolved Hide resolved
@ggwpez ggwpez enabled auto-merge November 4, 2024 11:25
use frame_benchmarking::account;
use frame_election_provider_support::bounds::DataProviderBounds;
use core::cmp::Reverse;
use frame_benchmarking::{v2::*, BenchmarkError};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
use frame_benchmarking::{v2::*, BenchmarkError};
use frame_benchmarking::v2::*;

BenchmarkError is already in v2

@ggwpez ggwpez added this pull request to the merge queue Nov 4, 2024
Merged via the queue into paritytech:master with commit 9353a28 Nov 4, 2024
194 of 199 checks passed
@AurevoirXavier AurevoirXavier deleted the benchmarkv2-election-provider-multi-phase branch November 5, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants