-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate pallet-xcm benchmarks to benchmark v2 syntax #6501
Migrate pallet-xcm benchmarks to benchmark v2 syntax #6501
Conversation
bot bench cumulus-assets --runtime=asset-hub-westend --pallet=pallet_xcm |
@acatangiu https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7790277 was started for your command Comment |
Benchmarks are not compiling, please fix them, then run them for at least one runtime using command above for sanity checking results. |
@acatangiu Command |
Can you please elaborate? There was indeed a warning of unused variables because I forgot to push the last commit. This is fixed now. However, the benchmarks did compile, and they did run successfully if I interpret the results correctly from: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7790277. Were you hinting at the warnings, or is there a compile error I am not aware of? Edit: Do I have the rights to run the bot command too as a rank I fellow? |
bot bench cumulus-assets --runtime=asset-hub-westend --pallet=pallet_xcm |
@acatangiu https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7791751 was started for your command Comment |
@acatangiu Command |
…llet-to-bench-v2-syntax # Conflicts: # polkadot/xcm/pallet-xcm/src/benchmarking.rs
38c36e8
to
24dab3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
…erge conflict error
/tip small |
The referendum has appeared on Polkassembly. |
6dd4a71
Migrates pallet-xcm benchmarks to benchmark v2 syntax * Part of paritytech#6202
Migrates pallet-xcm benchmarks to benchmark v2 syntax * Part of paritytech#6202
Migrates pallet-xcm benchmarks to benchmark v2 syntax