Migrating polkadot-runtime-parachains configuration benchmarking to V2 #6607
Conversation
re-gius
added
R0-silent
|
bot bench cumulus-assets --runtime=asset-hub-westend --pallet=polkadot_runtime_parachains |
|
@re-gius https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7904252 was started for your command Comment |
|
@re-gius Command |
|
|
||
| set_config_with_perbill {}: set_on_demand_fee_variability(RawOrigin::Root, Perbill::from_percent(100)) | ||
| #[benchmark] | ||
| fn set_config_with_executor_params() { |
There was a problem hiding this comment.
could you add some explanation here defining the values being used? While reviewing, I felt this a bit out of place
There was a problem hiding this comment.
Are you talking about the parameters used in ExecutorParams ?
Do you mean explenation here on git or adding comments ?
Cause i just converted the benchmarking to the V2 syntax, i havent changed any logic from before so idk why those values are used in the first place
…iguration-benchmarking-to-V2
…iguration-benchmarking-to-V2
…iguration-benchmarking-to-V2
|
/cmd bench --pallet polkadot_runtime_parachains::configuration --runtime westend rococo |
|
Command "bench --pallet polkadot_runtime_parachains::configuration --runtime westend rococo" has started 🚀 See logs here |
…parachains::configuration --runtime westend rococo'
|
Command "bench --pallet polkadot_runtime_parachains::configuration --runtime westend rococo" has failed ❌! See logs here Command output:✅ Successful benchmarks of runtimes/pallets: |
…iguration-benchmarking-to-V2
|
The weight value changes only come from the benchmarking command bot, so it's okay - I'm merging this. |
|
/tip small |
|
The referendum has appeared on Polkassembly. |
ac7037e
Description
Migrating polkadot-runtime-parachains configuration benchmarking to the new benchmarking syntax v2.
This is a part of #6202