-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate pallet-session-benchmarking to bench V2 syntax #6294
migrate pallet-session-benchmarking to bench V2 syntax #6294
Conversation
// corresponds to the opaque key id above | ||
const KEY_TYPE_IDS: &'static [KeyTypeId] = &[KeyTypeId([100u8, 117u8, 109u8, 121u8])]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also failed on master.
---- mock::test_genesis_config_builds stdout ----
thread 'mock::test_genesis_config_builds' panicked at /home/clang/code/polkadot-sdk/substrate/frame/session/src/lib.rs:440:17:
Number of keys in session handler and session keys does not match
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
I was a bit surprised that cargo test -p pallet-session-benchmarking --features runtime-benchmarks
failed on master, is this not CI tested?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened an issue: #6726
Historical: pallet_session::historical | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This failed on master:
---- mock::test_genesis_config_builds stdout ----
thread 'mock::test_genesis_config_builds' panicked at /home/clang/code/polkadot-sdk/substrate/frame/session/src/historical/mod.rs:93:15:
No name_hash found for the pallet in the runtime! This usually means that the pallet wasn't added to `construct_runtime!`.
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
@re-gius review bump :) |
bot bench substrate-pallet --features=runtime-benchmarks --pallet=pallet_session_benchmarking |
@re-gius https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7840163 was started for your command Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run cargo +nightly fmt --all -- --check
(see CI https://github.com/paritytech/polkadot-sdk/actions/runs/11596200437/job/32286844067?pr=6294 )
@re-gius Command |
bot bench substrate-pallet --features=runtime-benchmarks --pallet=pallet_session |
@re-gius https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7841388 was started for your command Comment |
@re-gius Command |
0845044
Migrates pallet-session-benchmarking to bench V2 syntax. Part of: * paritytech#6202 --------- Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>
Migrates pallet-session-benchmarking to bench V2 syntax.
Part of: