Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate pallet-session-benchmarking to bench V2 syntax #6294

Merged
merged 6 commits into from
Dec 2, 2024

Conversation

clangenb
Copy link
Contributor

@clangenb clangenb commented Oct 30, 2024

Migrates pallet-session-benchmarking to bench V2 syntax.

Part of:

@clangenb clangenb requested a review from a team as a code owner October 30, 2024 15:15
Comment on lines +83 to +84
// corresponds to the opaque key id above
const KEY_TYPE_IDS: &'static [KeyTypeId] = &[KeyTypeId([100u8, 117u8, 109u8, 121u8])];
Copy link
Contributor Author

@clangenb clangenb Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also failed on master.

---- mock::test_genesis_config_builds stdout ----
thread 'mock::test_genesis_config_builds' panicked at /home/clang/code/polkadot-sdk/substrate/frame/session/src/lib.rs:440:17:
Number of keys in session handler and session keys does not match
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I was a bit surprised that cargo test -p pallet-session-benchmarking --features runtime-benchmarks failed on master, is this not CI tested?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened an issue: #6726

Comment on lines +45 to 46
Historical: pallet_session::historical
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This failed on master:

---- mock::test_genesis_config_builds stdout ----
thread 'mock::test_genesis_config_builds' panicked at /home/clang/code/polkadot-sdk/substrate/frame/session/src/historical/mod.rs:93:15:
No name_hash found for the pallet in the runtime! This usually means that the pallet wasn't added to `construct_runtime!`.
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@clangenb clangenb changed the title migrate pallet-session-benchmarks to bench V2 syntax migrate pallet-session-benchmarking to bench V2 syntax Oct 30, 2024
@clangenb
Copy link
Contributor Author

@re-gius review bump :)

@re-gius
Copy link
Contributor

re-gius commented Nov 29, 2024

bot bench substrate-pallet --features=runtime-benchmarks --pallet=pallet_session_benchmarking

@command-bot
Copy link

command-bot bot commented Nov 29, 2024

@re-gius https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7840163 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=runtime-benchmarks --pallet=pallet_session_benchmarking. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 8-01264b37-3878-47e9-8f85-2327d26f25f8 to cancel this command or bot cancel to cancel all commands in this pull request.

@re-gius re-gius added R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights. labels Nov 29, 2024
Copy link
Contributor

@re-gius re-gius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@command-bot
Copy link

command-bot bot commented Nov 29, 2024

@re-gius Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=runtime-benchmarks --pallet=pallet_session_benchmarking has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7840163 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7840163/artifacts/download.

@re-gius
Copy link
Contributor

re-gius commented Nov 29, 2024

bot bench substrate-pallet --features=runtime-benchmarks --pallet=pallet_session

@command-bot
Copy link

command-bot bot commented Nov 29, 2024

@re-gius https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7841388 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=runtime-benchmarks --pallet=pallet_session. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 10-c6294b99-da58-4a03-96e9-fe88dbc61a0b to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Nov 29, 2024

@re-gius Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=runtime-benchmarks --pallet=pallet_session has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7841388 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7841388/artifacts/download.

@re-gius re-gius enabled auto-merge December 2, 2024 15:18
@re-gius re-gius added this pull request to the merge queue Dec 2, 2024
Merged via the queue into paritytech:master with commit 0845044 Dec 2, 2024
192 of 198 checks passed
Krayt78 pushed a commit to Krayt78/polkadot-sdk that referenced this pull request Dec 18, 2024
Migrates pallet-session-benchmarking to bench V2 syntax.

Part of:
* paritytech#6202

---------

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants