Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Kusama Litep2p Deployed Version #6638

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

[DO NOT MERGE] Kusama Litep2p Deployed Version #6638

wants to merge 31 commits into from
+329 −85

Conversation

lexnv
Copy link
Contributor

@lexnv lexnv commented Nov 25, 2024

This PR is used to deploy litep2p in Kusama.

It contains the following fixes for litep2p:

cc @paritytech/networking

lexnv and others added 29 commits November 19, 2024 15:35
@lexnv
authority-discovery: Filter out empty addresses after removing /p2p/..
a0fca05 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
authority-discovery: Ignore empty addresses from DHT
3e3e461 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
authority-discovery/tests: Add test for is empty address
0724372 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
litep2p: Ignore empty addresses
7e5aa7b 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
litep2p/discovery: Validate empty / no-IP multiaddresses
5e71861 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
libp2p/peer_info: Confirm address only if it is valid
f36d749 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
Add PRdoc
9e7c867 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
peer_info: Downgrade warn to debug logs
109bb1c 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
network/types: Move verification of external addr
281e1eb 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
network/types: Ensure peerID functionality
f09e25c 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
Use crate::type::Multiaddr shared functionality
3906c57 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
litep2p/req-resp: Always provide main protocol name in responses
1dccdb3 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
authority-discovery: Use is_valid_external_address method
9061359 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
network/types: Enhance address validation by TCP / UDP protocols
52acb47 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
network: Rename is_valid_external_address
6389be9 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
types/tests: Check empty addresses
d109dd7 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
types/tests: Extensive tests to check the address is valid
d6da5d4 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
litep2p: Use new multiaddr functionality
6372b5f 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
Merge remote-tracking branch 'origin/master' into lexnv/authorit-empt…
0144119 
…y-addr
@lexnv
authority-discovery: Extra checks before publishing addresses
335e0e8 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
authority-discovery/tests: Test are moved to network/types
19a3c4e 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
network/types: Move is_global directly on the multiaddr
a0243b7 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
Merge branch 'master' into lexnv/authorit-empty-addr
9fe8cff
@lexnv
authorit-discovery: Add more logs
bb5653e 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
types: Do not check peerID implicitely
36ff0c7 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
types/tests: Adjust testing
457b4f1 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
Add PR doc
658154b 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
Merge remote-tracking branch 'origin/master' into lexnv/fix-sync-panic2
99a8d1b
@lexnv
Merge remote-tracking branch 'origin/lexnv/authorit-empty-addr' into …
a5c0379 
…lenxv/kusama-litep2p-fixes
@lexnv lexnv self-assigned this Nov 25, 2024
lexnv added 2 commits November 26, 2024 14:25
@lexnv
cargo: Udpdate litep2p to specific branch
ff8042d 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
litep2p: Increment incoming connections metric
68872d9 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv mentioned this pull request Nov 27, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 28, 2024
@lexnv @actions-user
chore: Update litep2p to v0.8.2 (#6677)
51c3e95 
This includes a critical fix for debug release versions of litep2p
(which are running in Kusama as validators).

While at it, have stopped the oncall pain of alerts around
`incoming_connections_total`. We can rethink the metric expose of
litep2p in Q1.





## [0.8.2] - 2024-11-27

This release ensures that the provided peer identity is verified at the
crypto/noise protocol level, enhancing security and preventing potential
misuses.
The release also includes a fix that caused `TransportService` component
to panic on debug builds.

### Fixed

- req-resp: Fix panic on connection closed for substream open failure
([#291](paritytech/litep2p#291))
- crypto/noise: Verify crypto/noise signature payload
([#278](paritytech/litep2p#278))

### Changed

- transport_service/logs: Provide less details for trace logs
([#292](paritytech/litep2p#292))


## Testing Done

This has been extensively tested in Kusama on all validators, that are
now running litep2p.

Deployed PR: #6638

### Litep2p Dashboards
![Screenshot 2024-11-26 at 19 19
41](https://github.com/user-attachments/assets/e00b2b2b-7e64-4d96-ab26-165e2b8d0dc9)


### Libp2p vs Litep2p CPU usage

After deploying litep2p we have reduced CPU usage from around 300-400%
to 200%, this is a significant boost in performance, freeing resources
for other subcomponents to function more optimally.


![image(1)](https://github.com/user-attachments/assets/fa793df5-4d58-4601-963d-246e56dd2a26)



cc @paritytech/sdk-node

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Co-authored-by: GitHub Action <action@github.com>
github-actions bot pushed a commit that referenced this pull request Nov 28, 2024
@lexnv @github-actions
chore: Update litep2p to v0.8.2 (#6677)
0f569a0 
This includes a critical fix for debug release versions of litep2p
(which are running in Kusama as validators).

While at it, have stopped the oncall pain of alerts around
`incoming_connections_total`. We can rethink the metric expose of
litep2p in Q1.

## [0.8.2] - 2024-11-27

This release ensures that the provided peer identity is verified at the
crypto/noise protocol level, enhancing security and preventing potential
misuses.
The release also includes a fix that caused `TransportService` component
to panic on debug builds.

### Fixed

- req-resp: Fix panic on connection closed for substream open failure
([#291](paritytech/litep2p#291))
- crypto/noise: Verify crypto/noise signature payload
([#278](paritytech/litep2p#278))

### Changed

- transport_service/logs: Provide less details for trace logs
([#292](paritytech/litep2p#292))

## Testing Done

This has been extensively tested in Kusama on all validators, that are
now running litep2p.

Deployed PR: #6638

### Litep2p Dashboards
![Screenshot 2024-11-26 at 19 19
41](https://github.com/user-attachments/assets/e00b2b2b-7e64-4d96-ab26-165e2b8d0dc9)

### Libp2p vs Litep2p CPU usage

After deploying litep2p we have reduced CPU usage from around 300-400%
to 200%, this is a significant boost in performance, freeing resources
for other subcomponents to function more optimally.

![image(1)](https://github.com/user-attachments/assets/fa793df5-4d58-4601-963d-246e56dd2a26)

cc @paritytech/sdk-node

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Co-authored-by: GitHub Action <action@github.com>
(cherry picked from commit 51c3e95)
@lexnv lexnv mentioned this pull request Dec 10, 2024
Closed
Krayt78 pushed a commit to Krayt78/polkadot-sdk that referenced this pull request Dec 18, 2024
@lexnv @actions-user @Krayt78
chore: Update litep2p to v0.8.2 (paritytech#6677)
43e4d82 
This includes a critical fix for debug release versions of litep2p
(which are running in Kusama as validators).

While at it, have stopped the oncall pain of alerts around
`incoming_connections_total`. We can rethink the metric expose of
litep2p in Q1.





## [0.8.2] - 2024-11-27

This release ensures that the provided peer identity is verified at the
crypto/noise protocol level, enhancing security and preventing potential
misuses.
The release also includes a fix that caused `TransportService` component
to panic on debug builds.

### Fixed

- req-resp: Fix panic on connection closed for substream open failure
([paritytech#291](paritytech/litep2p#291))
- crypto/noise: Verify crypto/noise signature payload
([paritytech#278](paritytech/litep2p#278))

### Changed

- transport_service/logs: Provide less details for trace logs
([paritytech#292](paritytech/litep2p#292))


## Testing Done

This has been extensively tested in Kusama on all validators, that are
now running litep2p.

Deployed PR: paritytech#6638

### Litep2p Dashboards
![Screenshot 2024-11-26 at 19 19
41](https://github.com/user-attachments/assets/e00b2b2b-7e64-4d96-ab26-165e2b8d0dc9)


### Libp2p vs Litep2p CPU usage

After deploying litep2p we have reduced CPU usage from around 300-400%
to 200%, this is a significant boost in performance, freeing resources
for other subcomponents to function more optimally.


![image(1)](https://github.com/user-attachments/assets/fa793df5-4d58-4601-963d-246e56dd2a26)



cc @paritytech/sdk-node

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Co-authored-by: GitHub Action <action@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lexnv lexnv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lexnv