[pallet-revive] implement the block author API #7198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
xermicus
added
R0-silent
|
bot fmt |
|
@xermicus https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8035186 was started for your command Comment |
|
@xermicus Command |
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
athei
reviewed
Jan 16, 2025
Signed-off-by: xermicus <cyrill@parity.io>
Co-authored-by: Alexander Theißen <alex.theissen@me.com>
athei
reviewed
Jan 22, 2025
Comment on lines
895
to
896
| digest.push(DigestItem::PreRuntime([1, 2, 3, 4], 123.encode())); | ||
| digest.push(DigestItem::Seal([1, 2, 4, 4], 123.encode())); |
There was a problem hiding this comment.
Is this a realistic amount of messages to be expected in this Vec? Is this the worst case?
There was a problem hiding this comment.
I see #[pallet::unbounded] over Digest and log is just alloc::vec::Vec. I don't see anything indicating this to be bounded.
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
|
You might need to add frame = { workspace = true, features = ["runtime"] }To the revive |
|
We use the dev weights in asset-hub-westend. This is why it is failing. Only run for dev. |
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
|
/cmd bench-omni --runtime dev --pallet pallet_revive --fail-fast --clean |
|
Command "bench-omni --runtime dev --pallet pallet_revive --fail-fast --clean" has started 🚀 See logs here |
…et pallet_revive --fail-fast --clean'
|
Command "bench-omni --runtime dev --pallet pallet_revive --fail-fast --clean" has finished ✅ See logs here Subweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
|
The |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
ordian
added a commit
that referenced
this pull request
Feb 3, 2025
* master: Remove warnings by cleaning up the `Cargo.toml` (#7416) [Backport] Version bumps from stable2412-1 + prdocs reorg (#7401) fix pre-dispatch PoV underweight for ParasInherent (#7378) malus-collator: implement malicious collator submitting same collation to all backing groups (#6924) `fatxpool`: use tracing for logging (#6897) Improvements for Weekly bench (#7390) Replace derivative dependency with derive-where (#7324) Add support for feature `pallet_balances/insecure_zero_ed` in benchmarks and testing (#7379) Fix Snowbridge benchmark tests (#7296) Bridges small nits/improvements (#7383) Migrating cumulus-pallet-session-benchmarking to Benchmarking V2 (#6564) [pallet-revive] implement the block author API (#7198) Use checked math in frame-balances named_reserve (#7365) move installation of frame-omni-bencher into a cmd.py itself (#7372) remove old bench & revert the frame-weight-template (#7362) ci: fix workflow permissions (#7366) [net/libp2p] Use raw `Identify` observed addresses to discover external addresses (#7338) Improve `set_validation_data` error message. (#7359) Implement pallet view function queries (#4722)
Ank4n
pushed a commit
that referenced
this pull request
Feb 6, 2025
This PR implements the block author API method. Runtimes ought to implement it such that it corresponds to the `coinbase` EVM opcode. --------- Signed-off-by: xermicus <cyrill@parity.io> Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com> Co-authored-by: command-bot <> Co-authored-by: Alexander Theißen <alex.theissen@me.com> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the block author API method. Runtimes ought to implement it such that it corresponds to the
coinbaseEVM opcode.