Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove old bench & revert the frame-weight-template #7362

Merged
merged 4 commits into from
Jan 28, 2025
Merged

remove old bench & revert the frame-weight-template #7362

merged 4 commits into from
Jan 28, 2025

Conversation

mordamax
Copy link
Contributor

@mordamax mordamax commented Jan 28, 2025 •
edited
Loading

  • remove old bench from cmd.py and left alias for backward compatibility
  • reverted the frame-wight-template as the problem was that it umbrella template wasn't picked correctly in the old benchmarks, in frame-omni-bench it correctly identifies the dependencies and uses correct template

@mordamax
Copy link
Contributor Author

/cmd bench --pallet pallet_multisig --runtime dev

@github-actions GitHub Actions
Copy link
Contributor

Command "bench --pallet pallet_multisig --runtime dev" has started 🚀 See logs here

@github-actions GitHub Actions
Copy link
Contributor

Command "bench --pallet pallet_multisig --runtime dev" has finished ✅ See logs here

Subweight results:
File Extrinsic Old New Change [%]
cumulus/pallets/collator-selection/src/weights.rs leave_intent - - ERROR
cumulus/pallets/collator-selection/src/weights.rs new_session - - ERROR
cumulus/pallets/collator-selection/src/weights.rs register_as_candidate - - ERROR
cumulus/pallets/collator-selection/src/weights.rs set_invulnerables - - ERROR
cumulus/pallets/collator-selection/src/weights.rs take_candidate_slot - - ERROR
cumulus/pallets/collator-selection/src/weights.rs update_bond - - ERROR
cumulus/parachains/runtimes/assets/asset-hub-rococo/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/assets/asset-hub-rococo/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_preimage.rs ensure_updated - - ERROR
cumulus/parachains/runtimes/people/people-rococo/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/people/people-rococo/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/people/people-westend/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/people/people-westend/src/weights/pallet_collator_selection.rs update_bond - - ERROR
polkadot/runtime/westend/src/weights/pallet_preimage.rs ensure_updated - - ERROR
substrate/frame/election-provider-support/src/weights.rs phragmen - - ERROR
substrate/frame/election-provider-support/src/weights.rs phragmms - - ERROR
substrate/frame/multisig/src/weights.rs as_multi_create 200.42us 189.21us -5.59
substrate/frame/multisig/src/weights.rs as_multi_approve 183.33us 172.94us -5.67
substrate/frame/multisig/src/weights.rs approve_as_multi_approve 161.53us 151.88us -5.98
substrate/frame/multisig/src/weights.rs cancel_as_multi 178.54us 167.01us -6.45
substrate/frame/multisig/src/weights.rs approve_as_multi_create 178.08us 166.55us -6.47
substrate/frame/multisig/src/weights.rs as_multi_threshold_1 85.64us 75.06us -12.36
Command output:

✅ Successful benchmarks of runtimes/pallets:
-- dev: ['pallet_multisig']

@mordamax mordamax marked this pull request as ready for review January 28, 2025 13:46
@mordamax mordamax requested review from a team as code owners January 28, 2025 13:46
@mordamax mordamax added the R0-silent Changes should not be mentioned in any release notes label Jan 28, 2025
@rockbmb rockbmb changed the title remove old bench & revert the frame-wight-template remove old bench & revert the frame-weight-template Jan 28, 2025
rockbmb
rockbmb approved these changes Jan 28, 2025
View reviewed changes
substrate/frame/multisig/src/weights.rs
// Estimated: `3997`
// Minimum execution time: 28_800_000 picoseconds.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the weights have improved (i.e. lowered).

What happened here, does this mean the multisig pallet has had incorrect weights up until this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure tbh :)

@mordamax mordamax enabled auto-merge January 28, 2025 19:28
iulianbarbu
iulianbarbu reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@iulianbarbu iulianbarbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Curious on why the weights for multisig decreased as well. Were there any changes to the pallet that results in such improvements?

@mordamax mordamax added this pull request to the merge queue Jan 28, 2025
@mordamax mordamax mentioned this pull request Jan 28, 2025
Closed
Merged via the queue into master with commit 9ab00b1 Jan 28, 2025
210 of 212 checks passed
@mordamax mordamax deleted the mak-remove-old-bench branch January 28, 2025 20:08
@mordamax
Copy link
Contributor Author

LGTM! Curious on why the weights for multisig decreased as well. Were there any changes to the pallet that results in such improvements?

@iulianbarbu maybe something not stable, not sure, we will check this again with all benches regenerated

ordian added a commit that referenced this pull request Feb 3, 2025
@ordian
Merge branch 'master' into ao-migrate-zombie-past-slashing-test
83a2992 
* master:
  Remove warnings by cleaning up the `Cargo.toml` (#7416)
  [Backport] Version bumps from stable2412-1 + prdocs reorg (#7401)
  fix pre-dispatch PoV underweight for ParasInherent (#7378)
  malus-collator: implement malicious collator submitting same collation to all backing groups (#6924)
  `fatxpool`: use tracing for logging (#6897)
  Improvements for Weekly bench (#7390)
  Replace derivative dependency with derive-where (#7324)
  Add support for feature `pallet_balances/insecure_zero_ed` in benchmarks and testing (#7379)
  Fix Snowbridge benchmark tests (#7296)
  Bridges small nits/improvements (#7383)
  Migrating cumulus-pallet-session-benchmarking to Benchmarking V2  (#6564)
  [pallet-revive] implement the block author API  (#7198)
  Use checked math in frame-balances named_reserve (#7365)
  move installation of frame-omni-bencher into a cmd.py itself (#7372)
  remove old bench & revert the frame-weight-template (#7362)
  ci: fix workflow permissions (#7366)
  [net/libp2p] Use raw `Identify` observed addresses to discover external addresses (#7338)
  Improve `set_validation_data` error message. (#7359)
  Implement pallet view function queries (#4722)
Ank4n pushed a commit that referenced this pull request Feb 6, 2025
@mordamax @github-actions @Ank4n
remove old bench & revert the frame-weight-template (#7362)
0631837 
- remove old bench from cmd.py and left alias for backward compatibility
- reverted the frame-wight-template as the problem was that it umbrella
template wasn't picked correctly in the old benchmarks, in
frame-omni-bench it correctly identifies the dependencies and uses
correct template

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndWeHaveAPlan AndWeHaveAPlan AndWeHaveAPlan approved these changes

@iulianbarbu iulianbarbu iulianbarbu approved these changes

@rockbmb rockbmb rockbmb approved these changes

@alvicsam alvicsam alvicsam approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mordamax @AndWeHaveAPlan @iulianbarbu @rockbmb @alvicsam