Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Bump jsonrpc-core to v15 #1737

Merged
merged 2 commits into from
Sep 21, 2020
Merged

Bump jsonrpc-core to v15 #1737

merged 2 commits into from
Sep 21, 2020

Conversation

maciejhirsz
Copy link
Contributor

@maciejhirsz maciejhirsz added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C3-medium PR touches the given topic and has a medium impact on builders. labels Sep 21, 2020
gnunicorn
gnunicorn approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@gnunicorn gnunicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But some version mixing I'd like to see explained.

Cargo.lock Outdated
@@ -2414,7 +2414,7 @@ checksum = "ecbdaacc17243168d9d1fa6b2bd7556a27e1e60a621d8a2a6e590ae2b145d158"
dependencies = [
"failure",
"futures 0.1.29",
"jsonrpc-core",
"jsonrpc-core 14.2.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this still contain 14.2.0 versions? We updated all jsonrpc to 15.0, right? By here some dependencies are specified as still bound to jsonrpc-core 14.2.0, is that intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I commited this after building with current substrate master, that's why it's there.

@gnunicorn gnunicorn mentioned this pull request Sep 21, 2020
Merged
@ghost
Copy link

ghost commented Sep 21, 2020

Waiting for commit status.

@ghost
Copy link

ghost commented Sep 21, 2020

Checks failed; merge aborted.

@gnunicorn gnunicorn added B1-releasenotes and removed B0-silent Changes should not be mentioned in any release notes labels Sep 21, 2020
@gnunicorn
Copy link
Contributor

bot merge

@ghost
Copy link

ghost commented Sep 21, 2020

Trying merge.

@ghost
Copy link

ghost commented Sep 21, 2020

Merge failed: "At least 3 approving reviews are required by reviewers with write access."

@gnunicorn gnunicorn merged commit 01778f2 into master Sep 21, 2020
@gnunicorn gnunicorn deleted the mh-bump-jsonrpc branch September 21, 2020 09:08
ordian added a commit that referenced this pull request Sep 21, 2020
@ordian
Merge branch 'master' into prgn-remove-old-service-second-try
036080b 
* master:
  Bump jsonrpc-core to v15 (#1737)
  Companion PR for #6215 (#1654)
  Companion PR for #7138 (WeightInfo for Scheduler) (#1734)
  Companion PR for Bounties #5715 (#1336)
ordian added a commit that referenced this pull request Sep 22, 2020
@ordian
Merge branch 'master' into ao-validator-discovery-api
9534c2b 
* master:
  Companion for 7155 (WeightInfo for Babe and Grandpa) (#1736)
  Companion PR for #7136 (WeightInfo for Session / Offences) (#1735)
  Bump jsonrpc-core to v15 (#1737)
  Companion PR for #6215 (#1654)
  Companion PR for #7138 (WeightInfo for Scheduler) (#1734)
  Companion PR for Bounties #5715 (#1336)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian approved these changes

@gnunicorn gnunicorn gnunicorn approved these changes

@dvdplm dvdplm Awaiting requested review from dvdplm

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C3-medium PR touches the given topic and has a medium impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maciejhirsz @gnunicorn @ordian