Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

paras: dismiss pvf_checking_enabled configuration #7138

Merged
merged 16 commits into from
May 8, 2023
Merged

paras: dismiss pvf_checking_enabled configuration #7138

merged 16 commits into from
May 8, 2023

Conversation

slumber
Copy link
Contributor

@slumber slumber commented Apr 26, 2023

Part of #3211

Node side doesn't require any changes. Prechecking subsystem is conditionally disabled if the node is not authority, disregarding the runtime configuration. So I suggest we leave it as is.

Removing pvf_checking_enabled from host configuration requires storage migration. This can be done in the same PR or in a follow-up, depending on how quickly this gets merged. For now it's simply ignored.

@slumber slumber added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. B1-note_worthy Changes should be noted in the release notes labels Apr 26, 2023
@slumber slumber requested review from eskimor, pepyakin and ordian April 26, 2023 14:41
@ordian ordian added the T1-runtime This PR/Issue is related to the topic “runtime”. label Apr 26, 2023
@slumber slumber mentioned this pull request Apr 26, 2023
Closed
24 tasks
@slumber slumber force-pushed the slumber-dismiss-prechecking-cfg branch from 8ea6667 to a50ca39 Compare April 26, 2023 23:18
@slumber slumber force-pushed the slumber-dismiss-prechecking-cfg branch from aa599df to 09927f9 Compare April 27, 2023 09:04
@slumber slumber mentioned this pull request May 2, 2023
Closed
@slumber
Copy link
Contributor Author

slumber commented May 2, 2023

bot bench $ runtime polkadot runtime_parachains::paras

@command-bot
Copy link

command-bot bot commented May 2, 2023 •
edited
Loading

@slumber https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2766578 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime polkadot runtime_parachains::paras. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 19-56cbc500-0ab1-4a3b-bba3-66998546da8a to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented May 2, 2023

@slumber Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime polkadot runtime_parachains::paras has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2766578 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2766578/artifacts/download.

@slumber
Copy link
Contributor Author

slumber commented May 2, 2023

bot bench $ runtime kusama runtime_parachains::paras

@command-bot
Copy link

command-bot bot commented May 2, 2023 •
edited
Loading

@slumber https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2766810 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime kusama runtime_parachains::paras. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 20-4e0dc300-2035-4c60-9551-7128217ff3ab to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented May 2, 2023

@slumber Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime kusama runtime_parachains::paras has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2766810 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2766810/artifacts/download.

@slumber
Copy link
Contributor Author

slumber commented May 3, 2023

bot bench $ runtime rococo runtime_parachains::paras

@command-bot
Copy link

command-bot bot commented May 3, 2023 •
edited
Loading

@slumber https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2767605 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime rococo runtime_parachains::paras. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 21-604e96d4-785c-4c8a-b443-ef8eca250e52 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented May 3, 2023

@slumber Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime rococo runtime_parachains::paras has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2767605 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2767605/artifacts/download.

@slumber
Copy link
Contributor Author

slumber commented May 3, 2023

bot bench $ runtime westend runtime_parachains::paras

@command-bot
Copy link

command-bot bot commented May 3, 2023 •
edited
Loading

@slumber https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2769086 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime westend runtime_parachains::paras. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 23-265217b2-3935-4cde-a49c-64f4ac9e936f to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented May 3, 2023

@slumber Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime westend runtime_parachains::paras has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2769086 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2769086/artifacts/download.

mrcnski
mrcnski approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@mrcnski mrcnski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super familiar with the runtime-side so I read this for education. Maybe ignore my approval but I think it looks good.

runtime/parachains/src/paras/tests.rs Outdated Show resolved Hide resolved
@eskimor
Copy link
Member

eskimor commented May 5, 2023

Nice! Great work, only two small remarks. The weight explosion is interesting, do you have any explanation?

@slumber
Copy link
Contributor Author

slumber commented May 7, 2023

bot merge

@paritytech-processbot
Copy link

Error: Statuses failed for 8bc1b33

@slumber
Copy link
Contributor Author

slumber commented May 8, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 64a4f32 into master May 8, 2023
@paritytech-processbot paritytech-processbot bot deleted the slumber-dismiss-prechecking-cfg branch May 8, 2023 18:58
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Closed
@slumber slumber mentioned this pull request Jun 19, 2023
Merged
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrcnski mrcnski mrcnski approved these changes

@ordian ordian ordian approved these changes

@eskimor eskimor eskimor approved these changes

@pepyakin pepyakin Awaiting requested review from pepyakin

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slumber @eskimor @ordian @mrcnski