This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
paras: adjust weights for root dispatchables #6347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slumber
added
A3-in_progress
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
Closed in favor of #7138 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
force_schedule_code_upgradecan kick off a pvf-check which should be taken into account. This one is simple.There's also
add_trusted_validation_code, it's weight cannot be computed ahead of dispatch: an edge case is when there're a lot of paras having the same code hash they want to upgrade to and this code undergoes a prechecking.In order to know how many paras are doing it, it's necessary to access a chain state (
PvfActiveVoteMap).It's of course not crucial because pvf check always concludes or times out at worst.
One simple possible approach is to require some generous weight for the call and then compute it in flight, refunding the rest. Given it may only be used by root or governance, should be fine.