Companion PR for #8682

[tomaka]

paritytech/substrate#8682

[ghost]

Waiting for commit status.

[ghost]

Merge aborted: Checks failed for e67f157

[ordian]

@joao-paulo-parity simnet check is not required, but the companion merge has failed nevertheless, is this expected?

[TriplEight]

@ordian simnet check was supposed to be required (and was), but I had to unmark it bc Simnet was a bit broken. Now it's about to be stabilized and the "required" check will return.

[TriplEight]

But the fact that the bot has "required" checks configured elsewhere is rather odd, though.

[joao-paulo-parity]

@joao-paulo-parity simnet check is not required, but the companion merge has failed nevertheless, is this expected?

@TriplEight @ordian

The trigger-simnet job does not have allow_failure: true, so it is expected. That is solely what determines if a check can be skipped. We don't consider Github "required status" settings into account for skipping fallible statuses.

polkadot/.gitlab-ci.yml

Line 366 in 46e3986

trigger-simnet:

[ordian]

But the fact that the bot has "required" checks configured elsewhere is rather odd, though.

The trigger-simnet job does not have allow_failure: true, so it is expected. That is solely what determines if a check can be skipped. We don't consider Github "required status" settings into account for skipping fallible statuses.

I don't understand what's the distinction between allow_failure: true and Github "requered status" setting, and will let you judge whether its needs to have allow_failure: true. But please make sure simnet check is ignored by bot until it's proved to be stable (e.g. not spuriously failing for a week).

[cla-bot-2021]

@ordian No commands could be detected from your comment.

[joao-paulo-parity]

@ordian

#2958 (comment) is some sort of bug, don't mind it

I don't understand what's the distinction between allow_failure: true and Github "requered status" setting

• allow_failure: true is the job's outcome from Gitlab.

• Github "required status" are statuses which will block the merge if they are not passing.

If any Gitlab check needs to be ignored temporarily, simply put allow_failure: true in .gitlab-ci.yml for that job. That setting is precisely for brittle/fallible/unstable jobs. It doesn't make sense to me to create custom rules in the bot when that setting is already proper.