This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Allow fallback names for protocols #8682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A0-please_review
kpp
reviewed
Apr 29, 2021
kpp
reviewed
Apr 29, 2021
kpp
reviewed
Apr 29, 2021
client/network/src/protocol/notifications/upgrade/notifications.rs
Outdated
Show resolved
Hide resolved
kpp
reviewed
Apr 29, 2021
kpp
reviewed
Apr 29, 2021
client/network/src/protocol/notifications/upgrade/notifications.rs
Outdated
Show resolved
Hide resolved
kpp
approved these changes
Apr 29, 2021
Co-authored-by: Roman Proskuryakov <humbug@deeptown.org>
This was referenced Apr 29, 2021
|
bot merge |
|
Trying merge. |
|
Bot will approve on the behalf of @tomaka, since they are a team lead, in an attempt to reach the minimum approval count |
ghost
approved these changes
May 6, 2021
ghost
merged commit
nazar-pc
pushed a commit
to autonomys/substrate
that referenced
this pull request
Aug 8, 2021
* Allow fallback names for protocols * Apply suggestions from code review Co-authored-by: Roman Proskuryakov <humbug@deeptown.org> * Fix some issues * Fix compilation after merging master Co-authored-by: Roman Proskuryakov <humbug@deeptown.org>
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #6605
There are some protocols in the networking stack that we would like to rename.
In order to do so while maintaining backwards compatibility, this PR introduces the possibility to pass a list of fallback names when configuring a protocol.
When the substream actually gets opened, a new
negotiated_fallbackfield indicates which names has actually been used during the negotiation.Most of the changes in this PR are small refactorings. Before this PR, we would pass information as a tuple of three elements. Adding a fourth element would be a bit too much, so I turned them into structs.
Important note: the
negotiated_fallbackfield indicates the protocol used to negotiate the outbound substream. The one used for the inbound substream is not reported. If you don't do anything stupid, then the protocol names for the outbound and inbound substreams should always be the same. However, if between two versions you swap the legacy protocol name and the new protocol name, or if you have multiple legacy names and you change their order, then there will be a mismatch.polkadot companion: paritytech/polkadot#2958