Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Companion for Assets Freezer pallet #3131

Closed
wants to merge 1 commit into from
Closed

Companion for Assets Freezer pallet #3131

wants to merge 1 commit into from

Conversation

athei
Copy link
Member

@athei athei commented May 28, 2021

@athei athei added B7-runtimenoteworthy A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels May 28, 2021
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label May 28, 2021
athei
athei commented May 28, 2021
View reviewed changes
xcm/xcm-builder/src/fungibles_adapter.rs
@@ -178,7 +178,7 @@ impl<
// This is an asset whose teleports we track.
let checking_account = CheckingAccount::get();
Assets::can_withdraw(asset_id, &checking_account, amount)
.into_result()
.into_result(false)
Copy link
Member Author

@athei athei May 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting keep_alive: false produces the same result as before but is it correct? @gavofyork

@athei athei mentioned this pull request May 28, 2021
Closed
4 tasks
@athei athei requested a review from gavofyork May 29, 2021 10:24
@athei
Copy link
Member Author

athei commented Sep 10, 2021

Is this stale? Can I close it?

@athei
Copy link
Member Author

athei commented Jan 18, 2022

Closing because stale.

@athei athei closed this Jan 18, 2022
@athei athei deleted the gav-asset-freezer branch September 25, 2022 10:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gavofyork gavofyork Awaiting requested review from gavofyork

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@athei