-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
Holds should be named like #7778 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@riusricardo what's the status quo here?
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
No love for this one? is it blocked in some big way? just here to tell stale bot 🤖 that this is important and if there's anything us the simple mortals can do to help we'll be glad to. |
what is blocking this issue? |
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
AFAIK it is still relevant, it is just less priority than the other stuff |
@thiolliere If I wanted to takeover what would be required to merge it? |
When the PR was opened it only needed to be reviewed, now we also need to merge master. But it only makes sense to keep it up to date if people are available for reviewing it. |
ok, so the PR is to be kept open, but no contribution is required?
…On Mon, Sep 6, 2021 at 3:27 PM Guillaume Thiolliere < ***@***.***> wrote:
@thiolliere <https://github.com/thiolliere> If I wanted to takeover what
would be required to merge it?
When the PR was opened it only needed to be reviewed, now we also need to
merge master. But it only makes sense to keep it up to date if people are
available for reviewing it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#8476 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABIEJVJABYOQAN64UBGI6SLUAS6UNANCNFSM4Z6KJSGA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
Probably pretty stale now, but...
Polkadot companion: paritytech/polkadot#3131
TODO:
AssetsFreezer
toAssetsHolder
.AssetsHolder
to implement the newfungibles::hold::*
API.AssetsFreezer
which implementsfungibles::freeze::*
API.