This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
companion PR to removal of light client #4105
Merged
paritytech-processbot
merged 15 commits into
paritytech:master
from
gilescope:giles-remove-light-client
Oct 30, 2021
Merged
companion PR to removal of light client #4105
paritytech-processbot
merged 15 commits into
paritytech:master
from
gilescope:giles-remove-light-client
Oct 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilescope
added
A3-in_progress
Pull request is in progress. No review needed at this stage.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit.
labels
Oct 19, 2021
bkchr
suggested changes
Oct 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The light-node
feature and any code that is hidden by it should be removed.
Removed light-node in one commit. Another commit makes full-node mandatory - is that something we want to do @bkchr? |
No please revert. |
gilescope
requested review from
HCastano,
svyatonik and
tomusdrw
as code owners
October 26, 2021 09:51
tomusdrw
approved these changes
Oct 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bridges changes are fine :)
gilescope
added
A0-please_review
Pull request needs code review.
and removed
A3-in_progress
Pull request is in progress. No review needed at this stage.
labels
Oct 26, 2021
bkchr
approved these changes
Oct 29, 2021
Waiting for commit status. |
emostov
pushed a commit
that referenced
this pull request
Nov 1, 2021
* not needed * cargo fmt * remove light-node * make full-node feature mandatory? * cargo fmt * Revert "cargo fmt" This reverts commit 5a2c7d8. * Revert "make full-node feature mandatory?" This reverts commit c35eb4f. * bump versionn numbers * Update bridges/primitives/chain-westend/src/lib.rs * fix typo + expand dictionary * update lockfile for substrate Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: parity-processbot <>
23 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The substrate light client is being removed now that https://github.com/paritytech/substrate-connect exists.
companion to paritytech/substrate#9684