Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

companion PR to removal of light client #4105

Merged

Conversation

gilescope
Copy link
Contributor

@gilescope gilescope commented Oct 19, 2021

The substrate light client is being removed now that https://github.com/paritytech/substrate-connect exists.

companion to paritytech/substrate#9684

@gilescope gilescope added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Oct 19, 2021
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The light-node feature and any code that is hidden by it should be removed.

@gilescope
Copy link
Contributor Author

Removed light-node in one commit. Another commit makes full-node mandatory - is that something we want to do @bkchr?

@bkchr
Copy link
Member

bkchr commented Oct 25, 2021

Removed light-node in one commit. Another commit makes full-node mandatory - is that something we want to do @bkchr?

No please revert.

Copy link
Contributor

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bridges changes are fine :)

@gilescope gilescope added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Oct 26, 2021
@gilescope gilescope requested a review from bkchr October 26, 2021 17:11
bridges/primitives/chain-westend/src/lib.rs Outdated Show resolved Hide resolved
@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 0696615 into paritytech:master Oct 30, 2021
ordian added a commit that referenced this pull request Oct 30, 2021
* master:
  remove duplicate Deposit from OnUnbalanced implementation (#4180)
  differentiate log messages (#4183)
  increase ump_service_total_weight's default value (#4127)
  companion PR to removal of light client (#4105)
  Introduce `OriginPrivilegeCmp` (#4166)
emostov pushed a commit that referenced this pull request Nov 1, 2021
* not needed

* cargo fmt

* remove light-node

* make full-node feature mandatory?

* cargo fmt

* Revert "cargo fmt"

This reverts commit 5a2c7d8.

* Revert "make full-node feature mandatory?"

This reverts commit c35eb4f.

* bump versionn numbers

* Update bridges/primitives/chain-westend/src/lib.rs

* fix typo + expand dictionary

* update lockfile for substrate

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: parity-processbot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants