Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

remove duplicate Deposit from OnUnbalanced implementation #4180

Merged
merged 1 commit into from
Oct 30, 2021
Merged

remove duplicate Deposit from OnUnbalanced implementation #4180

merged 1 commit into from
Oct 30, 2021

Conversation

apopiak
Copy link
Contributor

@apopiak apopiak commented Oct 29, 2021

Due to paritytech/substrate#9425 there is already a deposit event created for the block author rewards.

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Oct 29, 2021
@apopiak apopiak added B1-releasenotes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Oct 29, 2021
@apopiak apopiak merged commit fb730e4 into master Oct 30, 2021
@apopiak apopiak deleted the apopiak/remove-duplicate-deposit-event branch October 30, 2021 16:39
ordian added a commit that referenced this pull request Oct 30, 2021
@ordian
Merge branch 'master' into ao-collator-prototol-a-fix
a21b8da 
* master:
  remove duplicate Deposit from OnUnbalanced implementation (#4180)
  differentiate log messages (#4183)
  increase ump_service_total_weight's default value (#4127)
  companion PR to removal of light client (#4105)
  Introduce `OriginPrivilegeCmp` (#4166)
emostov pushed a commit that referenced this pull request Nov 1, 2021
@apopiak @emostov
remove duplicate Deposit from OnUnbalanced implementation (#4180)
58c1e48 
closes #4133
@apopiak apopiak mentioned this pull request Nov 5, 2021
Closed
@AurevoirXavier AurevoirXavier mentioned this pull request Nov 9, 2021
Closed
@github-actions github-actions bot mentioned this pull request Dec 2, 2021
Closed
@ghzlatarev ghzlatarev mentioned this pull request Dec 6, 2021
Merged
23 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@KiChjang KiChjang Awaiting requested review from KiChjang

@gui1117 gui1117 Awaiting requested review from gui1117

@kianenigma kianenigma Awaiting requested review from kianenigma

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apopiak @shawntabrizi