-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can help @brunopgalvao over here #5052 when you are done.
He updates the rococo weights but currently uses the bot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general.
Can you make sure that this diff touches all runtime weight files?
AFAIK this should modify all files in runtime/polkadot/src/weights
(and the other runtime dirs) excluding mod.rs
.
fn new_auction() -> Weight { | ||
(24_436_000 as Weight) | ||
(11_899_000 as Weight) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As explanation here and in other places: paritytech/substrate#10692 should have reduced all weights across all runtimes.
Substrate weights were updated in that MR but Polkadot et.al. not.
.saturating_add(T::DbWeight::get().reads(5 as Weight)) | ||
.saturating_add(T::DbWeight::get().writes(4 as Weight)) | ||
(8_646_169_000 as Weight) | ||
.saturating_add(T::DbWeight::get().reads(8 as Weight)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The number of Read/Writes should only change when there was a logic change that did not update the weights.
Happened in Substrate quite often but I don't know about Polkadot.
// Storage: Paras CodeByHash (r:0 w:1) | ||
fn force_set_current_code(c: u32, ) -> Weight { | ||
(0 as Weight) | ||
// Standard Error: 0 | ||
.saturating_add((3_000 as Weight).saturating_mul(c as Weight)) | ||
.saturating_add(T::DbWeight::get().reads(2 as Weight)) | ||
.saturating_add(T::DbWeight::get().writes(3 as Weight)) | ||
.saturating_add(T::DbWeight::get().reads(4 as Weight)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KiChjang there are quite some changes in the Read/Write counts here; do you know of mayor changes to the parachain stuff that did not update the weights?
In other files as well.
.saturating_add(T::DbWeight::get().reads(1 as Weight)) | ||
.saturating_add(T::DbWeight::get().writes(1 as Weight)) | ||
} | ||
// Storage: System Account (r:1 w:1) | ||
fn transfer_keep_alive() -> Weight { | ||
(23_391_000 as Weight) | ||
(24_829_000 as Weight) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the pallet already have updated weights as you can see at the date
fn as_multi_create(s: u32, z: u32) -> Weight { | ||
(48_627_000 as Weight) | ||
// Storage: Multisig Multisigs (r:1 w:1) | ||
// Storage: unknown [0x3a65787472696e7369635f696e646578] (r:1 w:0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder what this means
The files that did not get updated are
Associated benchmark errors: |
// Standard Error: 56_000 | ||
.saturating_add((4_963_000 as Weight).saturating_mul(s as Weight)) | ||
(3_348_741_000 as Weight) | ||
// Standard Error: 223_000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it play any role if this number raises so significantly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would imply that there was a change that was not re-benchmarked, as in general this should not happen.
/benchmark runtime polkadot frame_system |
Benchmark Runtime Polkadot Pallet for branch "coderobe/weights-18-m" with command cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=frame_system --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/ Toolchain: stable-x86_64-unknown-linux-gnu (default) Results
|
…coderobe/weights-18-m
…-- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=frame_system --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/
/benchmark runtime kusama frame_system |
Benchmark Runtime Kusama Pallet for branch "coderobe/weights-18-m" with command cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=frame_system --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/ Toolchain: stable-x86_64-unknown-linux-gnu (default) Results
|
/benchmark runtime westend frame_system |
…-- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=frame_system --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/
Benchmark Runtime Westend Pallet for branch "coderobe/weights-18-m" with command cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=frame_system --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/ Toolchain: stable-x86_64-unknown-linux-gnu (default) Results
|
…coderobe/weights-18-m
We are working to fix the broken benchmarks. Thanks for reporting! Until then, you should not worry about getting the latest benchmarks for releasing |
Alright. I'll go about merging this once the frame_system benchapp results are in, and we'll deal with the failed benchmarks separately. Sound good? @shawntabrizi |
…-- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=frame_system --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/
bot merge |
Error: Github API says #5097 is not mergeable |
pallet_election_provider_multi_phase: Invalid input: SignedCannotPayDeposit will fix these two, indeed a regression. |
No description provided.