Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

update weights #5098

Merged
merged 13 commits into from
Mar 16, 2022
Merged

update weights #5098

merged 13 commits into from
Mar 16, 2022

Conversation

coderobe
Copy link
Contributor

@coderobe coderobe commented Mar 14, 2022

similar to #5097 but on the release branch. weights from different benchmark run as master & release branch diverged too much to apply the exact same weights patches cleanly

@coderobe coderobe added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Mar 14, 2022
Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The weights should run using the production profile.

runtime/kusama/src/weights/runtime_common_auctions.rs Outdated Show resolved Hide resolved
@chevdor
Copy link
Contributor

chevdor commented Mar 14, 2022

ref #5100

@ggwpez ggwpez self-requested a review March 14, 2022 12:20
@coderobe coderobe requested a review from chevdor March 16, 2022 10:23
@coderobe
Copy link
Contributor Author

the weights should now be in sync with #5098

@ggwpez
Copy link
Member

ggwpez commented Mar 16, 2022

So this is now doing the same as #5098?

@coderobe
Copy link
Contributor Author

coderobe commented Mar 16, 2022

So this is now doing the same

Yes

@coderobe
Copy link
Contributor Author

Seeing that the weights have been reviewed in the pr targeting master, I'll consider them reviewed here as well. I'll be merging this once i have backported the frame_system benchapp weights from #5097 (waiting on results atm)

Parity Bot added 3 commits March 16, 2022 15:43
…-- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=frame_system --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/
…-- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=frame_system --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/
…-- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=frame_system --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/
@coderobe coderobe merged commit 99cd17d into release-v0.9.18 Mar 16, 2022
@coderobe coderobe deleted the coderobe/weights-18 branch March 16, 2022 15:46
coderobe added a commit that referenced this pull request Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants