Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

update weights #5843

Merged
merged 7 commits into from
Aug 1, 2022
Merged

update weights #5843

merged 7 commits into from
Aug 1, 2022

Conversation

coderobe
Copy link
Contributor

@coderobe coderobe commented Aug 1, 2022 •
edited by chevdor
Loading

weights from the 0.9.27 release benchmarks 🏋️‍♀️

Backport to master: #5844

cumulus companion branch: test-release-v0.9.27

@coderobe coderobe added A8-backport A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Aug 1, 2022
@coderobe coderobe mentioned this pull request Aug 1, 2022
Merged
@chevdor chevdor added this to the v0.9.27 milestone Aug 1, 2022
chevdor
chevdor approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new weights are very constistant with the previous 0.9.26-1 release.

runtime/kusama/src/weights/pallet_election_provider_multi_phase.rs
@@ -89,11 +89,11 @@ impl<T: frame_system::Config> pallet_election_provider_multi_phase::WeightInfo f
/// The range of component `v` is `[1000, 2000]`.
/// The range of component `t` is `[500, 1000]`.
fn create_snapshot_internal(v: u32, t: u32, ) -> Weight {
(21_636_000 as Weight)
(0 as Weight)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Down to 0

runtime/kusama/src/weights/pallet_scheduler.rs
(0 as Weight)
// Standard Error: 36_000
.saturating_add((24_281_000 as Weight).saturating_mul(s as Weight))
(908_000 as Weight)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 to 900k

runtime/polkadot/src/weights/pallet_scheduler.rs
(1_851_000 as Weight)
// Standard Error: 29_000
.saturating_add((23_826_000 as Weight).saturating_mul(s as Weight))
(0 as Weight)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

down to 0

ggwpez
ggwpez approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to SWC staging (since Im testing some stuff).
Extrinsic and Block weights look good.

@coderobe
Copy link
Contributor Author

coderobe commented Aug 1, 2022

error[E0046]: not all trait items implemented, missing: remove_member_wrong_refund
--> /builds/parity/mirrors/polkadot/runtime/kusama/src/weights/pallet_elections_phragmen.rs:46:1
|
46 | impl<T: frame_system::Config> pallet_elections_phragmen::WeightInfo for WeightInfo {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing remove_member_wrong_refund in implementation
|
= help: implement the missing item: fn remove_member_wrong_refund() -> u64 { todo!() }

coderobe
coderobe commented Aug 1, 2022
View reviewed changes
runtime/kusama/src/weights/pallet_elections_phragmen.rs
.saturating_add(T::DbWeight::get().reads(5 as Weight))
.saturating_add(T::DbWeight::get().writes(5 as Weight))
}
// Storage: PhragmenElection RunnersUp (r:1 w:0)
fn remove_member_wrong_refund() -> Weight {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, this got dropped, breaking the build. i'll undo this change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep not your fault, caused by paritytech/substrate#11790 which removed the benchmark but did not update the weight-trait.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggwpez should i merge your pr into this branch to fix it rather than readding the old weight?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be probably slightly cleaner to remove it from the trait as in my MR for Polkadot and Kusama.
This only makes a difference if someone re-benchmarks on this branch.

@ggwpez ggwpez mentioned this pull request Aug 1, 2022
Merged
@coderobe
Copy link
Contributor Author

coderobe commented Aug 1, 2022

test failures:
---- test_fees::full_block_council_election_cost stdout ----
can support 6748 voters in a single block for council elections; total bond 138846
thread 'test_fees::full_block_council_election_cost' panicked at 'assertion failed: cost_dollars > 150_000', runtime/polkadot/src/lib.rs:2128:9

@coderobe
Copy link
Contributor Author

coderobe commented Aug 1, 2022

this is the one we already fixed last time, isn't it

@ggwpez @coderobe
Reduce testing constants (#5787)
236eac8 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@coderobe
Copy link
Contributor Author

coderobe commented Aug 1, 2022

test-linux-stable has some unrelated nonfatal errors in the test execution:

Error: 
   0: Other: can only use subcommand with --chain [polkadot-dev, kusama-dev, westend-dev, rococo-dev, wococo-dev], got ksmcc3
  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
                                ⋮ 5 frames hidden ⋮                               
   6: <core::result::Result<T,F> as core::ops::try_trait::FromResidual<core::result::Result<core::convert::Infallible,E>>>::from_residual::hb6013e93a45d6539
      at /rustc/e092d0b6b43f2de967af0887873151bb1c0b18d3/library/core/src/result.rs:2105
   7: polkadot::main::h147a60bb32358d3d
      at /builds/parity/mirrors/polkadot/src/main.rs:25
   8: core::ops::function::FnOnce::call_once::hf3c5751998646e70
      at /rustc/e092d0b6b43f2de967af0887873151bb1c0b18d3/library/core/src/ops/function.rs:248
                                ⋮ 14 frames hidden ⋮

This is not our fault though and should probably be fixed by whoever maintains the test ci

@coderobe
Copy link
Contributor Author

coderobe commented Aug 1, 2022

also Aug 01 11:54:47.708 ERROR runtime::inclusion-inherent: BUG: disputed_bitfield != expected_bits and a handful of other various things

@coderobe
Copy link
Contributor Author

coderobe commented Aug 1, 2022

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information.

@chevdor
Copy link
Contributor

chevdor commented Aug 1, 2022

bot merge

@paritytech-processbot
Copy link

Error: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information.

@chevdor chevdor merged commit b017bad into release-v0.9.27 Aug 1, 2022
@chevdor chevdor deleted the coderobe/weights-27 branch August 1, 2022 12:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@chevdor chevdor chevdor approved these changes

@EgorPopelyaev EgorPopelyaev Awaiting requested review from EgorPopelyaev

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
v0.9.27
Development

Successfully merging this pull request may close these issues.
3 participants
@coderobe @chevdor @ggwpez