Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove remove_member_wrong_refund from phragmen WeightInfo #11952

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Remove remove_member_wrong_refund from phragmen WeightInfo #11952

merged 2 commits into from
Aug 1, 2022

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Aug 1, 2022 •
edited
Loading

#11790 removed a benchmark and did not remove the remnant function from the WeightInfo, causing a build failure in paritytech/polkadot#5843 (comment).

Polkadot companion: paritytech/polkadot#5848

@ggwpez
Remove 'remove_member_wrong_refund' from WeightInfo
4edf494 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez requested a review from kianenigma as a code owner August 1, 2022 10:31
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Aug 1, 2022
@ggwpez
Copy link
Member Author

ggwpez commented Aug 1, 2022

/cmd queue -c bench-bot $ pallet dev pallet_elections_phragmen

@command-bot
Copy link

command-bot bot commented Aug 1, 2022 •
edited
Loading

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1712620 was started for your command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_elections_phragmen. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 38-fa878a22-1a67-4516-b11a-f68e15529d3d to cancel this command or /cmd cancel to cancel all commands in this pull request.

@ggwpez ggwpez added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit and removed A0-please_review Pull request needs code review. labels Aug 1, 2022
@bkchr
Copy link
Member

bkchr commented Aug 1, 2022

Why didn't we catch this in the Substrate CI?

@ggwpez ggwpez mentioned this pull request Aug 1, 2022
Merged
@ggwpez
Copy link
Member Author

ggwpez commented Aug 1, 2022

Why didn't we catch this in the Substrate CI?

The CI does not notice if you need to call benchmark as a result of changed benchmarks.
But as soon as its updated here, it requires a Polkadot comp. So its somehow checked.
Need another approval on the companion 😄

@command-bot
Copy link

command-bot bot commented Aug 1, 2022

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_elections_phragmen has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1712620 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1712620/artifacts/download.

@ggwpez
Copy link
Member Author

ggwpez commented Aug 1, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 457de07 into master Aug 1, 2022
@paritytech-processbot paritytech-processbot bot deleted the oty-update-phragmen-weight-trait branch August 1, 2022 18:56
DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
@ggwpez @DaviRain-Su
Remove remove_member_wrong_refund from phragmen WeightInfo (parit…
c1ac585 
…ytech#11952)

* Remove 'remove_member_wrong_refund' from WeightInfo

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* ".git/.scripts/bench-bot.sh" pallet dev pallet_elections_phragmen

Co-authored-by: command-bot <>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@ggwpez @ark0f
Remove remove_member_wrong_refund from phragmen WeightInfo (parit…
d5c47bd 
…ytech#11952)

* Remove 'remove_member_wrong_refund' from WeightInfo

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* ".git/.scripts/bench-bot.sh" pallet dev pallet_elections_phragmen

Co-authored-by: command-bot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coderobe coderobe coderobe approved these changes

@bkchr bkchr bkchr approved these changes

@kianenigma kianenigma kianenigma approved these changes

Assignees
No one assigned
Labels
A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ggwpez @bkchr @kianenigma @coderobe