This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Get rid of unnecessary cloning and work. #6808
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed when studying the logs that we do quite a bit of unnecessary work - studying the code, it was even worse than it looked like. Not only that we fetch the session info for each and every vote in a dispute, we also cloned the
SessionInfo
each time, while in reality no clone at all is necessary. This PR therefore gets rid of ~500SessionInfo
clones per dispute (on Versi).This should be quite some speedup for vote import from chain. I also removed a costly debug assert - it served its purpose and is likely causing significant slowdown on testnets.