This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Decrease expected peer count in zombinenet tests #6826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent change in the in/out peer ratio caused some of the zombienet tests to fail. Adjust the number of expected peers to reflect the new ratio to make tests pass again.
altonen
added
A0-please_review
altonen
commented
Mar 6, 2023
pepoviola
approved these changes
Mar 6, 2023
bkchr
reviewed
Mar 6, 2023
|
@altonen I can not really help with review, but thank you for bringing this up. |
bkchr
approved these changes
Mar 6, 2023
|
@muharem can you still approve to make the CI checks happy? :D |
muharem
approved these changes
Mar 6, 2023
sandreim
reviewed
Mar 6, 2023
| @@ -32,16 +32,6 @@ eve: parachain 2005 is registered within 60 seconds | |||
| one: parachain 2006 is registered within 60 seconds | |||
| two: parachain 2007 is registered within 60 seconds | |||
|
|
|||
| # Check if network is fully connected. | |||
| alice: reports peers count is at least 15 within 20 seconds | |||
There was a problem hiding this comment.
I would still check that we have connectivity here, even if the logic changed and it's hard to estimate number of peers.
There was a problem hiding this comment.
#6826 (comment) see this discussion.
|
@bkchr this is not just approve for Ci (: it make sense to me after reading your chat. |
ordian
added a commit
that referenced
this pull request
Mar 7, 2023
* master: (27 commits) bump `zombienet` version to v1.3.37 (#6773) Bump `blake2b_simd` to 1.0.1 (#6829) changelog: update template for new label behavior (E3/E4) (#6804) Companion for paritytech/substrate#12828 (#6380) Don't send `ActiveLeaves` from leaves in db on startup in Overseer (#6727) Polkadot XCM Body constants (#6788) Decrease expected peer count in zombinenet tests (#6826) Additional tracing in `provisioner`, `vote_selection` and `dispute-coordinator` (#6775) Change node-key for bootnodes (#6772) Change handle_import_statements to FatalResult (#6820) Introduce XCM matcher for writing barriers (#6756) Freeze note on `SessionInfo`. (#6818) Bump parity-db (#6816) Removing Outdated References to Misbehavior Arbitration Subsystem (#6814) Forgotten re-export for `MatchedConvertedConcreteId` (#6815) Companion for substrate#13509: bump API versions of {Beefy,Mmr}Api (#6809) Migrate to `Weight::from_parts` (#6794) [XCM] Multiple `FungiblesAdapter`s support + `WeightTrader::buy_weight` more accurate error (#6739) Get rid of unnecessary cloning and work. (#6808) changelog: fix migration listing (#6806) ...
ordian
added a commit
that referenced
this pull request
Mar 7, 2023
* master: (27 commits) bump `zombienet` version to v1.3.37 (#6773) Bump `blake2b_simd` to 1.0.1 (#6829) changelog: update template for new label behavior (E3/E4) (#6804) Companion for paritytech/substrate#12828 (#6380) Don't send `ActiveLeaves` from leaves in db on startup in Overseer (#6727) Polkadot XCM Body constants (#6788) Decrease expected peer count in zombinenet tests (#6826) Additional tracing in `provisioner`, `vote_selection` and `dispute-coordinator` (#6775) Change node-key for bootnodes (#6772) Change handle_import_statements to FatalResult (#6820) Introduce XCM matcher for writing barriers (#6756) Freeze note on `SessionInfo`. (#6818) Bump parity-db (#6816) Removing Outdated References to Misbehavior Arbitration Subsystem (#6814) Forgotten re-export for `MatchedConvertedConcreteId` (#6815) Companion for substrate#13509: bump API versions of {Beefy,Mmr}Api (#6809) Migrate to `Weight::from_parts` (#6794) [XCM] Multiple `FungiblesAdapter`s support + `WeightTrader::buy_weight` more accurate error (#6739) Get rid of unnecessary cloning and work. (#6808) changelog: fix migration listing (#6806) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent change in the in/out peer ratio caused some of the zombienet tests to fail. Adjust the number of expected peers to reflect the new ratio to make tests pass again.