This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Histogram support in runtime metrics #6935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for histograms to the runtime metrics. Additionally add `polkadot_parachain_verify_dispute_signature` histogram which tracks the time needed from the runtime to verify a single validator signature of a dispute statement.
tdimitrov
added
A0-please_review
tdimitrov
commented
Mar 21, 2023
tdimitrov
commented
Mar 21, 2023
| @@ -176,4 +188,14 @@ pub mod metric_definitions { | |||
| description: "Counts the number of bitfields signature checked in `enter_inner`.", | |||
There was a problem hiding this comment.
This metric doesn't work (before and after my changes) for some reason - it's not reported at all by prometheus. I'll investigate further.
There was a problem hiding this comment.
I've created a follow up issue for this: https://github.com/paritytech/polkadot/issues/6943
tdimitrov
added
the
D3-trivial 🧸
tdimitrov
commented
Mar 22, 2023
|
Result on Versi:
|
sandreim
reviewed
Mar 23, 2023
| @@ -20,30 +20,33 @@ | |||
| //! tracing support. This requires that the custom profiler (`TraceHandler`) to be | |||
| //! registered in substrate via a `logger_hook()`. Events emitted from runtime are | |||
| //! then captured/processed by the `TraceHandler` implementation. | |||
| //! | |||
| //! Don't add logs in this file because it gets executed before the logger is | |||
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
sandreim
approved these changes
Mar 27, 2023
eskimor
approved these changes
Mar 28, 2023
|
Do you have a link to that Versi histogram - I would love to have a closer look. |
|
Yes @eskimor: https://grafana.parity-mgmt.parity.io/d/rrbzx79nz/disputes?orgId=1&var-data_source=thanos&var-chain=versi_v1_10&from=1679574006458&to=1679587000062 Ignore the |
|
bot merge |
ordian
added a commit
that referenced
this pull request
Mar 29, 2023
* master: Companion: wasm-builder support stable Rust (#6967) Fix feature (#6966) configuration: backport async backing parameters from the feature branch (#6961) Histogram support in runtime metrics (#6935) Bump openssl from 0.10.38 to 0.10.48 (#6955) Proxy for Nomination Pools (#6846) Nomination Pools migration v5: RewardPool fix (#6957) bump timestamp script to v0.2 (#6954) Subsystem channel tweaks (#6905) Companion for #13683 (#6944) inherent disputes: remove per block initializer and disputes timeout event (#6937)
ordian
added a commit
that referenced
this pull request
Mar 29, 2023
…slashing-client * ao-past-session-slashing-runtime: Companion: wasm-builder support stable Rust (#6967) Fix feature (#6966) configuration: backport async backing parameters from the feature branch (#6961) Histogram support in runtime metrics (#6935) Bump openssl from 0.10.38 to 0.10.48 (#6955) Proxy for Nomination Pools (#6846) Nomination Pools migration v5: RewardPool fix (#6957)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for histograms to the runtime metrics. Additionally add
polkadot_parachain_verify_dispute_signaturehistogram which tracks the time needed from the runtime to verify a single validator signature of a dispute statement.